| Message ID | 20180904102500.30318-11-srinivas.kandagatla@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ASoC: Add support to WCD9335 Audio Codec | expand |
On Tue, Sep 04, 2018 at 11:24:57AM +0100, Srinivas Kandagatla wrote: > This patch add new bindings required to support MBHC > (Multi Button Headset Control) block in the codec. > This block is used for jack insert/removal detection, > headset type detection and 8 button press/release events. > > All these properties are very much specific to board. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > --- > .../bindings/sound/qcom,wcd9335.txt | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt b/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt > index 5d6ea66a863f..4d56c3ca9fa8 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt > +++ b/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt > @@ -55,6 +55,26 @@ Required properties with SLIMbus Interface: > Value type: <string> > Definition: Must contain "mclk", "mclk2" and "slimbus" strings. > > +- qcom,mbhc-vthreshold: Needs unit suffix. > + Usage: Optional, only required if headset button support required. > + Value type: <u32 array> > + Definition: Must contain an array of 8 threshold voltages in mV for > + 8 buttons detection on headset. > + > +- qcom,hphl-jack-type-normally-open: > + Usage: Optional, only required if headset button support required. It's not required if the pin is NC, right? > + Value type: <boolean> > + Definition: present if hphl pin on jack is a NO (Normally Open). > + If not specified, then its assumed that hphl pin on jack > + is NC (Normally Closed). Is the not specified case the more common case? If not, it should be. > + > +- qcom,gnd-jack-type-normally-open: > + Usage: Optional, only required if headset button support required. Same here. > + Value type: <boolean> > + Definition: present if gnd pin on jack is NO (Normally Open). > + If not specified, then its assumed that gnd pin on > + jack is NC (Normally Closed). > + > - vdd-buck-supply: > Usage: required > Value type: <phandle> > -- > 2.18.0 >
Thanks for your review, On 10/09/18 21:06, Rob Herring wrote: > On Tue, Sep 04, 2018 at 11:24:57AM +0100, Srinivas Kandagatla wrote: >> This patch add new bindings required to support MBHC >> (Multi Button Headset Control) block in the codec. >> This block is used for jack insert/removal detection, >> headset type detection and 8 button press/release events. >> >> All these properties are very much specific to board. >> >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >> --- >> .../bindings/sound/qcom,wcd9335.txt | 20 +++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt b/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt >> index 5d6ea66a863f..4d56c3ca9fa8 100644 >> --- a/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt >> +++ b/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt >> @@ -55,6 +55,26 @@ Required properties with SLIMbus Interface: >> Value type: <string> >> Definition: Must contain "mclk", "mclk2" and "slimbus" strings. >> >> +- o qcom,mbhc-vthreshold: > > Needs unit suffix. Make sense, I will modify it qcom,mbhc-vthreshold-millivolt > > >> + Usage: Optional, only required if headset button support required. >> + Value type: <u32 array> >> + Definition: Must contain an array of 8 threshold voltages in mV for >> + 8 buttons detection on headset. >> + >> +- qcom,hphl-jack-type-normally-open: >> + Usage: Optional, only required if headset button support required. > > It's not required if the pin is NC, right? > >> + Value type: <boolean> >> + Definition: present if hphl pin on jack is a NO (Normally Open). >> + If not specified, then its assumed that hphl pin on jack >> + is NC (Normally Closed). > > Is the not specified case the more common case? If not, it should be. Yes, that is correct. In normal uscases we do not need these properties. > >> + >> +- qcom,gnd-jack-type-normally-open: >> + Usage: Optional, only required if headset button support required. > > Same here. > >> + Value type: <boolean> >> + Definition: present if gnd pin on jack is NO (Normally Open). >> + If not specified, then its assumed that gnd pin on >> + jack is NC (Normally Closed). >> + >> - vdd-buck-supply: >> Usage: required >> Value type: <phandle> >> -- >> 2.18.0 >>
diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt b/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt index 5d6ea66a863f..4d56c3ca9fa8 100644 --- a/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt +++ b/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt @@ -55,6 +55,26 @@ Required properties with SLIMbus Interface: Value type: <string> Definition: Must contain "mclk", "mclk2" and "slimbus" strings. +- qcom,mbhc-vthreshold: + Usage: Optional, only required if headset button support required. + Value type: <u32 array> + Definition: Must contain an array of 8 threshold voltages in mV for + 8 buttons detection on headset. + +- qcom,hphl-jack-type-normally-open: + Usage: Optional, only required if headset button support required. + Value type: <boolean> + Definition: present if hphl pin on jack is a NO (Normally Open). + If not specified, then its assumed that hphl pin on jack + is NC (Normally Closed). + +- qcom,gnd-jack-type-normally-open: + Usage: Optional, only required if headset button support required. + Value type: <boolean> + Definition: present if gnd pin on jack is NO (Normally Open). + If not specified, then its assumed that gnd pin on + jack is NC (Normally Closed). + - vdd-buck-supply: Usage: required Value type: <phandle>
This patch add new bindings required to support MBHC (Multi Button Headset Control) block in the codec. This block is used for jack insert/removal detection, headset type detection and 8 button press/release events. All these properties are very much specific to board. Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> --- .../bindings/sound/qcom,wcd9335.txt | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+)