[07/11] audit: Remove pointless check in insert_hash()
diff mbox series

Message ID 20180904160632.21210-8-jack@suse.cz
State New
Headers show
  • audit: Fix various races when tagging and untagging mounts
Related show

Commit Message

Jan Kara Sept. 4, 2018, 4:06 p.m. UTC
The audit_tree_group->mark_mutex is held all the time while we create
the fsnotify mark, add it to the inode, and insert chunk into the hash.
Hence mark cannot get detached during this time and so the check whether
the mark is attached in insert_hash() is pointless.

Signed-off-by: Jan Kara <jack@suse.cz>
 kernel/audit_tree.c | 2 --
 1 file changed, 2 deletions(-)

diff mbox series

diff --git a/kernel/audit_tree.c b/kernel/audit_tree.c
index 6978a92f6fef..af91b0d33478 100644
--- a/kernel/audit_tree.c
+++ b/kernel/audit_tree.c
@@ -184,8 +184,6 @@  static void insert_hash(struct audit_chunk *chunk)
 	struct list_head *list;
-	if (!(chunk->mark.flags & FSNOTIFY_MARK_FLAG_ATTACHED))
-		return;
 	 * Make sure chunk is fully initialized before making it visible in the
 	 * hash. Pairs with a data dependency barrier in READ_ONCE() in