| Message ID | 20180905062924.23836-2-wqu@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | btrfs-progs: print-tree: breadth-first tree print order | expand |
On 5.09.2018 09:29, Qu Wenruo wrote: > When printing tree nodes, we output slots like: > key (EXTENT_TREE ROOT_ITEM 0) block 73625600 (17975) gen 16 > > The number in the parentheses is blockptr / nodesize. > > However this number doesn't really do any thing useful. > And in fact for unaligned metadata block group (block group start bytenr > is not aligned to 16K), the number doesn't even make sense as it's > rounded down. > > In factor kernel doesn't ever output such divided result in its > print-tree.c > > Remove it so later reader won't wonder what the number means. > > Signed-off-by: Qu Wenruo <wqu@suse.com> Reviewed-by: Nikolay Borisov <nborisov@suse.com> > --- > print-tree.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/print-tree.c b/print-tree.c > index a09ecfbb28f0..31f6fa12522f 100644 > --- a/print-tree.c > +++ b/print-tree.c > @@ -1420,9 +1420,8 @@ void btrfs_print_tree(struct extent_buffer *eb, int follow) > btrfs_disk_key_to_cpu(&key, &disk_key); > printf("\t"); > btrfs_print_key(&disk_key); > - printf(" block %llu (%llu) gen %llu\n", > + printf(" block %llu gen %llu\n", > (unsigned long long)blocknr, > - (unsigned long long)blocknr / eb->len, > (unsigned long long)btrfs_node_ptr_generation(eb, i)); > fflush(stdout); > } >
diff --git a/print-tree.c b/print-tree.c index a09ecfbb28f0..31f6fa12522f 100644 --- a/print-tree.c +++ b/print-tree.c @@ -1420,9 +1420,8 @@ void btrfs_print_tree(struct extent_buffer *eb, int follow) btrfs_disk_key_to_cpu(&key, &disk_key); printf("\t"); btrfs_print_key(&disk_key); - printf(" block %llu (%llu) gen %llu\n", + printf(" block %llu gen %llu\n", (unsigned long long)blocknr, - (unsigned long long)blocknr / eb->len, (unsigned long long)btrfs_node_ptr_generation(eb, i)); fflush(stdout); }
When printing tree nodes, we output slots like: key (EXTENT_TREE ROOT_ITEM 0) block 73625600 (17975) gen 16 The number in the parentheses is blockptr / nodesize. However this number doesn't really do any thing useful. And in fact for unaligned metadata block group (block group start bytenr is not aligned to 16K), the number doesn't even make sense as it's rounded down. In factor kernel doesn't ever output such divided result in its print-tree.c Remove it so later reader won't wonder what the number means. Signed-off-by: Qu Wenruo <wqu@suse.com> --- print-tree.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)