diff mbox series

[kvm-unit-tests] x86: UMIP: Fix wrong print of CR4.UMIP bit status

Message ID 20180905232800.10318-1-liran.alon@oracle.com (mailing list archive)
State New, archived
Headers show
Series [kvm-unit-tests] x86: UMIP: Fix wrong print of CR4.UMIP bit status | expand

Commit Message

Liran Alon Sept. 5, 2018, 11:28 p.m. UTC 
Reviewed-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>
Signed-off-by: Liran Alon <liran.alon@oracle.com>
---
 x86/umip.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Sean Christopherson Sept. 6, 2018, 4:07 p.m. UTC | #1 
On Thu, Sep 06, 2018 at 02:28:00AM +0300, Liran Alon wrote:
> Reviewed-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>
> Signed-off-by: Liran Alon <liran.alon@oracle.com>
> ---
>  x86/umip.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/x86/umip.c b/x86/umip.c
> index cda19714579f..357ca3cbe065 100644
> --- a/x86/umip.c
> +++ b/x86/umip.c
> @@ -187,8 +187,8 @@ int main()
>      }
>      write_cr4(read_cr4() | X86_CR4_UMIP);
>  
> -    test_umip_nogp("UMIP=0, CPL=0\n");
> -    do_ring3(test_umip_gp, "UMIP=0, CPL=3\n");
> +    test_umip_nogp("UMIP=1, CPL=0\n");
> +    do_ring3(test_umip_gp, "UMIP=1, CPL=3\n");
>  
>      return report_summary();
>  }
> -- 
> 2.16.1

Reviewed-by: Sean Christopherson <sean.j.christopherson@intel.com>
Paolo Bonzini Sept. 14, 2018, 5:59 p.m. UTC | #2 
On 06/09/2018 01:28, Liran Alon wrote:
> Reviewed-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>
> Signed-off-by: Liran Alon <liran.alon@oracle.com>
> ---
>  x86/umip.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/x86/umip.c b/x86/umip.c
> index cda19714579f..357ca3cbe065 100644
> --- a/x86/umip.c
> +++ b/x86/umip.c
> @@ -187,8 +187,8 @@ int main()
>      }
>      write_cr4(read_cr4() | X86_CR4_UMIP);
>  
> -    test_umip_nogp("UMIP=0, CPL=0\n");
> -    do_ring3(test_umip_gp, "UMIP=0, CPL=3\n");
> +    test_umip_nogp("UMIP=1, CPL=0\n");
> +    do_ring3(test_umip_gp, "UMIP=1, CPL=3\n");
>  
>      return report_summary();
>  }
> 

Queued, thanks.

Paolo
diff mbox series

Patch

diff --git a/x86/umip.c b/x86/umip.c
index cda19714579f..357ca3cbe065 100644
--- a/x86/umip.c
+++ b/x86/umip.c
@@ -187,8 +187,8 @@  int main()
     }
     write_cr4(read_cr4() | X86_CR4_UMIP);
 
-    test_umip_nogp("UMIP=0, CPL=0\n");
-    do_ring3(test_umip_gp, "UMIP=0, CPL=3\n");
+    test_umip_nogp("UMIP=1, CPL=0\n");
+    do_ring3(test_umip_gp, "UMIP=1, CPL=3\n");
 
     return report_summary();
 }