| Message ID | 4E444552.9030105@panasas.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Boaz Harrosh wrote: What about the below? based on v3.1-rc1 ---- From: Boaz Harrosh <bharrosh@panasas.com> Subject: [PATCH] pnfs: Automatically select blocks & objects layouts Just like files-layout, blocks & objects layouts are part of the NFS 4.1 protocol and should be automatically selected if NFS_4_1 is selected. The small problem is that these depend on other Kernel support being present, while files only depends on NFS itself. This patch removes from the user choice the presence of objects and blocks layout. But makes sure these are selected only if the depended subsystems are present in the Kernel. Signed-off-by: Boaz Harrosh <bharrosh@panasas.com> Acked-by: Jim Rees <rees@umich.edu> I think this is what we want. There is no point allowing the user to pick and choose various layout drivers. If they have selected nfs4.1 they should get all the layout drivers their kernel will support, based on the dependencies. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Aug 12, 2011 at 6:13 AM, Jim Rees <rees@umich.edu> wrote: > Boaz Harrosh wrote: > > What about the below? based on v3.1-rc1 > > ---- > From: Boaz Harrosh <bharrosh@panasas.com> > Subject: [PATCH] pnfs: Automatically select blocks & objects layouts > > Just like files-layout, blocks & objects layouts are part of the > NFS 4.1 protocol and should be automatically selected if NFS_4_1 > is selected. The small problem is that these depend on other > Kernel support being present, while files only depends on NFS > itself. > > This patch removes from the user choice the presence of objects > and blocks layout. But makes sure these are selected only if > the depended subsystems are present in the Kernel. > > Signed-off-by: Boaz Harrosh <bharrosh@panasas.com> > > Acked-by: Jim Rees <rees@umich.edu> > > I think this is what we want. There is no point allowing the user to pick > and choose various layout drivers. If they have selected nfs4.1 they should > get all the layout drivers their kernel will support, based on the > dependencies. > I agree automatically selecting is more reasonable. Acked-by: Peng Tao <peng_tao@emc.com>
diff --git a/fs/nfs/Kconfig b/fs/nfs/Kconfig index be02077..1b951cd 100644 --- a/fs/nfs/Kconfig +++ b/fs/nfs/Kconfig @@ -79,9 +79,6 @@ config NFS_V4_1 depends on NFS_FS && NFS_V4 && EXPERIMENTAL select SUNRPC_BACKCHANNEL select PNFS_FILE_LAYOUT - select PNFS_BLOCK - select MD - select BLK_DEV_DM help This option enables support for minor version 1 of the NFSv4 protocol (RFC 5661 and RFC 5663) in the kernel's NFS client. @@ -93,16 +90,13 @@ config PNFS_FILE_LAYOUT config PNFS_BLOCK tristate + depends on NFS_FS && NFS_V4_1 && MD && BLK_DEV_DM + default m config PNFS_OBJLAYOUT - tristate "Provide support for the pNFS Objects Layout Driver for NFSv4.1 pNFS (EXPERIMENTAL)" + tristate depends on NFS_FS && NFS_V4_1 && SCSI_OSD_ULD - help - Say M here if you want your pNFS client to support the Objects Layout Driver. - Requires the SCSI osd initiator library (SCSI_OSD_INITIATOR) and - upper level driver (SCSI_OSD_ULD). - - If unsure, say N. + default m config ROOT_NFS bool "Root file system on NFS"