| Message ID | 20180906122603.390-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mmc: sdhci: Remove "Unknown controller version" error message | expand |
On 06/09/18 15:26, Hans de Goede wrote: > Controllers with a host->version > SDHCI_SPEC_300 have been out in the > field since at least March 2015 and have been working without any > problems since. We have a patch to bring it up to date: https://lore.kernel.org/lkml/1535617305-16952-2-git-send-email-zhang.chunyan@linaro.org/T/#u > > As such the error message surves no purpose, other then to scare users > and causing them to file bugs about. > > This commit removes the error message, so that we will not get any more > bugs about it. > > BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1205070 > BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1444638 > BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1626016 > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > drivers/mmc/host/sdhci.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c > index 1b3fbd9bd5c5..cc908ffffac2 100644 > --- a/drivers/mmc/host/sdhci.c > +++ b/drivers/mmc/host/sdhci.c > @@ -3506,11 +3506,6 @@ int sdhci_setup_host(struct sdhci_host *host) > > override_timeout_clk = host->timeout_clk; > > - if (host->version > SDHCI_SPEC_300) { > - pr_err("%s: Unknown controller version (%d). You may experience problems.\n", > - mmc_hostname(mmc), host->version); > - } > - > if (host->quirks & SDHCI_QUIRK_FORCE_DMA) > host->flags |= SDHCI_USE_SDMA; > else if (!(host->caps & SDHCI_CAN_DO_SDMA)) >
Hi, On 06-09-18 14:40, Adrian Hunter wrote: > On 06/09/18 15:26, Hans de Goede wrote: >> Controllers with a host->version > SDHCI_SPEC_300 have been out in the >> field since at least March 2015 and have been working without any >> problems since. > > We have a patch to bring it up to date: > > https://lore.kernel.org/lkml/1535617305-16952-2-git-send-email-zhang.chunyan@linaro.org/T/#u Ah, great, that is even better :) Regards, Hans > >> >> As such the error message surves no purpose, other then to scare users >> and causing them to file bugs about. >> >> This commit removes the error message, so that we will not get any more >> bugs about it. >> >> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1205070 >> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1444638 >> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1626016 >> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> >> --- >> drivers/mmc/host/sdhci.c | 5 ----- >> 1 file changed, 5 deletions(-) >> >> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c >> index 1b3fbd9bd5c5..cc908ffffac2 100644 >> --- a/drivers/mmc/host/sdhci.c >> +++ b/drivers/mmc/host/sdhci.c >> @@ -3506,11 +3506,6 @@ int sdhci_setup_host(struct sdhci_host *host) >> >> override_timeout_clk = host->timeout_clk; >> >> - if (host->version > SDHCI_SPEC_300) { >> - pr_err("%s: Unknown controller version (%d). You may experience problems.\n", >> - mmc_hostname(mmc), host->version); >> - } >> - >> if (host->quirks & SDHCI_QUIRK_FORCE_DMA) >> host->flags |= SDHCI_USE_SDMA; >> else if (!(host->caps & SDHCI_CAN_DO_SDMA)) >> >
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 1b3fbd9bd5c5..cc908ffffac2 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -3506,11 +3506,6 @@ int sdhci_setup_host(struct sdhci_host *host) override_timeout_clk = host->timeout_clk; - if (host->version > SDHCI_SPEC_300) { - pr_err("%s: Unknown controller version (%d). You may experience problems.\n", - mmc_hostname(mmc), host->version); - } - if (host->quirks & SDHCI_QUIRK_FORCE_DMA) host->flags |= SDHCI_USE_SDMA; else if (!(host->caps & SDHCI_CAN_DO_SDMA))
Controllers with a host->version > SDHCI_SPEC_300 have been out in the field since at least March 2015 and have been working without any problems since. As such the error message surves no purpose, other then to scare users and causing them to file bugs about. This commit removes the error message, so that we will not get any more bugs about it. BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1205070 BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1444638 BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1626016 Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/mmc/host/sdhci.c | 5 ----- 1 file changed, 5 deletions(-)