| Message ID | 1536548104-57453-1-git-send-email-zhongjiang@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | sh: mm: Use dma_zalloc_coherent instead of dma_alloc_coherent + memset | expand |
On Mon, Sep 10, 2018 at 5:07 AM zhong jiang <zhongjiang@huawei.com> wrote: > dma_zalloc_coherent has taken the dma_alloc_coherent() and memset() into > account. Therefore, just use dma_zalloc_coherent to replace the open code. > > Signed-off-by: zhong jiang <zhongjiang@huawei.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
diff --git a/arch/sh/mm/consistent.c b/arch/sh/mm/consistent.c index 792f361..aa4e450 100644 --- a/arch/sh/mm/consistent.c +++ b/arch/sh/mm/consistent.c @@ -52,14 +52,12 @@ int __init platform_resource_setup_memory(struct platform_device *pdev, if (!memsize) return 0; - buf = dma_alloc_coherent(&pdev->dev, memsize, &dma_handle, GFP_KERNEL); + buf = dma_zalloc_coherent(&pdev->dev, memsize, &dma_handle, GFP_KERNEL); if (!buf) { pr_warning("%s: unable to allocate memory\n", name); return -ENOMEM; } - memset(buf, 0, memsize); - r->flags = IORESOURCE_MEM; r->start = dma_handle; r->end = r->start + memsize - 1;
dma_zalloc_coherent has taken the dma_alloc_coherent() and memset() into account. Therefore, just use dma_zalloc_coherent to replace the open code. Signed-off-by: zhong jiang <zhongjiang@huawei.com> --- arch/sh/mm/consistent.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)