From patchwork Tue Sep 11 17:57:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josef Bacik X-Patchwork-Id: 10596099 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 52BEC14BD for ; Tue, 11 Sep 2018 17:58:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3FBC229B9F for ; Tue, 11 Sep 2018 17:58:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 344BC29BA1; Tue, 11 Sep 2018 17:58:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DB33429B9F for ; Tue, 11 Sep 2018 17:58:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728332AbeIKW7V (ORCPT ); Tue, 11 Sep 2018 18:59:21 -0400 Received: from mail-qt0-f182.google.com ([209.85.216.182]:39425 "EHLO mail-qt0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728113AbeIKW7V (ORCPT ); Tue, 11 Sep 2018 18:59:21 -0400 Received: by mail-qt0-f182.google.com with SMTP id o15-v6so29183780qtk.6 for ; Tue, 11 Sep 2018 10:58:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references; bh=LrKzlfx/zdpcpwsSlKOOkfj46VlO+ruQcMSazR0GoiU=; b=ym/JqzHjLmGfJnQGF1hEM6vYk713/sKNBhzAX58n8eqdNRH/3EcF2jhcfM0ywPJXkK wK5MJFDHgrEe1LHdkrpHSojpH4wnhwK1XgE74yQMUxV0nmC1D1b4LMgkXnOifTiXrqcK ZgjzyLpNbU57M4m78N2HK66ilzSf8DeAqw+fUSwZHxpqMv9trNL4f7McqWekA2K4+LNo u/Cnv+VteXd/u0ucIm5f1g+P2px/DOqDbXiistf0Pu2ZEKeKKDhftHfsnD5e9if3TR71 vPWfG3zcyUNFtorjTTMf7lJ5eWmI4Tab56mzD5qqUJpe4G2MLjmJYLUycApl6uYd3wml /Otw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=LrKzlfx/zdpcpwsSlKOOkfj46VlO+ruQcMSazR0GoiU=; b=KDJwh2haZkKotGbogt8ko1YzUUzFgicpL+Zkg4s6sNpwuKVuQgnVG94ajpjGopKwvE wvH00d72gjiXQZ8lpGwfBYP3IzDvd8p9F6KGkOZ1NZs6LM8KsKk0vBYK0XfYCJvHuH2Y V1RZ6d39q+S+slJG885h4KzA6E1P42z1ltIjJt32AFum/Zz99wt1UR5b7GNkDVS8cIT7 ceCX+NovbDVCYM5qiqwo5jOxZslArmVLVd+ViUcyarg9/+0Tkn4VxYycVZQz8hP/Irnn bm+M9Ck8GV+BXjAEoHXJ7/VhlyHsqjElSIADrnzFZu4BxJg56xOm5NLoHS3YJ9LauVll 9WzQ== X-Gm-Message-State: APzg51CDN+X9pQuQq7YQUVubmqAIWV31lCk0FGE5RrpMJ09apQoc1uBC BtGrssKO6fGmG//y7oYVps3CJA== X-Google-Smtp-Source: ANB0VdYdJITJnzu8ccmwRvd/z+ALRrSJDWztDjUZgcadQpLDebwFl3Qmu/CvWmQVM5kPGeczTt2lNw== X-Received: by 2002:a0c:818b:: with SMTP id 11-v6mr19758753qvd.129.1536688734783; Tue, 11 Sep 2018 10:58:54 -0700 (PDT) Received: from localhost ([107.15.81.208]) by smtp.gmail.com with ESMTPSA id m95-v6sm10557629qte.69.2018.09.11.10.58.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Sep 2018 10:58:53 -0700 (PDT) From: Josef Bacik To: kernel-team@fb.com, linux-btrfs@vger.kernel.org Subject: [PATCH 24/36] btrfs: assert on non-empty delayed iputs Date: Tue, 11 Sep 2018 13:57:55 -0400 Message-Id: <20180911175807.26181-25-josef@toxicpanda.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180911175807.26181-1-josef@toxicpanda.com> References: <20180911175807.26181-1-josef@toxicpanda.com> Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP I ran into an issue where there was some reference being held on an inode that I couldn't track. This assert wasn't triggered, but it at least rules out we're doing something stupid. Reviewed-by: Omar Sandoval Signed-off-by: Josef Bacik --- fs/btrfs/disk-io.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 0e42401756b8..11ea2ea7439e 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -3979,6 +3979,7 @@ void close_ctree(struct btrfs_fs_info *fs_info) kthread_stop(fs_info->transaction_kthread); kthread_stop(fs_info->cleaner_kthread); + ASSERT(list_empty(&fs_info->delayed_iputs)); set_bit(BTRFS_FS_CLOSING_DONE, &fs_info->flags); btrfs_free_qgroup_config(fs_info);