[1/2] ASoC: max9892x: Add documentation for reset-gpio support
diff mbox series

Message ID 20180912121955.33048-1-cychiang@chromium.org
State New
Headers show
Series
  • [1/2] ASoC: max9892x: Add documentation for reset-gpio support
Related show

Commit Message

Cheng-yi Chiang Sept. 12, 2018, 12:19 p.m. UTC
max98927 codec driver will support reset-gpio binding so it can toggle
reset line in its probe function.

Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org>
---
 Documentation/devicetree/bindings/sound/max9892x.txt | 3 +++
 1 file changed, 3 insertions(+)

Comments

Mark Brown Sept. 12, 2018, 12:28 p.m. UTC | #1
On Wed, Sep 12, 2018 at 08:19:54PM +0800, Cheng-Yi Chiang wrote:
> max98927 codec driver will support reset-gpio binding so it can toggle
> reset line in its probe function.

All GPIO properties are supposed to end -gpios even if there can only
ever be a single GPIO.
Cheng-yi Chiang Sept. 13, 2018, 4:25 a.m. UTC | #2
On Wed, Sep 12, 2018 at 8:28 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Wed, Sep 12, 2018 at 08:19:54PM +0800, Cheng-Yi Chiang wrote:
> > max98927 codec driver will support reset-gpio binding so it can toggle
> > reset line in its probe function.
>
> All GPIO properties are supposed to end -gpios even if there can only
> ever be a single GPIO.

Hi Mark. I see.
I will update this along with the comments of the change in max98927.c
if there is any.
Thanks!

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/sound/max9892x.txt b/Documentation/devicetree/bindings/sound/max9892x.txt
index f6171591ddc61..8bf30483eedcd 100644
--- a/Documentation/devicetree/bindings/sound/max9892x.txt
+++ b/Documentation/devicetree/bindings/sound/max9892x.txt
@@ -29,6 +29,8 @@  Required properties:
                    Range : 0 (off), 1 (on),  Default : 0
 
   - reg : the I2C address of the device for I2C
+  - reset-gpio: reset gpio the chip is connected to. This is supported
+                on max98927.
 
 Example:
 
@@ -38,4 +40,5 @@  codec: max98927@3a {
    imon-slot-no = <1>;
    interleave-mode = <0>;
    reg = <0x3a>;
+   reset-gpio = <&tlmm 75 GPIO_ACTIVE_LOW>;
 };