| Message ID | 20180917113559.11101-2-lkundrak@v3.sk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Make SPI work on DT MMP2 | expand |
On Mon, Sep 17, 2018 at 01:35:55PM +0200, Lubomir Rintel wrote: > This is the SPI controller found on Marvel MMP2 and perhaps more > platforms. I'm missing patches 2 and 5 from this series. What's going on with them, are there any dependencies? > Changes since v1: > - s/ssp@d4035000/spi@d4035000/ As covered in SubmittingPatches please put inter-version changelogs after the --- so they don't end up in the commits.
On Mon, 2018-09-17 at 10:57 -0700, Mark Brown wrote: > On Mon, Sep 17, 2018 at 01:35:55PM +0200, Lubomir Rintel wrote: > > This is the SPI controller found on Marvel MMP2 and perhaps more > > platforms. > > I'm missing patches 2 and 5 from this series. What's going on with > them, are there any dependencies? Sorry, I was not sure how to Cc people properly. I haven't dealt with a patchset that spanned multiple subsystems before. I thought it might have been a good idea to add individual people suggested by get_maintainer.pl in commits' "Cc:" tag, while passing the lists to --cc argument of git send-email. Should I've Cc'd everyone on the full series, even if only a patch or two might be really interesting to them? How do I decide whether the recipient needs to be in the commit's commit message (as opposed to just --cc on a command line)? https://lore.kernel.org/lkml/20180917113559.11101-1-lkundrak@v3.sk/ > > > Changes since v1: > > - s/ssp@d4035000/spi@d4035000/ > > As covered in SubmittingPatches please put inter-version changelogs > after the --- so they don't end up in the commits. Will do. I was actually not sure about that, so I took a short look at the git log, and it seemed to me that commit messages with the changelogs are quite common. Thanks you, Lubo
On Tue, Sep 18, 2018 at 02:15:12PM +0200, Lubomir Rintel wrote: > Should I've Cc'd everyone on the full series, even if only a patch or > two might be really interesting to them? How do I decide whether the It's a judgement call about who gets the patches but in general it's good to either do that or make sure that everyone sees the cover letter which explains what the whole series is. > recipient needs to be in the commit's commit message (as opposed to > just --cc on a command line)? Using CCs in the commit message is entirely optional TBH - a lot of people just don't do it at all, often when it is done it's a list of everyone who got the mail.
On Tue, Sep 18, 2018 at 02:15:12PM +0200, Lubomir Rintel wrote: > On Mon, 2018-09-17 at 10:57 -0700, Mark Brown wrote: > > > Changes since v1: > > > - s/ssp@d4035000/spi@d4035000/ > > As covered in SubmittingPatches please put inter-version changelogs > > after the --- so they don't end up in the commits. > Will do. I was actually not sure about that, so I took a short look at > the git log, and it seemed to me that commit messages with the > changelogs are quite common. For various reasons the drm subsystem explicitly does the opposite thing and it does leak out in other places (eg, when someone does it and then it doesn't get fixed up), it's a bit unfortunate that there's some divergence here.
diff --git a/Documentation/devicetree/bindings/spi/spi-pxa2xx.txt b/Documentation/devicetree/bindings/spi/spi-pxa2xx.txt new file mode 100644 index 000000000000..0335a9bd2e8a --- /dev/null +++ b/Documentation/devicetree/bindings/spi/spi-pxa2xx.txt @@ -0,0 +1,24 @@ +PXA2xx SSP SPI Controller + +Required properties: +- compatible: Must be "marvell,mmp2-ssp". +- reg: Offset and length of the device's register set. +- interrupts: Should be the interrupt number. +- clocks: Should contain a single entry describing the clock input. +- #address-cells: Number of cells required to define a chip select address. +- #size-cells: Should be zero. + +Optional properties: +- cs-gpios: list of GPIO chip selects. See the SPI bus bindings, + Documentation/devicetree/bindings/spi/spi-bus.txt + +Child nodes represent devices on the SPI bus + See ../spi/spi-bus.txt + +Example: + ssp1: spi@d4035000 { + compatible = "marvell,mmp2-ssp"; + reg = <0xd4035000 0x1000>; + clocks = <&soc_clocks MMP2_CLK_SSP0>; + interrupts = <0>; + };