From patchwork Thu Sep 20 12:05:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anilkumar Kolli X-Patchwork-Id: 10607557 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 85703913 for ; Thu, 20 Sep 2018 12:03:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 73B6B28C22 for ; Thu, 20 Sep 2018 12:03:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 67CA628C5C; Thu, 20 Sep 2018 12:03:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 194EF28C22 for ; Thu, 20 Sep 2018 12:03:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=fDCvuFUe/w9FWAfCEL2UmGmRPsAgc8hVZp/YUqn+m58=; b=lRSNTqXWc026XBtLZcrnJiyIte mbe9WuuLNrMV3uA21Vy7f90j1FEJus/jLhgGUl30hgdt+BGjpTcB65AtELkhyZ9WwVFLIpXIKnELQ d8fQ2fIkGsQi5GZdYQoWUiNPHWe+xLtU39Q5/K2ItYGOMHLtJN12TnI6lPV50q18FSRRL/Ea2fToe OoLLan7ecznOp6J7u+ZLCn+Mp7CbzJ/j+5+swbxQusqGm3bmedZvENbQO3ZYc8Jh1JqZXlcNh46ZL 4+11cGaOn0jY7zoRGvtULFBzqnOAe6NQV/9jQpwx0hGwSwKc4WUD7dVeZfaxpwGPLyiDip3s7tQax jmCm271g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1g2xfi-0006PJ-0y; Thu, 20 Sep 2018 12:03:02 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1g2xfd-0006OZ-UL for ath10k@lists.infradead.org; Thu, 20 Sep 2018 12:03:00 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id A1D10601A8; Thu, 20 Sep 2018 12:02:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1537444977; bh=cKgyMAASoM6uj48WwHGEaHj3GvxSUX473t6nO0oE5uo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cYyZpbVFFwwatBWwDRI6kClzF73ISnSqIWLHUoFZhRmNKNfZw/tK/aM+QF/v1EIBa Pk3tMj2h27z8aiGjXZqJ+VkROCKoYXOZZkv54WsEATuzKRbr1yaaoJ42/SnUCVqOGr x0HjcBqNOleMevsPd5Wh/HSlfzcH3VTLQnQFEu+M= Received: from localhost (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: akolli@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 95EB860818; Thu, 20 Sep 2018 12:02:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1537444977; bh=cKgyMAASoM6uj48WwHGEaHj3GvxSUX473t6nO0oE5uo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cYyZpbVFFwwatBWwDRI6kClzF73ISnSqIWLHUoFZhRmNKNfZw/tK/aM+QF/v1EIBa Pk3tMj2h27z8aiGjXZqJ+VkROCKoYXOZZkv54WsEATuzKRbr1yaaoJ42/SnUCVqOGr x0HjcBqNOleMevsPd5Wh/HSlfzcH3VTLQnQFEu+M= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 95EB860818 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=akolli@codeaurora.org From: Anilkumar Kolli To: ath10k@lists.infradead.org Subject: [RFCv3 1/2] mac80211: implement ieee80211_tx_rate_update to update rate Date: Thu, 20 Sep 2018 17:35:15 +0530 Message-Id: <1537445116-10780-2-git-send-email-akolli@codeaurora.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1537445116-10780-1-git-send-email-akolli@codeaurora.org> References: <1537445116-10780-1-git-send-email-akolli@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180920_050258_019443_0FC4C57E X-CRM114-Status: GOOD ( 10.21 ) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anilkumar Kolli , linux-wireless@vger.kernel.org MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Current mac80211 has provision to update tx status through ieee80211_tx_status() and ieee80211_tx_status_ext(). But drivers like ath10k updates the tx status from the skb except txrate, txrate will be updated from a different path, peer stats. Using ieee80211_tx_status_ext() in two different paths - (one for the stats, one for the tx rate) will duplicate the stats. To avoid this stats duplication, ieee80211_tx_rate_update() is implemented. Signed-off-by: Anilkumar Kolli --- V3: - Added new API in mac80211 to update tx rate(Johannes) include/net/mac80211.h | 14 ++++++++++++++ net/mac80211/status.c | 24 ++++++++++++++++++++++++ 2 files changed, 38 insertions(+) diff --git a/include/net/mac80211.h b/include/net/mac80211.h index 8c26d2d36cbe..042186a21770 100644 --- a/include/net/mac80211.h +++ b/include/net/mac80211.h @@ -4331,6 +4331,20 @@ void ieee80211_sta_set_expected_throughput(struct ieee80211_sta *pubsta, u32 thr); /** + * ieee80211_tx_rate_update - transmit rate update callback + * + * This function can be used in drivers that does not have provision + * in updating the tx rate in data path. + * + * @hw: the hardware the frame was transmitted by + * @status: tx status information + * @pubsta: the station to update the tx rate for. + */ +void ieee80211_tx_rate_update(struct ieee80211_hw *hw, + struct ieee80211_sta *pubsta, + struct ieee80211_tx_info *info); + +/** * ieee80211_tx_status - transmit status callback * * Call this function for all transmitted frames after they have been diff --git a/net/mac80211/status.c b/net/mac80211/status.c index 9a6d7208bf4f..232297ddaa02 100644 --- a/net/mac80211/status.c +++ b/net/mac80211/status.c @@ -988,6 +988,30 @@ void ieee80211_tx_status_ext(struct ieee80211_hw *hw, } EXPORT_SYMBOL(ieee80211_tx_status_ext); +void ieee80211_tx_rate_update(struct ieee80211_hw *hw, + struct ieee80211_sta *pubsta, + struct ieee80211_tx_info *info) +{ + struct ieee80211_local *local = hw_to_local(hw); + struct ieee80211_supported_band *sband; + struct sta_info *sta; + struct ieee80211_tx_status status; + + sband = hw->wiphy->bands[info->band]; + + if (pubsta) { + sta = container_of(pubsta, struct sta_info, sta); + status.skb = NULL; + status.info = info; + status.sta = pubsta; + + rate_control_tx_status(local, sband, &status); + if (ieee80211_hw_check(&local->hw, HAS_RATE_CONTROL)) + sta->tx_stats.last_rate = info->status.rates[0]; + } +} +EXPORT_SYMBOL(ieee80211_tx_rate_update); + void ieee80211_report_low_ack(struct ieee80211_sta *pubsta, u32 num_packets) { struct sta_info *sta = container_of(pubsta, struct sta_info, sta);