[v2] arm64: dts: renesas: r8a779{7|8}0: add TPU support
diff mbox series

Message ID 0d1a6380-e5f0-35a2-d421-f3c5bdd04a75@cogentembedded.com
State Superseded
Delegated to: Simon Horman
Headers show
Series
  • [v2] arm64: dts: renesas: r8a779{7|8}0: add TPU support
Related show

Commit Message

Sergei Shtylyov Sept. 22, 2018, 8:30 p.m. UTC
Describe TPU in the R8A779{7|8}0 device trees.

Based on the original (and large) patches by Vladimir Barinov.

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
This patch is against the 'renesas-devel-20180921-v4.19-rc4' branch of
Simon Horman's 'renesas.git' repo.

Changes in version 2:
- fixed up the size cells in the "regs" properties;
- fixed up the "#pwm-cells" properties;
- fixed up the R8A77980's "compatible" property.

 arch/arm64/boot/dts/renesas/r8a77970.dtsi |    8 ++++++++
 arch/arm64/boot/dts/renesas/r8a77980.dtsi |    9 +++++++++
 2 files changed, 17 insertions(+)

Comments

Simon Horman Sept. 24, 2018, 9:07 a.m. UTC | #1
On Sat, Sep 22, 2018 at 11:30:09PM +0300, Sergei Shtylyov wrote:
> Describe TPU in the R8A779{7|8}0 device trees.
> 
> Based on the original (and large) patches by Vladimir Barinov.
> 
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Thanks, this looks good but I'd like to see the binding update
before accepting this.

> 
> ---
> This patch is against the 'renesas-devel-20180921-v4.19-rc4' branch of
> Simon Horman's 'renesas.git' repo.
> 
> Changes in version 2:
> - fixed up the size cells in the "regs" properties;
> - fixed up the "#pwm-cells" properties;
> - fixed up the R8A77980's "compatible" property.
> 
>  arch/arm64/boot/dts/renesas/r8a77970.dtsi |    8 ++++++++
>  arch/arm64/boot/dts/renesas/r8a77980.dtsi |    9 +++++++++
>  2 files changed, 17 insertions(+)
> 
> Index: renesas/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> ===================================================================
> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> +++ renesas/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> @@ -614,6 +614,14 @@
>  			status = "disabled";
>  		};
>  
> +		tpu: pwm@e6e80000 {
> +			compatible = "renesas,tpu-r8a77970", "renesas,tpu";
> +			reg = <0 0xe6e80000 0 0x148>;
> +			clocks = <&cpg CPG_MOD 304>;
> +			power-domains = <&sysc R8A77970_PD_ALWAYS_ON>;
> +			#pwm-cells = <3>;
> +			status = "disabled";
> +		};
>  
>  		vin0: video@e6ef0000 {
>  			compatible = "renesas,vin-r8a77970";
> Index: renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> ===================================================================
> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> @@ -666,6 +666,15 @@
>  			status = "disabled";
>  		};
>  
> +		tpu: pwm@e6e80000 {
> +			compatible = "renesas,tpu-r8a77980", "renesas,tpu";
> +			reg = <0 0xe6e80000 0 0x148>;
> +			clocks = <&cpg CPG_MOD 304>;
> +			power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
> +			#pwm-cells = <3>;
> +			status = "disabled";
> +		};
> +
>  		vin0: video@e6ef0000 {
>  			compatible = "renesas,vin-r8a77980";
>  			reg = <0 0xe6ef0000 0 0x1000>;
>
Geert Uytterhoeven Sept. 24, 2018, 11:29 a.m. UTC | #2
On Sat, Sep 22, 2018 at 10:30 PM Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Describe TPU in the R8A779{7|8}0 device trees.
>
> Based on the original (and large) patches by Vladimir Barinov.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> +++ renesas/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> @@ -614,6 +614,14 @@
>                         status = "disabled";
>                 };
>
> +               tpu: pwm@e6e80000 {
> +                       compatible = "renesas,tpu-r8a77970", "renesas,tpu";
> +                       reg = <0 0xe6e80000 0 0x148>;
> +                       clocks = <&cpg CPG_MOD 304>;
> +                       power-domains = <&sysc R8A77970_PD_ALWAYS_ON>;
> +                       #pwm-cells = <3>;
> +                       status = "disabled";
> +               };

While not used by the driver, I think it would be good to describe its interrupt
(SPI 135). Same for r8a77980.dtsi.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Sergei Shtylyov Sept. 24, 2018, 2:44 p.m. UTC | #3
On 09/24/2018 12:07 PM, Simon Horman wrote:

>> Describe TPU in the R8A779{7|8}0 device trees.
>>
>> Based on the original (and large) patches by Vladimir Barinov.
>>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> Thanks, this looks good but I'd like to see the binding update
> before accepting this.

   See it merged, you mean? Because the binding updates have been posted before v2,
and I'm seeing them in patchwork...

MBR, Sergei
Simon Horman Sept. 24, 2018, 3:32 p.m. UTC | #4
On Mon, Sep 24, 2018 at 05:44:22PM +0300, Sergei Shtylyov wrote:
> On 09/24/2018 12:07 PM, Simon Horman wrote:
> 
> >> Describe TPU in the R8A779{7|8}0 device trees.
> >>
> >> Based on the original (and large) patches by Vladimir Barinov.
> >>
> >> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> > 
> > Thanks, this looks good but I'd like to see the binding update
> > before accepting this.
> 
>    See it merged, you mean? Because the binding updates have been posted
>    before v2, and I'm seeing them in patchwork...

See them Acked.

Somehow I couldn't find them this morning but I see them now.

Could you respond to Geert's comment on this patch regarding interrupts?
Sergei Shtylyov Sept. 24, 2018, 5:55 p.m. UTC | #5
On 09/24/2018 02:29 PM, Geert Uytterhoeven wrote:

>> Describe TPU in the R8A779{7|8}0 device trees.
>>
>> Based on the original (and large) patches by Vladimir Barinov.
>>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
>> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970.dtsi
>> +++ renesas/arch/arm64/boot/dts/renesas/r8a77970.dtsi
>> @@ -614,6 +614,14 @@
>>                         status = "disabled";
>>                 };
>>
>> +               tpu: pwm@e6e80000 {
>> +                       compatible = "renesas,tpu-r8a77970", "renesas,tpu";
>> +                       reg = <0 0xe6e80000 0 0x148>;
>> +                       clocks = <&cpg CPG_MOD 304>;
>> +                       power-domains = <&sysc R8A77970_PD_ALWAYS_ON>;
>> +                       #pwm-cells = <3>;
>> +                       status = "disabled";
>> +               };
> 
> While not used by the driver, I think it would be good to describe its interrupt
> (SPI 135). Same for r8a77980.dtsi.

   Gosh, you're right! Will re-spin. :-)

> Gr{oetje,eeting}s,
> 
>                         Geert

MBR, Sergei

Patch
diff mbox series

Index: renesas/arch/arm64/boot/dts/renesas/r8a77970.dtsi
===================================================================
--- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970.dtsi
+++ renesas/arch/arm64/boot/dts/renesas/r8a77970.dtsi
@@ -614,6 +614,14 @@ 
 			status = "disabled";
 		};
 
+		tpu: pwm@e6e80000 {
+			compatible = "renesas,tpu-r8a77970", "renesas,tpu";
+			reg = <0 0xe6e80000 0 0x148>;
+			clocks = <&cpg CPG_MOD 304>;
+			power-domains = <&sysc R8A77970_PD_ALWAYS_ON>;
+			#pwm-cells = <3>;
+			status = "disabled";
+		};
 
 		vin0: video@e6ef0000 {
 			compatible = "renesas,vin-r8a77970";
Index: renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
===================================================================
--- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
+++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
@@ -666,6 +666,15 @@ 
 			status = "disabled";
 		};
 
+		tpu: pwm@e6e80000 {
+			compatible = "renesas,tpu-r8a77980", "renesas,tpu";
+			reg = <0 0xe6e80000 0 0x148>;
+			clocks = <&cpg CPG_MOD 304>;
+			power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
+			#pwm-cells = <3>;
+			status = "disabled";
+		};
+
 		vin0: video@e6ef0000 {
 			compatible = "renesas,vin-r8a77980";
 			reg = <0 0xe6ef0000 0 0x1000>;