[2/2] MAINTAINERS: Remove myself as block maintainer
diff mbox series

Message ID 0e8a512d4c95094dc12f92390200c8e753c38248.1537848362.git.jcody@redhat.com
State New
Headers show
Series
  • Maintainership changes
Related show

Commit Message

Jeff Cody Sept. 25, 2018, 4:09 a.m. UTC
I'll not be involved in day-to-day qemu development.  Remove
myself as maintainer from the remainder of the network block drivers
(and vhdx), and revert them to the general block layer maintainership.

Signed-off-by: Jeff Cody <jcody@redhat.com>
---
 MAINTAINERS | 14 --------------
 1 file changed, 14 deletions(-)

Comments

Markus Armbruster Sept. 25, 2018, 5 a.m. UTC | #1
Jeff Cody <jcody@redhat.com> writes:

> I'll not be involved in day-to-day qemu development.  Remove
> myself as maintainer from the remainder of the network block drivers
> (and vhdx), and revert them to the general block layer maintainership.
>
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
>  MAINTAINERS | 14 --------------
>  1 file changed, 14 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e93f79672f..6ef6932628 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1982,28 +1982,22 @@ F: block/vmdk.c
>  
>  RBD
>  M: Josh Durgin <jdurgin@redhat.com>
> -M: Jeff Cody <jcody@redhat.com>
>  L: qemu-block@nongnu.org
>  S: Supported
>  F: block/rbd.c
> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>  
>  Sheepdog
>  M: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
>  M: Liu Yuan <namei.unix@gmail.com>
> -M: Jeff Cody <jcody@redhat.com>
>  L: qemu-block@nongnu.org
>  L: sheepdog@lists.wpkg.org
>  S: Supported
>  F: block/sheepdog.c
> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>  
>  VHDX
> -M: Jeff Cody <jcody@redhat.com>
>  L: qemu-block@nongnu.org
>  S: Supported
>  F: block/vhdx*
> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block

Does "S: Supported" make sense without an M:?

>  
>  VDI
>  M: Stefan Weil <sw@weilnetz.de>
> @@ -2034,34 +2028,26 @@ F: docs/interop/nbd.txt
>  T: git git://repo.or.cz/qemu/ericb.git nbd
>  
>  NFS
> -M: Jeff Cody <jcody@redhat.com>
>  M: Peter Lieven <pl@kamp.de>
>  L: qemu-block@nongnu.org
>  S: Maintained
>  F: block/nfs.c
> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>  
>  SSH
>  M: Richard W.M. Jones <rjones@redhat.com>
> -M: Jeff Cody <jcody@redhat.com>
>  L: qemu-block@nongnu.org
>  S: Supported
>  F: block/ssh.c
> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>  
>  CURL
> -M: Jeff Cody <jcody@redhat.com>
>  L: qemu-block@nongnu.org
>  S: Supported
>  F: block/curl.c
> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block

Likewise.

>  GLUSTER
> -M: Jeff Cody <jcody@redhat.com>
>  L: qemu-block@nongnu.org
>  S: Supported
>  F: block/gluster.c
> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block

Likewise.

>  Null Block Driver
>  M: Fam Zheng <famz@redhat.com>
Fam Zheng Sept. 25, 2018, 5:32 a.m. UTC | #2
On Tue, 09/25 07:00, Markus Armbruster wrote:
> Jeff Cody <jcody@redhat.com> writes:
> 
> > I'll not be involved in day-to-day qemu development.  Remove
> > myself as maintainer from the remainder of the network block drivers
> > (and vhdx), and revert them to the general block layer maintainership.
> >
> > Signed-off-by: Jeff Cody <jcody@redhat.com>
> > ---
> >  MAINTAINERS | 14 --------------
> >  1 file changed, 14 deletions(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index e93f79672f..6ef6932628 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1982,28 +1982,22 @@ F: block/vmdk.c
> >  
> >  RBD
> >  M: Josh Durgin <jdurgin@redhat.com>
> > -M: Jeff Cody <jcody@redhat.com>
> >  L: qemu-block@nongnu.org
> >  S: Supported
> >  F: block/rbd.c
> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> >  
> >  Sheepdog
> >  M: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
> >  M: Liu Yuan <namei.unix@gmail.com>
> > -M: Jeff Cody <jcody@redhat.com>
> >  L: qemu-block@nongnu.org
> >  L: sheepdog@lists.wpkg.org
> >  S: Supported
> >  F: block/sheepdog.c
> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> >  
> >  VHDX
> > -M: Jeff Cody <jcody@redhat.com>
> >  L: qemu-block@nongnu.org
> >  S: Supported
> >  F: block/vhdx*
> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> 
> Does "S: Supported" make sense without an M:?
> 
> >  
> >  VDI
> >  M: Stefan Weil <sw@weilnetz.de>
> > @@ -2034,34 +2028,26 @@ F: docs/interop/nbd.txt
> >  T: git git://repo.or.cz/qemu/ericb.git nbd
> >  
> >  NFS
> > -M: Jeff Cody <jcody@redhat.com>
> >  M: Peter Lieven <pl@kamp.de>
> >  L: qemu-block@nongnu.org
> >  S: Maintained
> >  F: block/nfs.c
> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> >  
> >  SSH
> >  M: Richard W.M. Jones <rjones@redhat.com>
> > -M: Jeff Cody <jcody@redhat.com>
> >  L: qemu-block@nongnu.org
> >  S: Supported
> >  F: block/ssh.c
> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> >  
> >  CURL
> > -M: Jeff Cody <jcody@redhat.com>
> >  L: qemu-block@nongnu.org
> >  S: Supported
> >  F: block/curl.c
> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> 
> Likewise.
> 
> >  GLUSTER
> > -M: Jeff Cody <jcody@redhat.com>
> >  L: qemu-block@nongnu.org
> >  S: Supported
> >  F: block/gluster.c
> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> 
> Likewise.
> 
> >  Null Block Driver
> >  M: Fam Zheng <famz@redhat.com>
> 

Block drivers without an M: naturally fall under the overall maintainership of
block layer (Kevin&Max), so IMO keeping the statuses is fine. Maybe CURL can be
degraded to Maintained, though.

Fam
Niels de Vos Sept. 25, 2018, 7:17 a.m. UTC | #3
On Tue, Sep 25, 2018 at 01:32:04PM +0800, Fam Zheng wrote:
> On Tue, 09/25 07:00, Markus Armbruster wrote:
> > Jeff Cody <jcody@redhat.com> writes:
> > 
> > > I'll not be involved in day-to-day qemu development.  Remove
> > > myself as maintainer from the remainder of the network block drivers
> > > (and vhdx), and revert them to the general block layer maintainership.
> > >
> > > Signed-off-by: Jeff Cody <jcody@redhat.com>
> > > ---
> > >  MAINTAINERS | 14 --------------
> > >  1 file changed, 14 deletions(-)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index e93f79672f..6ef6932628 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -1982,28 +1982,22 @@ F: block/vmdk.c
> > >  
> > >  RBD
> > >  M: Josh Durgin <jdurgin@redhat.com>
> > > -M: Jeff Cody <jcody@redhat.com>
> > >  L: qemu-block@nongnu.org
> > >  S: Supported
> > >  F: block/rbd.c
> > > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> > >  
> > >  Sheepdog
> > >  M: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
> > >  M: Liu Yuan <namei.unix@gmail.com>
> > > -M: Jeff Cody <jcody@redhat.com>
> > >  L: qemu-block@nongnu.org
> > >  L: sheepdog@lists.wpkg.org
> > >  S: Supported
> > >  F: block/sheepdog.c
> > > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> > >  
> > >  VHDX
> > > -M: Jeff Cody <jcody@redhat.com>
> > >  L: qemu-block@nongnu.org
> > >  S: Supported
> > >  F: block/vhdx*
> > > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> > 
> > Does "S: Supported" make sense without an M:?
> > 
> > >  
> > >  VDI
> > >  M: Stefan Weil <sw@weilnetz.de>
> > > @@ -2034,34 +2028,26 @@ F: docs/interop/nbd.txt
> > >  T: git git://repo.or.cz/qemu/ericb.git nbd
> > >  
> > >  NFS
> > > -M: Jeff Cody <jcody@redhat.com>
> > >  M: Peter Lieven <pl@kamp.de>
> > >  L: qemu-block@nongnu.org
> > >  S: Maintained
> > >  F: block/nfs.c
> > > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> > >  
> > >  SSH
> > >  M: Richard W.M. Jones <rjones@redhat.com>
> > > -M: Jeff Cody <jcody@redhat.com>
> > >  L: qemu-block@nongnu.org
> > >  S: Supported
> > >  F: block/ssh.c
> > > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> > >  
> > >  CURL
> > > -M: Jeff Cody <jcody@redhat.com>
> > >  L: qemu-block@nongnu.org
> > >  S: Supported
> > >  F: block/curl.c
> > > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> > 
> > Likewise.
> > 
> > >  GLUSTER
> > > -M: Jeff Cody <jcody@redhat.com>
> > >  L: qemu-block@nongnu.org
> > >  S: Supported
> > >  F: block/gluster.c
> > > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> > 
> > Likewise.
> > 
> > >  Null Block Driver
> > >  M: Fam Zheng <famz@redhat.com>
> > 
> 
> Block drivers without an M: naturally fall under the overall maintainership of
> block layer (Kevin&Max), so IMO keeping the statuses is fine. Maybe CURL can be
> degraded to Maintained, though.

For Gluster you can count on continued support from several developers
on the Gluster side when needed. I do not think we are (pro-)active
enough to claim maintainership of the driver.

Thanks,
Niels (one of the GlusterFS maintainers)
Markus Armbruster Sept. 25, 2018, 7:37 a.m. UTC | #4
Fam Zheng <famz@redhat.com> writes:

> On Tue, 09/25 07:00, Markus Armbruster wrote:
>> Jeff Cody <jcody@redhat.com> writes:
>> 
>> > I'll not be involved in day-to-day qemu development.  Remove
>> > myself as maintainer from the remainder of the network block drivers
>> > (and vhdx), and revert them to the general block layer maintainership.
>> >
>> > Signed-off-by: Jeff Cody <jcody@redhat.com>
>> > ---
>> >  MAINTAINERS | 14 --------------
>> >  1 file changed, 14 deletions(-)
>> >
>> > diff --git a/MAINTAINERS b/MAINTAINERS
>> > index e93f79672f..6ef6932628 100644
>> > --- a/MAINTAINERS
>> > +++ b/MAINTAINERS
>> > @@ -1982,28 +1982,22 @@ F: block/vmdk.c
>> >  
>> >  RBD
>> >  M: Josh Durgin <jdurgin@redhat.com>
>> > -M: Jeff Cody <jcody@redhat.com>
>> >  L: qemu-block@nongnu.org
>> >  S: Supported
>> >  F: block/rbd.c
>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>> >  
>> >  Sheepdog
>> >  M: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
>> >  M: Liu Yuan <namei.unix@gmail.com>
>> > -M: Jeff Cody <jcody@redhat.com>
>> >  L: qemu-block@nongnu.org
>> >  L: sheepdog@lists.wpkg.org
>> >  S: Supported
>> >  F: block/sheepdog.c
>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>> >  
>> >  VHDX
>> > -M: Jeff Cody <jcody@redhat.com>
>> >  L: qemu-block@nongnu.org
>> >  S: Supported
>> >  F: block/vhdx*
>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>> 
>> Does "S: Supported" make sense without an M:?
>> 
>> >  
>> >  VDI
>> >  M: Stefan Weil <sw@weilnetz.de>
>> > @@ -2034,34 +2028,26 @@ F: docs/interop/nbd.txt
>> >  T: git git://repo.or.cz/qemu/ericb.git nbd
>> >  
>> >  NFS
>> > -M: Jeff Cody <jcody@redhat.com>
>> >  M: Peter Lieven <pl@kamp.de>
>> >  L: qemu-block@nongnu.org
>> >  S: Maintained
>> >  F: block/nfs.c
>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>> >  
>> >  SSH
>> >  M: Richard W.M. Jones <rjones@redhat.com>
>> > -M: Jeff Cody <jcody@redhat.com>
>> >  L: qemu-block@nongnu.org
>> >  S: Supported
>> >  F: block/ssh.c
>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>> >  
>> >  CURL
>> > -M: Jeff Cody <jcody@redhat.com>
>> >  L: qemu-block@nongnu.org
>> >  S: Supported
>> >  F: block/curl.c
>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>> 
>> Likewise.
>> 
>> >  GLUSTER
>> > -M: Jeff Cody <jcody@redhat.com>
>> >  L: qemu-block@nongnu.org
>> >  S: Supported
>> >  F: block/gluster.c
>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>> 
>> Likewise.
>> 
>> >  Null Block Driver
>> >  M: Fam Zheng <famz@redhat.com>
>> 
>
> Block drivers without an M: naturally fall under the overall maintainership of
> block layer (Kevin&Max), so IMO keeping the statuses is fine. Maybe CURL can be
> degraded to Maintained, though.

Yes, get_maintainer.pl combines all applicable sections.  Human readers
are left to wonder, unless they know to look for other matches.

Do we want to have a dedicated network block driver submaintainer again,
if we can find one?

Do we want to have a dedicated VHDX driver submaintainer again?  Fam,
you're maintaining VMDK, could you cover VHDX as well?
Fam Zheng Sept. 25, 2018, 7:49 a.m. UTC | #5
On Tue, 09/25 09:37, Markus Armbruster wrote:
> Do we want to have a dedicated VHDX driver submaintainer again?  Fam,
> you're maintaining VMDK, could you cover VHDX as well?

I don't know a lot VHDX internals. Considering my capacity at the moment I'd
rather not take this one.

Fam
Jeff Cody Sept. 26, 2018, 5:42 p.m. UTC | #6
On Tue, Sep 25, 2018 at 03:49:36PM +0800, Fam Zheng wrote:
> On Tue, 09/25 09:37, Markus Armbruster wrote:
> > Do we want to have a dedicated VHDX driver submaintainer again?  Fam,
> > you're maintaining VMDK, could you cover VHDX as well?
> 
> I don't know a lot VHDX internals. Considering my capacity at the moment I'd
> rather not take this one.
> 
> Fam

Anyone can feel free to email me at codyprime@gmail.com with any VHDX
questions (I am subbed to the qemu mailing list there as well).  I'll at
least do my best to answer :)
Markus Armbruster Jan. 8, 2019, 5:18 p.m. UTC | #7
This patch series got stuck.

Markus Armbruster <armbru@redhat.com> writes:

> Fam Zheng <famz@redhat.com> writes:
>
>> On Tue, 09/25 07:00, Markus Armbruster wrote:
>>> Jeff Cody <jcody@redhat.com> writes:
>>> 
>>> > I'll not be involved in day-to-day qemu development.  Remove
>>> > myself as maintainer from the remainder of the network block drivers
>>> > (and vhdx), and revert them to the general block layer maintainership.
>>> >
>>> > Signed-off-by: Jeff Cody <jcody@redhat.com>
>>> > ---
>>> >  MAINTAINERS | 14 --------------
>>> >  1 file changed, 14 deletions(-)
>>> >
>>> > diff --git a/MAINTAINERS b/MAINTAINERS
>>> > index e93f79672f..6ef6932628 100644
>>> > --- a/MAINTAINERS
>>> > +++ b/MAINTAINERS
>>> > @@ -1982,28 +1982,22 @@ F: block/vmdk.c
>>> >  
>>> >  RBD
>>> >  M: Josh Durgin <jdurgin@redhat.com>
>>> > -M: Jeff Cody <jcody@redhat.com>
>>> >  L: qemu-block@nongnu.org
>>> >  S: Supported
>>> >  F: block/rbd.c
>>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>> >  
>>> >  Sheepdog
>>> >  M: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
>>> >  M: Liu Yuan <namei.unix@gmail.com>
>>> > -M: Jeff Cody <jcody@redhat.com>
>>> >  L: qemu-block@nongnu.org
>>> >  L: sheepdog@lists.wpkg.org
>>> >  S: Supported
>>> >  F: block/sheepdog.c
>>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>> >  
>>> >  VHDX
>>> > -M: Jeff Cody <jcody@redhat.com>
>>> >  L: qemu-block@nongnu.org
>>> >  S: Supported
>>> >  F: block/vhdx*
>>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>> 
>>> Does "S: Supported" make sense without an M:?
>>> 
>>> >  
>>> >  VDI
>>> >  M: Stefan Weil <sw@weilnetz.de>
>>> > @@ -2034,34 +2028,26 @@ F: docs/interop/nbd.txt
>>> >  T: git git://repo.or.cz/qemu/ericb.git nbd
>>> >  
>>> >  NFS
>>> > -M: Jeff Cody <jcody@redhat.com>
>>> >  M: Peter Lieven <pl@kamp.de>
>>> >  L: qemu-block@nongnu.org
>>> >  S: Maintained
>>> >  F: block/nfs.c
>>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>> >  
>>> >  SSH
>>> >  M: Richard W.M. Jones <rjones@redhat.com>
>>> > -M: Jeff Cody <jcody@redhat.com>
>>> >  L: qemu-block@nongnu.org
>>> >  S: Supported
>>> >  F: block/ssh.c
>>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>> >  
>>> >  CURL
>>> > -M: Jeff Cody <jcody@redhat.com>
>>> >  L: qemu-block@nongnu.org
>>> >  S: Supported
>>> >  F: block/curl.c
>>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>> 
>>> Likewise.
>>> 
>>> >  GLUSTER
>>> > -M: Jeff Cody <jcody@redhat.com>
>>> >  L: qemu-block@nongnu.org
>>> >  S: Supported
>>> >  F: block/gluster.c
>>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>> 
>>> Likewise.
>>> 
>>> >  Null Block Driver
>>> >  M: Fam Zheng <famz@redhat.com>
>>> 
>>
>> Block drivers without an M: naturally fall under the overall maintainership of
>> block layer (Kevin&Max), so IMO keeping the statuses is fine. Maybe CURL can be
>> degraded to Maintained, though.
>
> Yes, get_maintainer.pl combines all applicable sections.  Human readers
> are left to wonder, unless they know to look for other matches.
>
> Do we want to have a dedicated network block driver submaintainer again,
> if we can find one?
>
> Do we want to have a dedicated VHDX driver submaintainer again?  Fam,
> you're maintaining VMDK, could you cover VHDX as well?

Fam can't.

I can see two sane options for the three sections that lose their sole
maintainer (VHDX, CURL, GLUSTER):

* Downgrade to S: Orphan

  This reflects the fact that we'd like to have dedicated maintainers
  for them.  It camouflages the fact that the "Block layer core"
  maintainers pick up the slack.

* Delete

  The opposite.

Kevin, Max, please pick your poison, or suggest one you find tastier.
Kevin Wolf Jan. 8, 2019, 7:12 p.m. UTC | #8
Am 08.01.2019 um 18:18 hat Markus Armbruster geschrieben:
> This patch series got stuck.
> 
> Markus Armbruster <armbru@redhat.com> writes:
> 
> > Fam Zheng <famz@redhat.com> writes:
> >
> >> On Tue, 09/25 07:00, Markus Armbruster wrote:
> >>> Jeff Cody <jcody@redhat.com> writes:
> >>> 
> >>> > I'll not be involved in day-to-day qemu development.  Remove
> >>> > myself as maintainer from the remainder of the network block drivers
> >>> > (and vhdx), and revert them to the general block layer maintainership.
> >>> >
> >>> > Signed-off-by: Jeff Cody <jcody@redhat.com>
> >>> > ---
> >>> >  MAINTAINERS | 14 --------------
> >>> >  1 file changed, 14 deletions(-)
> >>> >
> >>> > diff --git a/MAINTAINERS b/MAINTAINERS
> >>> > index e93f79672f..6ef6932628 100644
> >>> > --- a/MAINTAINERS
> >>> > +++ b/MAINTAINERS
> >>> > @@ -1982,28 +1982,22 @@ F: block/vmdk.c
> >>> >  
> >>> >  RBD
> >>> >  M: Josh Durgin <jdurgin@redhat.com>
> >>> > -M: Jeff Cody <jcody@redhat.com>
> >>> >  L: qemu-block@nongnu.org
> >>> >  S: Supported
> >>> >  F: block/rbd.c
> >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> >>> >  
> >>> >  Sheepdog
> >>> >  M: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
> >>> >  M: Liu Yuan <namei.unix@gmail.com>
> >>> > -M: Jeff Cody <jcody@redhat.com>
> >>> >  L: qemu-block@nongnu.org
> >>> >  L: sheepdog@lists.wpkg.org
> >>> >  S: Supported
> >>> >  F: block/sheepdog.c
> >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> >>> >  
> >>> >  VHDX
> >>> > -M: Jeff Cody <jcody@redhat.com>
> >>> >  L: qemu-block@nongnu.org
> >>> >  S: Supported
> >>> >  F: block/vhdx*
> >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> >>> 
> >>> Does "S: Supported" make sense without an M:?
> >>> 
> >>> >  
> >>> >  VDI
> >>> >  M: Stefan Weil <sw@weilnetz.de>
> >>> > @@ -2034,34 +2028,26 @@ F: docs/interop/nbd.txt
> >>> >  T: git git://repo.or.cz/qemu/ericb.git nbd
> >>> >  
> >>> >  NFS
> >>> > -M: Jeff Cody <jcody@redhat.com>
> >>> >  M: Peter Lieven <pl@kamp.de>
> >>> >  L: qemu-block@nongnu.org
> >>> >  S: Maintained
> >>> >  F: block/nfs.c
> >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> >>> >  
> >>> >  SSH
> >>> >  M: Richard W.M. Jones <rjones@redhat.com>
> >>> > -M: Jeff Cody <jcody@redhat.com>
> >>> >  L: qemu-block@nongnu.org
> >>> >  S: Supported
> >>> >  F: block/ssh.c
> >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> >>> >  
> >>> >  CURL
> >>> > -M: Jeff Cody <jcody@redhat.com>
> >>> >  L: qemu-block@nongnu.org
> >>> >  S: Supported
> >>> >  F: block/curl.c
> >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> >>> 
> >>> Likewise.
> >>> 
> >>> >  GLUSTER
> >>> > -M: Jeff Cody <jcody@redhat.com>
> >>> >  L: qemu-block@nongnu.org
> >>> >  S: Supported
> >>> >  F: block/gluster.c
> >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> >>> 
> >>> Likewise.
> >>> 
> >>> >  Null Block Driver
> >>> >  M: Fam Zheng <famz@redhat.com>
> >>> 
> >>
> >> Block drivers without an M: naturally fall under the overall maintainership of
> >> block layer (Kevin&Max), so IMO keeping the statuses is fine. Maybe CURL can be
> >> degraded to Maintained, though.
> >
> > Yes, get_maintainer.pl combines all applicable sections.  Human readers
> > are left to wonder, unless they know to look for other matches.
> >
> > Do we want to have a dedicated network block driver submaintainer again,
> > if we can find one?
> >
> > Do we want to have a dedicated VHDX driver submaintainer again?  Fam,
> > you're maintaining VMDK, could you cover VHDX as well?
> 
> Fam can't.
> 
> I can see two sane options for the three sections that lose their sole
> maintainer (VHDX, CURL, GLUSTER):
> 
> * Downgrade to S: Orphan
> 
>   This reflects the fact that we'd like to have dedicated maintainers
>   for them.  It camouflages the fact that the "Block layer core"
>   maintainers pick up the slack.
> 
> * Delete
> 
>   The opposite.
> 
> Kevin, Max, please pick your poison, or suggest one you find tastier.

Orphan is probably by far closer to the truth than Supported. But I
think what we really do is Odd Fixes. Not sure if that's a status that
works in any meaningful way without having a maintainer for the specific
thing assigned?

Kevin
Thomas Huth Jan. 9, 2019, 10:15 a.m. UTC | #9
On 2019-01-08 20:12, Kevin Wolf wrote:
> Am 08.01.2019 um 18:18 hat Markus Armbruster geschrieben:
>> This patch series got stuck.
>>
>> Markus Armbruster <armbru@redhat.com> writes:
>>
>>> Fam Zheng <famz@redhat.com> writes:
>>>
>>>> On Tue, 09/25 07:00, Markus Armbruster wrote:
>>>>> Jeff Cody <jcody@redhat.com> writes:
>>>>>
>>>>>> I'll not be involved in day-to-day qemu development.  Remove
>>>>>> myself as maintainer from the remainder of the network block drivers
>>>>>> (and vhdx), and revert them to the general block layer maintainership.
>>>>>>
>>>>>> Signed-off-by: Jeff Cody <jcody@redhat.com>
>>>>>> ---
>>>>>>  MAINTAINERS | 14 --------------
>>>>>>  1 file changed, 14 deletions(-)
>>>>>>
>>>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>>>> index e93f79672f..6ef6932628 100644
>>>>>> --- a/MAINTAINERS
>>>>>> +++ b/MAINTAINERS
>>>>>> @@ -1982,28 +1982,22 @@ F: block/vmdk.c
>>>>>>  
>>>>>>  RBD
>>>>>>  M: Josh Durgin <jdurgin@redhat.com>
>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>>  L: qemu-block@nongnu.org
>>>>>>  S: Supported
>>>>>>  F: block/rbd.c
>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>>  
>>>>>>  Sheepdog
>>>>>>  M: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
>>>>>>  M: Liu Yuan <namei.unix@gmail.com>
>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>>  L: qemu-block@nongnu.org
>>>>>>  L: sheepdog@lists.wpkg.org
>>>>>>  S: Supported
>>>>>>  F: block/sheepdog.c
>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>>  
>>>>>>  VHDX
>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>>  L: qemu-block@nongnu.org
>>>>>>  S: Supported
>>>>>>  F: block/vhdx*
>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>
>>>>> Does "S: Supported" make sense without an M:?
>>>>>
>>>>>>  
>>>>>>  VDI
>>>>>>  M: Stefan Weil <sw@weilnetz.de>
>>>>>> @@ -2034,34 +2028,26 @@ F: docs/interop/nbd.txt
>>>>>>  T: git git://repo.or.cz/qemu/ericb.git nbd
>>>>>>  
>>>>>>  NFS
>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>>  M: Peter Lieven <pl@kamp.de>
>>>>>>  L: qemu-block@nongnu.org
>>>>>>  S: Maintained
>>>>>>  F: block/nfs.c
>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>>  
>>>>>>  SSH
>>>>>>  M: Richard W.M. Jones <rjones@redhat.com>
>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>>  L: qemu-block@nongnu.org
>>>>>>  S: Supported
>>>>>>  F: block/ssh.c
>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>>  
>>>>>>  CURL
>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>>  L: qemu-block@nongnu.org
>>>>>>  S: Supported
>>>>>>  F: block/curl.c
>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>
>>>>> Likewise.
>>>>>
>>>>>>  GLUSTER
>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>>  L: qemu-block@nongnu.org
>>>>>>  S: Supported
>>>>>>  F: block/gluster.c
>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>
>>>>> Likewise.
>>>>>
>>>>>>  Null Block Driver
>>>>>>  M: Fam Zheng <famz@redhat.com>
>>>>>
>>>>
>>>> Block drivers without an M: naturally fall under the overall maintainership of
>>>> block layer (Kevin&Max), so IMO keeping the statuses is fine. Maybe CURL can be
>>>> degraded to Maintained, though.
>>>
>>> Yes, get_maintainer.pl combines all applicable sections.  Human readers
>>> are left to wonder, unless they know to look for other matches.
>>>
>>> Do we want to have a dedicated network block driver submaintainer again,
>>> if we can find one?
>>>
>>> Do we want to have a dedicated VHDX driver submaintainer again?  Fam,
>>> you're maintaining VMDK, could you cover VHDX as well?
>>
>> Fam can't.
>>
>> I can see two sane options for the three sections that lose their sole
>> maintainer (VHDX, CURL, GLUSTER):
>>
>> * Downgrade to S: Orphan
>>
>>   This reflects the fact that we'd like to have dedicated maintainers
>>   for them.  It camouflages the fact that the "Block layer core"
>>   maintainers pick up the slack.
>>
>> * Delete
>>
>>   The opposite.
>>
>> Kevin, Max, please pick your poison, or suggest one you find tastier.
> 
> Orphan is probably by far closer to the truth than Supported. But I
> think what we really do is Odd Fixes. Not sure if that's a status that
> works in any meaningful way without having a maintainer for the specific
> thing assigned?

IMHO "Odd Fixes" is still ok for entries that have at least a "L:" line,
like "L: qemu-block@nongnu.org". If an entry neither got a "M:" nor a
"L:" line anymore, it should be marked with "Orphan" instead.

 Thomas
Niels de Vos Jan. 9, 2019, 11:43 a.m. UTC | #10
On Tue, Jan 08, 2019 at 08:12:16PM +0100, Kevin Wolf wrote:
> Am 08.01.2019 um 18:18 hat Markus Armbruster geschrieben:
> > This patch series got stuck.
> > 
> > Markus Armbruster <armbru@redhat.com> writes:
> > 
> > > Fam Zheng <famz@redhat.com> writes:
> > >
> > >> On Tue, 09/25 07:00, Markus Armbruster wrote:
> > >>> Jeff Cody <jcody@redhat.com> writes:
> > >>> 
> > >>> > I'll not be involved in day-to-day qemu development.  Remove
> > >>> > myself as maintainer from the remainder of the network block drivers
> > >>> > (and vhdx), and revert them to the general block layer maintainership.
> > >>> >
> > >>> > Signed-off-by: Jeff Cody <jcody@redhat.com>
> > >>> > ---
> > >>> >  MAINTAINERS | 14 --------------
> > >>> >  1 file changed, 14 deletions(-)
> > >>> >
> > >>> > diff --git a/MAINTAINERS b/MAINTAINERS
> > >>> > index e93f79672f..6ef6932628 100644
> > >>> > --- a/MAINTAINERS
> > >>> > +++ b/MAINTAINERS
> > >>> > @@ -1982,28 +1982,22 @@ F: block/vmdk.c
> > >>> >  
> > >>> >  RBD
> > >>> >  M: Josh Durgin <jdurgin@redhat.com>
> > >>> > -M: Jeff Cody <jcody@redhat.com>
> > >>> >  L: qemu-block@nongnu.org
> > >>> >  S: Supported
> > >>> >  F: block/rbd.c
> > >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> > >>> >  
> > >>> >  Sheepdog
> > >>> >  M: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
> > >>> >  M: Liu Yuan <namei.unix@gmail.com>
> > >>> > -M: Jeff Cody <jcody@redhat.com>
> > >>> >  L: qemu-block@nongnu.org
> > >>> >  L: sheepdog@lists.wpkg.org
> > >>> >  S: Supported
> > >>> >  F: block/sheepdog.c
> > >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> > >>> >  
> > >>> >  VHDX
> > >>> > -M: Jeff Cody <jcody@redhat.com>
> > >>> >  L: qemu-block@nongnu.org
> > >>> >  S: Supported
> > >>> >  F: block/vhdx*
> > >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> > >>> 
> > >>> Does "S: Supported" make sense without an M:?
> > >>> 
> > >>> >  
> > >>> >  VDI
> > >>> >  M: Stefan Weil <sw@weilnetz.de>
> > >>> > @@ -2034,34 +2028,26 @@ F: docs/interop/nbd.txt
> > >>> >  T: git git://repo.or.cz/qemu/ericb.git nbd
> > >>> >  
> > >>> >  NFS
> > >>> > -M: Jeff Cody <jcody@redhat.com>
> > >>> >  M: Peter Lieven <pl@kamp.de>
> > >>> >  L: qemu-block@nongnu.org
> > >>> >  S: Maintained
> > >>> >  F: block/nfs.c
> > >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> > >>> >  
> > >>> >  SSH
> > >>> >  M: Richard W.M. Jones <rjones@redhat.com>
> > >>> > -M: Jeff Cody <jcody@redhat.com>
> > >>> >  L: qemu-block@nongnu.org
> > >>> >  S: Supported
> > >>> >  F: block/ssh.c
> > >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> > >>> >  
> > >>> >  CURL
> > >>> > -M: Jeff Cody <jcody@redhat.com>
> > >>> >  L: qemu-block@nongnu.org
> > >>> >  S: Supported
> > >>> >  F: block/curl.c
> > >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> > >>> 
> > >>> Likewise.
> > >>> 
> > >>> >  GLUSTER
> > >>> > -M: Jeff Cody <jcody@redhat.com>
> > >>> >  L: qemu-block@nongnu.org
> > >>> >  S: Supported
> > >>> >  F: block/gluster.c
> > >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> > >>> 
> > >>> Likewise.
> > >>> 
> > >>> >  Null Block Driver
> > >>> >  M: Fam Zheng <famz@redhat.com>
> > >>> 
> > >>
> > >> Block drivers without an M: naturally fall under the overall maintainership of
> > >> block layer (Kevin&Max), so IMO keeping the statuses is fine. Maybe CURL can be
> > >> degraded to Maintained, though.
> > >
> > > Yes, get_maintainer.pl combines all applicable sections.  Human readers
> > > are left to wonder, unless they know to look for other matches.
> > >
> > > Do we want to have a dedicated network block driver submaintainer again,
> > > if we can find one?
> > >
> > > Do we want to have a dedicated VHDX driver submaintainer again?  Fam,
> > > you're maintaining VMDK, could you cover VHDX as well?
> > 
> > Fam can't.
> > 
> > I can see two sane options for the three sections that lose their sole
> > maintainer (VHDX, CURL, GLUSTER):
> > 
> > * Downgrade to S: Orphan
> > 
> >   This reflects the fact that we'd like to have dedicated maintainers
> >   for them.  It camouflages the fact that the "Block layer core"
> >   maintainers pick up the slack.
> > 
> > * Delete
> > 
> >   The opposite.
> > 
> > Kevin, Max, please pick your poison, or suggest one you find tastier.
> 
> Orphan is probably by far closer to the truth than Supported. But I
> think what we really do is Odd Fixes. Not sure if that's a status that
> works in any meaningful way without having a maintainer for the specific
> thing assigned?

For Gluster we are interested in keeping it maintained in some form. At
least integration@gluster.org could be added as a list. I am not sure
there is anyone working on Gluster that would fit for a maintainer of
the driver. If you really want to put a name there, I can function as a
'maintainer' and pull in other Gluster developers in case I am otherwise
occupied.

Niels
Markus Armbruster Jan. 9, 2019, 12:39 p.m. UTC | #11
Thomas Huth <thuth@redhat.com> writes:

> On 2019-01-08 20:12, Kevin Wolf wrote:
>> Am 08.01.2019 um 18:18 hat Markus Armbruster geschrieben:
>>> This patch series got stuck.
>>>
>>> Markus Armbruster <armbru@redhat.com> writes:
>>>
>>>> Fam Zheng <famz@redhat.com> writes:
>>>>
>>>>> On Tue, 09/25 07:00, Markus Armbruster wrote:
>>>>>> Jeff Cody <jcody@redhat.com> writes:
>>>>>>
>>>>>>> I'll not be involved in day-to-day qemu development.  Remove
>>>>>>> myself as maintainer from the remainder of the network block drivers
>>>>>>> (and vhdx), and revert them to the general block layer maintainership.
>>>>>>>
>>>>>>> Signed-off-by: Jeff Cody <jcody@redhat.com>
>>>>>>> ---
>>>>>>>  MAINTAINERS | 14 --------------
>>>>>>>  1 file changed, 14 deletions(-)
>>>>>>>
>>>>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>>>>> index e93f79672f..6ef6932628 100644
>>>>>>> --- a/MAINTAINERS
>>>>>>> +++ b/MAINTAINERS
>>>>>>> @@ -1982,28 +1982,22 @@ F: block/vmdk.c
>>>>>>>  
>>>>>>>  RBD
>>>>>>>  M: Josh Durgin <jdurgin@redhat.com>
>>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>>>  L: qemu-block@nongnu.org
>>>>>>>  S: Supported
>>>>>>>  F: block/rbd.c
>>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>>>  
>>>>>>>  Sheepdog
>>>>>>>  M: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
>>>>>>>  M: Liu Yuan <namei.unix@gmail.com>
>>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>>>  L: qemu-block@nongnu.org
>>>>>>>  L: sheepdog@lists.wpkg.org
>>>>>>>  S: Supported
>>>>>>>  F: block/sheepdog.c
>>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>>>  
>>>>>>>  VHDX
>>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>>>  L: qemu-block@nongnu.org
>>>>>>>  S: Supported
>>>>>>>  F: block/vhdx*
>>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>>
>>>>>> Does "S: Supported" make sense without an M:?
>>>>>>
>>>>>>>  
>>>>>>>  VDI
>>>>>>>  M: Stefan Weil <sw@weilnetz.de>
>>>>>>> @@ -2034,34 +2028,26 @@ F: docs/interop/nbd.txt
>>>>>>>  T: git git://repo.or.cz/qemu/ericb.git nbd
>>>>>>>  
>>>>>>>  NFS
>>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>>>  M: Peter Lieven <pl@kamp.de>
>>>>>>>  L: qemu-block@nongnu.org
>>>>>>>  S: Maintained
>>>>>>>  F: block/nfs.c
>>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>>>  
>>>>>>>  SSH
>>>>>>>  M: Richard W.M. Jones <rjones@redhat.com>
>>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>>>  L: qemu-block@nongnu.org
>>>>>>>  S: Supported
>>>>>>>  F: block/ssh.c
>>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>>>  
>>>>>>>  CURL
>>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>>>  L: qemu-block@nongnu.org
>>>>>>>  S: Supported
>>>>>>>  F: block/curl.c
>>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>>
>>>>>> Likewise.
>>>>>>
>>>>>>>  GLUSTER
>>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>>>  L: qemu-block@nongnu.org
>>>>>>>  S: Supported
>>>>>>>  F: block/gluster.c
>>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>>
>>>>>> Likewise.
>>>>>>
>>>>>>>  Null Block Driver
>>>>>>>  M: Fam Zheng <famz@redhat.com>
>>>>>>
>>>>>
>>>>> Block drivers without an M: naturally fall under the overall maintainership of
>>>>> block layer (Kevin&Max), so IMO keeping the statuses is fine. Maybe CURL can be
>>>>> degraded to Maintained, though.
>>>>
>>>> Yes, get_maintainer.pl combines all applicable sections.  Human readers
>>>> are left to wonder, unless they know to look for other matches.
>>>>
>>>> Do we want to have a dedicated network block driver submaintainer again,
>>>> if we can find one?
>>>>
>>>> Do we want to have a dedicated VHDX driver submaintainer again?  Fam,
>>>> you're maintaining VMDK, could you cover VHDX as well?
>>>
>>> Fam can't.
>>>
>>> I can see two sane options for the three sections that lose their sole
>>> maintainer (VHDX, CURL, GLUSTER):
>>>
>>> * Downgrade to S: Orphan
>>>
>>>   This reflects the fact that we'd like to have dedicated maintainers
>>>   for them.  It camouflages the fact that the "Block layer core"
>>>   maintainers pick up the slack.
>>>
>>> * Delete
>>>
>>>   The opposite.

    * Appoint suitable maintainers with the S: appropriate for them

      Special case: appoint yourself.  Doesn't actually change
      maintaintership (you're already on the hook as core maintainers),
      but it lets you adjust S:.

>>> Kevin, Max, please pick your poison, or suggest one you find tastier.
>> 
>> Orphan is probably by far closer to the truth than Supported. But I
>> think what we really do is Odd Fixes. Not sure if that's a status that
>> works in any meaningful way without having a maintainer for the specific
>> thing assigned?
>
> IMHO "Odd Fixes" is still ok for entries that have at least a "L:" line,
> like "L: qemu-block@nongnu.org". If an entry neither got a "M:" nor a
> "L:" line anymore, it should be marked with "Orphan" instead.

Contradicts "Odd Fixes: It has a maintainer", but that's fixable or
perhaps tolerable.
Markus Armbruster Jan. 9, 2019, 12:46 p.m. UTC | #12
Niels de Vos <ndevos@redhat.com> writes:

> On Tue, Jan 08, 2019 at 08:12:16PM +0100, Kevin Wolf wrote:
>> Am 08.01.2019 um 18:18 hat Markus Armbruster geschrieben:
>> > This patch series got stuck.
>> > 
>> > Markus Armbruster <armbru@redhat.com> writes:
>> > 
>> > > Fam Zheng <famz@redhat.com> writes:
>> > >
>> > >> On Tue, 09/25 07:00, Markus Armbruster wrote:
>> > >>> Jeff Cody <jcody@redhat.com> writes:
>> > >>> 
>> > >>> > I'll not be involved in day-to-day qemu development.  Remove
>> > >>> > myself as maintainer from the remainder of the network block drivers
>> > >>> > (and vhdx), and revert them to the general block layer maintainership.
>> > >>> >
>> > >>> > Signed-off-by: Jeff Cody <jcody@redhat.com>
>> > >>> > ---
>> > >>> >  MAINTAINERS | 14 --------------
>> > >>> >  1 file changed, 14 deletions(-)
>> > >>> >
>> > >>> > diff --git a/MAINTAINERS b/MAINTAINERS
>> > >>> > index e93f79672f..6ef6932628 100644
>> > >>> > --- a/MAINTAINERS
>> > >>> > +++ b/MAINTAINERS
>> > >>> > @@ -1982,28 +1982,22 @@ F: block/vmdk.c
>> > >>> >  
>> > >>> >  RBD
>> > >>> >  M: Josh Durgin <jdurgin@redhat.com>
>> > >>> > -M: Jeff Cody <jcody@redhat.com>
>> > >>> >  L: qemu-block@nongnu.org
>> > >>> >  S: Supported
>> > >>> >  F: block/rbd.c
>> > >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>> > >>> >  
>> > >>> >  Sheepdog
>> > >>> >  M: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
>> > >>> >  M: Liu Yuan <namei.unix@gmail.com>
>> > >>> > -M: Jeff Cody <jcody@redhat.com>
>> > >>> >  L: qemu-block@nongnu.org
>> > >>> >  L: sheepdog@lists.wpkg.org
>> > >>> >  S: Supported
>> > >>> >  F: block/sheepdog.c
>> > >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>> > >>> >  
>> > >>> >  VHDX
>> > >>> > -M: Jeff Cody <jcody@redhat.com>
>> > >>> >  L: qemu-block@nongnu.org
>> > >>> >  S: Supported
>> > >>> >  F: block/vhdx*
>> > >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>> > >>> 
>> > >>> Does "S: Supported" make sense without an M:?
>> > >>> 
>> > >>> >  
>> > >>> >  VDI
>> > >>> >  M: Stefan Weil <sw@weilnetz.de>
>> > >>> > @@ -2034,34 +2028,26 @@ F: docs/interop/nbd.txt
>> > >>> >  T: git git://repo.or.cz/qemu/ericb.git nbd
>> > >>> >  
>> > >>> >  NFS
>> > >>> > -M: Jeff Cody <jcody@redhat.com>
>> > >>> >  M: Peter Lieven <pl@kamp.de>
>> > >>> >  L: qemu-block@nongnu.org
>> > >>> >  S: Maintained
>> > >>> >  F: block/nfs.c
>> > >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>> > >>> >  
>> > >>> >  SSH
>> > >>> >  M: Richard W.M. Jones <rjones@redhat.com>
>> > >>> > -M: Jeff Cody <jcody@redhat.com>
>> > >>> >  L: qemu-block@nongnu.org
>> > >>> >  S: Supported
>> > >>> >  F: block/ssh.c
>> > >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>> > >>> >  
>> > >>> >  CURL
>> > >>> > -M: Jeff Cody <jcody@redhat.com>
>> > >>> >  L: qemu-block@nongnu.org
>> > >>> >  S: Supported
>> > >>> >  F: block/curl.c
>> > >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>> > >>> 
>> > >>> Likewise.
>> > >>> 
>> > >>> >  GLUSTER
>> > >>> > -M: Jeff Cody <jcody@redhat.com>
>> > >>> >  L: qemu-block@nongnu.org
>> > >>> >  S: Supported
>> > >>> >  F: block/gluster.c
>> > >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>> > >>> 
>> > >>> Likewise.
>> > >>> 
>> > >>> >  Null Block Driver
>> > >>> >  M: Fam Zheng <famz@redhat.com>
>> > >>> 
>> > >>
>> > >> Block drivers without an M: naturally fall under the overall maintainership of
>> > >> block layer (Kevin&Max), so IMO keeping the statuses is fine. Maybe CURL can be
>> > >> degraded to Maintained, though.
>> > >
>> > > Yes, get_maintainer.pl combines all applicable sections.  Human readers
>> > > are left to wonder, unless they know to look for other matches.
>> > >
>> > > Do we want to have a dedicated network block driver submaintainer again,
>> > > if we can find one?
>> > >
>> > > Do we want to have a dedicated VHDX driver submaintainer again?  Fam,
>> > > you're maintaining VMDK, could you cover VHDX as well?
>> > 
>> > Fam can't.
>> > 
>> > I can see two sane options for the three sections that lose their sole
>> > maintainer (VHDX, CURL, GLUSTER):
>> > 
>> > * Downgrade to S: Orphan
>> > 
>> >   This reflects the fact that we'd like to have dedicated maintainers
>> >   for them.  It camouflages the fact that the "Block layer core"
>> >   maintainers pick up the slack.
>> > 
>> > * Delete
>> > 
>> >   The opposite.
>> > 
>> > Kevin, Max, please pick your poison, or suggest one you find tastier.
>> 
>> Orphan is probably by far closer to the truth than Supported. But I
>> think what we really do is Odd Fixes. Not sure if that's a status that
>> works in any meaningful way without having a maintainer for the specific
>> thing assigned?
>
> For Gluster we are interested in keeping it maintained in some form. At
> least integration@gluster.org could be added as a list. I am not sure
> there is anyone working on Gluster that would fit for a maintainer of
> the driver. If you really want to put a name there, I can function as a
> 'maintainer' and pull in other Gluster developers in case I am otherwise
> occupied.

Leads us to the question what it takes to be a maintainer.  I figure we
need at least a commitment to get patches reviewed, plus the ability to
get them reviewed competently.

Note my careful use of the passive voice: whether the maintainer does it
himself or herds a team of intelligent cats to do it may not matter all
that much to us.

Patch
diff mbox series

diff --git a/MAINTAINERS b/MAINTAINERS
index e93f79672f..6ef6932628 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1982,28 +1982,22 @@  F: block/vmdk.c
 
 RBD
 M: Josh Durgin <jdurgin@redhat.com>
-M: Jeff Cody <jcody@redhat.com>
 L: qemu-block@nongnu.org
 S: Supported
 F: block/rbd.c
-T: git git://github.com/codyprime/qemu-kvm-jtc.git block
 
 Sheepdog
 M: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
 M: Liu Yuan <namei.unix@gmail.com>
-M: Jeff Cody <jcody@redhat.com>
 L: qemu-block@nongnu.org
 L: sheepdog@lists.wpkg.org
 S: Supported
 F: block/sheepdog.c
-T: git git://github.com/codyprime/qemu-kvm-jtc.git block
 
 VHDX
-M: Jeff Cody <jcody@redhat.com>
 L: qemu-block@nongnu.org
 S: Supported
 F: block/vhdx*
-T: git git://github.com/codyprime/qemu-kvm-jtc.git block
 
 VDI
 M: Stefan Weil <sw@weilnetz.de>
@@ -2034,34 +2028,26 @@  F: docs/interop/nbd.txt
 T: git git://repo.or.cz/qemu/ericb.git nbd
 
 NFS
-M: Jeff Cody <jcody@redhat.com>
 M: Peter Lieven <pl@kamp.de>
 L: qemu-block@nongnu.org
 S: Maintained
 F: block/nfs.c
-T: git git://github.com/codyprime/qemu-kvm-jtc.git block
 
 SSH
 M: Richard W.M. Jones <rjones@redhat.com>
-M: Jeff Cody <jcody@redhat.com>
 L: qemu-block@nongnu.org
 S: Supported
 F: block/ssh.c
-T: git git://github.com/codyprime/qemu-kvm-jtc.git block
 
 CURL
-M: Jeff Cody <jcody@redhat.com>
 L: qemu-block@nongnu.org
 S: Supported
 F: block/curl.c
-T: git git://github.com/codyprime/qemu-kvm-jtc.git block
 
 GLUSTER
-M: Jeff Cody <jcody@redhat.com>
 L: qemu-block@nongnu.org
 S: Supported
 F: block/gluster.c
-T: git git://github.com/codyprime/qemu-kvm-jtc.git block
 
 Null Block Driver
 M: Fam Zheng <famz@redhat.com>