| Message ID | 1537849462-619-6-git-send-email-anand.jain@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fix _scratch_mkfs_sized() for btrfs | expand |
On 25.09.2018 07:24, Anand Jain wrote: > Open code helps to grep and find out parameter sent to the > _scratch_mkfs_sized here. > > Signed-off-by: Anand Jain <anand.jain@oracle.com> IMO this is noise, you can just as simply do "grep _scratch_mkfs_sized" and then open the file to inspect the actual argument. But it's up to the xfstest maintainers > --- > tests/generic/102 | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tests/generic/102 b/tests/generic/102 > index faf940ac5070..aad496a5bc69 100755 > --- a/tests/generic/102 > +++ b/tests/generic/102 > @@ -31,8 +31,7 @@ _require_scratch > > rm -f $seqres.full > > -dev_size=$((512 * 1024 * 1024)) # 512MB filesystem > -_scratch_mkfs_sized $dev_size >>$seqres.full 2>&1 > +_scratch_mkfs_sized $((512 * 1024 * 1024)) >>$seqres.full 2>&1 > _scratch_mount > > for ((i = 0; i < 10; i++)); do >
On 09/25/2018 06:54 PM, Nikolay Borisov wrote: > > > On 25.09.2018 07:24, Anand Jain wrote: >> Open code helps to grep and find out parameter sent to the >> _scratch_mkfs_sized here. >> >> Signed-off-by: Anand Jain <anand.jain@oracle.com> > > IMO this is noise, you can just as simply do > "grep _scratch_mkfs_sized" and then open the file to inspect the actual > argument. But it's up to the xfstest maintainers I am ok. Its just a nice cleanup. Thanks, Anand >> --- >> tests/generic/102 | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/tests/generic/102 b/tests/generic/102 >> index faf940ac5070..aad496a5bc69 100755 >> --- a/tests/generic/102 >> +++ b/tests/generic/102 >> @@ -31,8 +31,7 @@ _require_scratch >> >> rm -f $seqres.full >> >> -dev_size=$((512 * 1024 * 1024)) # 512MB filesystem >> -_scratch_mkfs_sized $dev_size >>$seqres.full 2>&1 >> +_scratch_mkfs_sized $((512 * 1024 * 1024)) >>$seqres.full 2>&1 >> _scratch_mount >> >> for ((i = 0; i < 10; i++)); do >>
On Wed, Sep 26, 2018 at 12:08:56PM +0800, Anand Jain wrote: > > > On 09/25/2018 06:54 PM, Nikolay Borisov wrote: > > > > > > On 25.09.2018 07:24, Anand Jain wrote: > > > Open code helps to grep and find out parameter sent to the > > > _scratch_mkfs_sized here. > > > > > > Signed-off-by: Anand Jain <anand.jain@oracle.com> > > > > IMO this is noise, you can just as simply do > > "grep _scratch_mkfs_sized" and then open the file to inspect the actual > > argument. But it's up to the xfstest maintainers > > I am ok. Its just a nice cleanup. > > Thanks, Anand I prefer dropping patch 5/6/7, as I don't think they're that necessary. BTW, other patches from this series but patch 3 ("geneirc/077 fix min size for btrfs") look fine to me, I'm taking them in this week's update. Thanks, Eryu > > > > --- > > > tests/generic/102 | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/tests/generic/102 b/tests/generic/102 > > > index faf940ac5070..aad496a5bc69 100755 > > > --- a/tests/generic/102 > > > +++ b/tests/generic/102 > > > @@ -31,8 +31,7 @@ _require_scratch > > > rm -f $seqres.full > > > -dev_size=$((512 * 1024 * 1024)) # 512MB filesystem > > > -_scratch_mkfs_sized $dev_size >>$seqres.full 2>&1 > > > +_scratch_mkfs_sized $((512 * 1024 * 1024)) >>$seqres.full 2>&1 > > > _scratch_mount > > > for ((i = 0; i < 10; i++)); do > > >
diff --git a/tests/generic/102 b/tests/generic/102 index faf940ac5070..aad496a5bc69 100755 --- a/tests/generic/102 +++ b/tests/generic/102 @@ -31,8 +31,7 @@ _require_scratch rm -f $seqres.full -dev_size=$((512 * 1024 * 1024)) # 512MB filesystem -_scratch_mkfs_sized $dev_size >>$seqres.full 2>&1 +_scratch_mkfs_sized $((512 * 1024 * 1024)) >>$seqres.full 2>&1 _scratch_mount for ((i = 0; i < 10; i++)); do
Open code helps to grep and find out parameter sent to the _scratch_mkfs_sized here. Signed-off-by: Anand Jain <anand.jain@oracle.com> --- tests/generic/102 | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)