diff mbox series

drm/panel: simple: Add DLC1010GIG panel

Message ID 20180924152610.25939-1-m.felsch@pengutronix.de (mailing list archive)
State New, archived
Headers show
Series drm/panel: simple: Add DLC1010GIG panel | expand

Commit Message

Marco Felsch Sept. 24, 2018, 3:26 p.m. UTC
Add support for the DLC DLC1010GIG 1280x800 10.1" LVDS panel to the
simple-panel driver.

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
 .../bindings/display/panel/dlc,dlc1010gig.txt | 12 +++++++
 drivers/gpu/drm/panel/panel-simple.c          | 33 +++++++++++++++++++
 2 files changed, 45 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/dlc,dlc1010gig.txt

Comments

Thierry Reding Sept. 27, 2018, 12:23 p.m. UTC | #1
On Mon, Sep 24, 2018 at 05:26:10PM +0200, Marco Felsch wrote:
> Add support for the DLC DLC1010GIG 1280x800 10.1" LVDS panel to the
> simple-panel driver.
> 
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
>  .../bindings/display/panel/dlc,dlc1010gig.txt | 12 +++++++
>  drivers/gpu/drm/panel/panel-simple.c          | 33 +++++++++++++++++++
>  2 files changed, 45 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/dlc,dlc1010gig.txt

Please make DT bindings and driver changes separate patches next time,
otherwise checkpatch complains when applying.

Applied, thanks.

Thierry
Thierry Reding Sept. 27, 2018, 12:28 p.m. UTC | #2
On Mon, Sep 24, 2018 at 05:26:10PM +0200, Marco Felsch wrote:
> Add support for the DLC DLC1010GIG 1280x800 10.1" LVDS panel to the
> simple-panel driver.
> 
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
>  .../bindings/display/panel/dlc,dlc1010gig.txt | 12 +++++++
>  drivers/gpu/drm/panel/panel-simple.c          | 33 +++++++++++++++++++
>  2 files changed, 45 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/dlc,dlc1010gig.txt

checkpatch complains about some minor issues. I've addressed most of
them while applying, but next time, please make sure to run checkpatch
and addressing the issues that it flags before sending.

Thanks,
Thierry
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/dlc,dlc1010gig.txt b/Documentation/devicetree/bindings/display/panel/dlc,dlc1010gig.txt
new file mode 100644
index 000000000000..fbf5dcd15661
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/dlc,dlc1010gig.txt
@@ -0,0 +1,12 @@ 
+DLC Display Co. DLC1010GIG 10.1" WXGA TFT LCD Panel
+
+Required properties:
+- compatible: should be "dlc,dlc1010gig"
+- power-supply: See simple-panel.txt
+
+Optional properties:
+- enable-gpios: See simple-panel.txt
+- backlight: See simple-panel.txt
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 97964f7f2ace..3ac617066399 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -961,6 +961,36 @@  static const struct panel_desc dlc_dlc0700yzg_1 = {
 	.bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
 };
 
+static const struct display_timing dlc_dlc1010gig_timing = {
+	.pixelclock = { 68900000, 71100000, 73400000 },
+	.hactive = { 1280, 1280, 1280 },
+	.hfront_porch = { 43, 53, 63 },
+	.hback_porch = { 43, 53, 63 },
+	.hsync_len = { 44, 54, 64 },
+	.vactive = { 800, 800, 800 },
+	.vfront_porch = { 5, 8, 11 },
+	.vback_porch = { 5, 8, 11 },
+	.vsync_len = { 5, 7, 11 },
+	.flags = DISPLAY_FLAGS_DE_HIGH,
+};
+
+static const struct panel_desc dlc_dlc1010gig = {
+	.timings = &dlc_dlc1010gig_timing,
+	.num_timings = 1,
+	.bpc = 8,
+	.size = {
+		.width = 216,
+		.height = 135,
+	},
+	.delay = {
+		.prepare = 60,
+		.enable = 150,
+		.disable = 100,
+		.unprepare = 60,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+};
+
 static const struct drm_display_mode edt_et057090dhu_mode = {
 	.clock = 25175,
 	.hdisplay = 640,
@@ -2390,6 +2420,9 @@  static const struct of_device_id platform_of_match[] = {
 	}, {
 		.compatible = "dlc,dlc0700yzg-1",
 		.data = &dlc_dlc0700yzg_1,
+	}, {
+		.compatible = "dlc,dlc1010gig",
+		.data = &dlc_dlc1010gig,
 	}, {
 		.compatible = "edt,et057090dhu",
 		.data = &edt_et057090dhu,