| Message ID | 1537886137-22153-1-git-send-email-weiyongjun1@huawei.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | [-next] crypto: ccp - Make function sev_get_firmware() static | expand |
On 09/25/2018 09:35 AM, Wei Yongjun wrote: > Fixes the following sparse warning: > > drivers/crypto/ccp/psp-dev.c:444:5: warning: > symbol 'sev_get_firmware' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> This appears to have been introduced by (cryptodev-2.6) commit e93720606efdbe914110e0ee94bd086f5514a6f1. Please update this commit message with all of the "fixes" magic (or whatever has to happen in the cryptodev repo), and CC: the author of the original patch. > --- > drivers/crypto/ccp/psp-dev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/crypto/ccp/psp-dev.c b/drivers/crypto/ccp/psp-dev.c > index 3b33863..d64a78c 100644 > --- a/drivers/crypto/ccp/psp-dev.c > +++ b/drivers/crypto/ccp/psp-dev.c > @@ -441,7 +441,8 @@ static int sev_get_api_version(void) > return 0; > } > > -int sev_get_firmware(struct device *dev, const struct firmware **firmware) > +static int sev_get_firmware(struct device *dev, > + const struct firmware **firmware) > { > char fw_name_specific[SEV_FW_NAME_SIZE]; > char fw_name_subset[SEV_FW_NAME_SIZE]; >
diff --git a/drivers/crypto/ccp/psp-dev.c b/drivers/crypto/ccp/psp-dev.c index 3b33863..d64a78c 100644 --- a/drivers/crypto/ccp/psp-dev.c +++ b/drivers/crypto/ccp/psp-dev.c @@ -441,7 +441,8 @@ static int sev_get_api_version(void) return 0; } -int sev_get_firmware(struct device *dev, const struct firmware **firmware) +static int sev_get_firmware(struct device *dev, + const struct firmware **firmware) { char fw_name_specific[SEV_FW_NAME_SIZE]; char fw_name_subset[SEV_FW_NAME_SIZE];
Fixes the following sparse warning: drivers/crypto/ccp/psp-dev.c:444:5: warning: symbol 'sev_get_firmware' was not declared. Should it be static? Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/crypto/ccp/psp-dev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)