kvm: vmx: Remove a mysterious FIXME
diff mbox series

Message ID 20180925205741.162254-1-jmattson@google.com
State New
Headers show
Series
  • kvm: vmx: Remove a mysterious FIXME
Related show

Commit Message

Jim Mattson Sept. 25, 2018, 8:57 p.m. UTC
Bits 63:32 of %rax and %rdx are cleared in handle_rdmsr, as they
should be.  There is nothing here to fix.

Signed-off-by: Jim Mattson <jmattson@google.com>
---
 arch/x86/kvm/vmx.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Jim Mattson Oct. 12, 2018, 9:26 p.m. UTC | #1
On Tue, Sep 25, 2018 at 1:57 PM, Jim Mattson <jmattson@google.com> wrote:
> Bits 63:32 of %rax and %rdx are cleared in handle_rdmsr, as they
> should be.  There is nothing here to fix.
>
> Signed-off-by: Jim Mattson <jmattson@google.com>
> ---
>  arch/x86/kvm/vmx.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 06412ba46aa3..aba4780fbe82 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -7452,7 +7452,6 @@ static int handle_rdmsr(struct kvm_vcpu *vcpu)
>
>         trace_kvm_msr_read(ecx, msr_info.data);
>
> -       /* FIXME: handling of bits 32:63 of rax, rdx */
>         vcpu->arch.regs[VCPU_REGS_RAX] = msr_info.data & -1u;
>         vcpu->arch.regs[VCPU_REGS_RDX] = (msr_info.data >> 32) & -1u;
>         return kvm_skip_emulated_instruction(vcpu);
> --
> 2.19.0.605.g01d371f741-goog
>

Ping.
Krish Sadhukhan Oct. 12, 2018, 10:02 p.m. UTC | #2
On 10/12/2018 02:26 PM, Jim Mattson wrote:
> On Tue, Sep 25, 2018 at 1:57 PM, Jim Mattson <jmattson@google.com> wrote:
>> Bits 63:32 of %rax and %rdx are cleared in handle_rdmsr, as they
>> should be.  There is nothing here to fix.
>>
>> Signed-off-by: Jim Mattson <jmattson@google.com>
>> ---
>>   arch/x86/kvm/vmx.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
>> index 06412ba46aa3..aba4780fbe82 100644
>> --- a/arch/x86/kvm/vmx.c
>> +++ b/arch/x86/kvm/vmx.c
>> @@ -7452,7 +7452,6 @@ static int handle_rdmsr(struct kvm_vcpu *vcpu)
>>
>>          trace_kvm_msr_read(ecx, msr_info.data);
>>
>> -       /* FIXME: handling of bits 32:63 of rax, rdx */
>>          vcpu->arch.regs[VCPU_REGS_RAX] = msr_info.data & -1u;
>>          vcpu->arch.regs[VCPU_REGS_RDX] = (msr_info.data >> 32) & -1u;
>>          return kvm_skip_emulated_instruction(vcpu);
>> --
>> 2.19.0.605.g01d371f741-goog
>>
> Ping.

Reviewed-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>

Patch
diff mbox series

diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 06412ba46aa3..aba4780fbe82 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -7452,7 +7452,6 @@  static int handle_rdmsr(struct kvm_vcpu *vcpu)
 
 	trace_kvm_msr_read(ecx, msr_info.data);
 
-	/* FIXME: handling of bits 32:63 of rax, rdx */
 	vcpu->arch.regs[VCPU_REGS_RAX] = msr_info.data & -1u;
 	vcpu->arch.regs[VCPU_REGS_RDX] = (msr_info.data >> 32) & -1u;
 	return kvm_skip_emulated_instruction(vcpu);