| Message ID | 20181001101116.27281-1-niklas.cassel@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | slimbus: ngd: QCOM_QMI_HELPERS has to be selected | expand |
On 10/01/2018 05:11 AM, Niklas Cassel wrote: > QCOM_QMI_HELPERS is a hidden kconfig, so the proper usage is > to select it, not depend upon it. > > Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org> Looks good. Reviewed-by: Alex Elder <elder@linaro.org> > --- > drivers/slimbus/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/slimbus/Kconfig b/drivers/slimbus/Kconfig > index 9d73ad806698..9cca2c3559f2 100644 > --- a/drivers/slimbus/Kconfig > +++ b/drivers/slimbus/Kconfig > @@ -22,8 +22,8 @@ config SLIM_QCOM_CTRL > > config SLIM_QCOM_NGD_CTRL > tristate "Qualcomm SLIMbus Satellite Non-Generic Device Component" > - depends on QCOM_QMI_HELPERS > depends on HAS_IOMEM && DMA_ENGINE > + select QCOM_QMI_HELPERS > help > Select driver if Qualcomm's SLIMbus Satellite Non-Generic Device > Component is programmed using Linux kernel. >
On Mon 01 Oct 03:11 PDT 2018, Niklas Cassel wrote: > QCOM_QMI_HELPERS is a hidden kconfig, so the proper usage is > to select it, not depend upon it. > > Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > --- > drivers/slimbus/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/slimbus/Kconfig b/drivers/slimbus/Kconfig > index 9d73ad806698..9cca2c3559f2 100644 > --- a/drivers/slimbus/Kconfig > +++ b/drivers/slimbus/Kconfig > @@ -22,8 +22,8 @@ config SLIM_QCOM_CTRL > > config SLIM_QCOM_NGD_CTRL > tristate "Qualcomm SLIMbus Satellite Non-Generic Device Component" > - depends on QCOM_QMI_HELPERS > depends on HAS_IOMEM && DMA_ENGINE > + select QCOM_QMI_HELPERS > help > Select driver if Qualcomm's SLIMbus Satellite Non-Generic Device > Component is programmed using Linux kernel. > -- > 2.17.1 >
diff --git a/drivers/slimbus/Kconfig b/drivers/slimbus/Kconfig index 9d73ad806698..9cca2c3559f2 100644 --- a/drivers/slimbus/Kconfig +++ b/drivers/slimbus/Kconfig @@ -22,8 +22,8 @@ config SLIM_QCOM_CTRL config SLIM_QCOM_NGD_CTRL tristate "Qualcomm SLIMbus Satellite Non-Generic Device Component" - depends on QCOM_QMI_HELPERS depends on HAS_IOMEM && DMA_ENGINE + select QCOM_QMI_HELPERS help Select driver if Qualcomm's SLIMbus Satellite Non-Generic Device Component is programmed using Linux kernel.
QCOM_QMI_HELPERS is a hidden kconfig, so the proper usage is to select it, not depend upon it. Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org> --- drivers/slimbus/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)