zsmalloc: fix fall-through annotation
diff mbox series

Message ID 20181003105114.GA24423@embeddedor.com
State New
Headers show
Series
  • zsmalloc: fix fall-through annotation
Related show

Commit Message

Gustavo A. R. Silva Oct. 3, 2018, 10:51 a.m. UTC
Replace "fallthru" with a proper "fall through" annotation.

This fix is part of the ongoing efforts to enabling
-Wimplicit-fallthrough

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 mm/zsmalloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sergey Senozhatsky Oct. 3, 2018, 12:26 p.m. UTC | #1
On (10/03/18 12:51), Gustavo A. R. Silva wrote:
> Replace "fallthru" with a proper "fall through" annotation.
> 
> This fix is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough

Hmm, comments as annotations?


> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

	-ss
Sergey Senozhatsky Oct. 3, 2018, 12:32 p.m. UTC | #2
Oh, Cc-ing Andrew

message id: lkml.kernel.org/r/20181003105114.GA24423@embeddedor.com


---

On (10/03/18 21:26), Sergey Senozhatsky wrote:
> On (10/03/18 12:51), Gustavo A. R. Silva wrote:
> Replace "fallthru" with a proper "fall through" annotation.
> 
> This fix is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough

Hmm, comments as annotations?


> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

Patch
diff mbox series

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 58886d4..fd4b3a9 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -418,7 +418,7 @@  static void *zs_zpool_map(void *pool, unsigned long handle,
 	case ZPOOL_MM_WO:
 		zs_mm = ZS_MM_WO;
 		break;
-	case ZPOOL_MM_RW: /* fallthru */
+	case ZPOOL_MM_RW: /* fall through */
 	default:
 		zs_mm = ZS_MM_RW;
 		break;