| Message ID | 20181003222901.44438-1-elliott@hpe.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ndctl, check-labels: correct check-labels message wording | expand |
On Wed, Oct 3, 2018 at 3:26 PM Robert Elliott <elliott@hpe.com> wrote: > > ndctl check-labels prints the number of labels, not the number of > nmems. Changed the print for: > > $ ndctl check-labels nmem0 nmem1 > from: > successfully verified 510 nmems > to: > successfully verified 510 nmem labels Looks good to me. Reviewed-by: Dan Williams <dan.j.williams@intel.com> > > Signed-off-by: Robert Elliott <elliott@hpe.com> > --- > ndctl/dimm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ndctl/dimm.c b/ndctl/dimm.c > index a4203f3..699ab57 100644 > --- a/ndctl/dimm.c > +++ b/ndctl/dimm.c > @@ -1147,7 +1147,7 @@ int cmd_check_labels(int argc, const char **argv, void *ctx) > int count = dimm_action(argc, argv, ctx, action_check, base_options, > "ndctl check-labels <nmem0> [<nmem1>..<nmemN>] [<options>]"); > > - fprintf(stderr, "successfully verified %d nmem%s\n", > + fprintf(stderr, "successfully verified %d nmem label%s\n", > count >= 0 ? count : 0, count > 1 ? "s" : ""); > return count >= 0 ? 0 : EXIT_FAILURE; > } > -- > 2.14.4 > > _______________________________________________ > Linux-nvdimm mailing list > Linux-nvdimm@lists.01.org > https://lists.01.org/mailman/listinfo/linux-nvdimm
diff --git a/ndctl/dimm.c b/ndctl/dimm.c index a4203f3..699ab57 100644 --- a/ndctl/dimm.c +++ b/ndctl/dimm.c @@ -1147,7 +1147,7 @@ int cmd_check_labels(int argc, const char **argv, void *ctx) int count = dimm_action(argc, argv, ctx, action_check, base_options, "ndctl check-labels <nmem0> [<nmem1>..<nmemN>] [<options>]"); - fprintf(stderr, "successfully verified %d nmem%s\n", + fprintf(stderr, "successfully verified %d nmem label%s\n", count >= 0 ? count : 0, count > 1 ? "s" : ""); return count >= 0 ? 0 : EXIT_FAILURE; }
ndctl check-labels prints the number of labels, not the number of nmems. Changed the print for: $ ndctl check-labels nmem0 nmem1 from: successfully verified 510 nmems to: successfully verified 510 nmem labels Signed-off-by: Robert Elliott <elliott@hpe.com> --- ndctl/dimm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)