Message ID | 20181004202446.22905-5-daniel.vetter@ffwll.ch (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <dri-devel-bounces@lists.freedesktop.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 85274174A for <patchwork-dri-devel@patchwork.kernel.org>; Thu, 4 Oct 2018 20:25:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 78576296F1 for <patchwork-dri-devel@patchwork.kernel.org>; Thu, 4 Oct 2018 20:25:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6CB7F296FF; Thu, 4 Oct 2018 20:25:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 276DC296F1 for <patchwork-dri-devel@patchwork.kernel.org>; Thu, 4 Oct 2018 20:25:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 178A16E66B; Thu, 4 Oct 2018 20:25:08 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id C69B76E667 for <dri-devel@lists.freedesktop.org>; Thu, 4 Oct 2018 20:25:04 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id c22-v6so9741050edc.4 for <dri-devel@lists.freedesktop.org>; Thu, 04 Oct 2018 13:25:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=o0if7ixcIWSIRFaTftGQ9TF7GQHjrFkThZtqhrXGfio=; b=FsQnugYwUxNYHzCb7JOCZo1jz8/jz4ebGHcF0MeUQhOJ0U72lBGgFeMFMirwvKGcFg AY0aZ2SR3Tm9+6k+Nf3rdSNcIdlkNg8LYD5U4RnB0XdAa56xRiYcWzjTs4IONj4pkAbK cywTlaEodMm2+Zu9i1lDIS1Bzz3z5JFSqglSWBsbJYE6vGzlQeuKiWHssKOtQ3vXizeU 3D5aOoY+enSX2S1HqY+BosKlxjfARxHCl40f7LGkdYvbAy6sttrEwvs7sxuZAvkODDb5 i/pNBgOEXhXZYsdtgzTem7N3+kx5hc4i5B3m3XAsPocokESO4N/aPqZkdfde/0cAH7WI fL/A== X-Gm-Message-State: ABuFfojd4Dw/OveCGwpvgMkQQedG9fCn3fPXMDo0OTWJ8veEPTjzpYGm 2zWgY5X2/u2WhkCUuRnszMX5rKfzAK8= X-Google-Smtp-Source: ACcGV63FusXM7Vtj8a9+ETJQQFCjOfXu9aDTE0AyYi/vIydvqDMAFVL2kkB4Q0sTv1vnrGyUsofJuQ== X-Received: by 2002:a50:f397:: with SMTP id g23-v6mr10694619edm.110.1538684702935; Thu, 04 Oct 2018 13:25:02 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id y8-v6sm2040002edd.43.2018.10.04.13.25.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Oct 2018 13:25:01 -0700 (PDT) From: Daniel Vetter <daniel.vetter@ffwll.ch> To: DRI Development <dri-devel@lists.freedesktop.org> Subject: [PATCH 04/21] drm/vmwgfx: Don't look at state->allow_modeset Date: Thu, 4 Oct 2018 22:24:29 +0200 Message-Id: <20181004202446.22905-5-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.19.0.rc2 In-Reply-To: <20181004202446.22905-1-daniel.vetter@ffwll.ch> References: <20181004202446.22905-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development <dri-devel.lists.freedesktop.org> List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>, <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe> List-Archive: <https://lists.freedesktop.org/archives/dri-devel> List-Post: <mailto:dri-devel@lists.freedesktop.org> List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help> List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>, <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org> X-Virus-Scanned: ClamAV using ClamSMTP |
Series |
atomic helper cleanup, take 2
|
expand
|
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c index dca04d4246ea..91ad45b22fee 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c @@ -1681,14 +1681,6 @@ vmw_kms_atomic_check_modeset(struct drm_device *dev, if (ret) return ret; - if (!state->allow_modeset) - return ret; - - /* - * Legacy path do not set allow_modeset properly like - * @drm_atomic_helper_update_plane, This will result in unnecessary call - * to vmw_kms_check_topology. So extra set of check. - */ for_each_new_crtc_in_state(state, crtc, crtc_state, i) { if (drm_atomic_crtc_needs_modeset(crtc_state)) need_modeset = true;
That's purely for the uapi layer to implement the ALLOW_MODESET flag. Drivers should instead look at the state, e.g. through drm_atomic_crtc_needs_modeset(), which vmwgfx already does. Also remove the confusing comment, since checking allow_modeset is at best a micro optimization. Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 8 -------- 1 file changed, 8 deletions(-)