[19/21] drm/doc: fix drm_driver_legacy_fb_format
diff mbox series

Message ID 20181004202446.22905-20-daniel.vetter@ffwll.ch
State New
Headers show
Series
  • atomic helper cleanup, take 2
Related show

Commit Message

Daniel Vetter Oct. 4, 2018, 8:24 p.m. UTC
Didn't get updated in a rework of the original patch.

Fixes: 059b5eb5d955 ("drm: move native byte order quirk to new drm_driver_legacy_fb_format function")
Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/drm_fourcc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Gerd Hoffmann Oct. 5, 2018, 5:07 a.m. UTC | #1
On Thu, Oct 04, 2018 at 10:24:44PM +0200, Daniel Vetter wrote:
> Didn't get updated in a rework of the original patch.

Oops.  Thanks for fixing,

>  /**
>   * drm_driver_legacy_fb_format - compute drm fourcc code from legacy description
> + * @dev: DRM device
>   * @bpp: bits per pixels
>   * @depth: bit depth per pixel
> - * @native: use host native byte order
>   *
>   * Computes a drm fourcc pixel format code for the given @bpp/@depth values.
>   * Unlike drm_mode_legacy_fb_format() this looks at the drivers mode_config,
> - * and depending on the quirk_addfb_prefer_host_byte_order flag it returns
> - * little endian byte order or host byte order framebuffer formats.
> + * and depending on the &drm_mode_config.quirk_addfb_prefer_host_byte_order flag
> + * it returns little endian byte order or host byte order framebuffer formats.
>   */

Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>

Patch
diff mbox series

diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c
index 90a1c846fc25..3934527e09dc 100644
--- a/drivers/gpu/drm/drm_fourcc.c
+++ b/drivers/gpu/drm/drm_fourcc.c
@@ -97,14 +97,14 @@  EXPORT_SYMBOL(drm_mode_legacy_fb_format);
 
 /**
  * drm_driver_legacy_fb_format - compute drm fourcc code from legacy description
+ * @dev: DRM device
  * @bpp: bits per pixels
  * @depth: bit depth per pixel
- * @native: use host native byte order
  *
  * Computes a drm fourcc pixel format code for the given @bpp/@depth values.
  * Unlike drm_mode_legacy_fb_format() this looks at the drivers mode_config,
- * and depending on the quirk_addfb_prefer_host_byte_order flag it returns
- * little endian byte order or host byte order framebuffer formats.
+ * and depending on the &drm_mode_config.quirk_addfb_prefer_host_byte_order flag
+ * it returns little endian byte order or host byte order framebuffer formats.
  */
 uint32_t drm_driver_legacy_fb_format(struct drm_device *dev,
 				     uint32_t bpp, uint32_t depth)