From patchwork Thu Oct 4 20:24:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10626657 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 10EBC174A for ; Thu, 4 Oct 2018 20:26:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0561F2971D for ; Thu, 4 Oct 2018 20:26:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EDA1429727; Thu, 4 Oct 2018 20:26:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9DC4C2971D for ; Thu, 4 Oct 2018 20:26:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4163E6E679; Thu, 4 Oct 2018 20:25:36 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id 13DEE6E678 for ; Thu, 4 Oct 2018 20:25:33 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id y19-v6so9762115edd.2 for ; Thu, 04 Oct 2018 13:25:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Oo3nHQlD4aTw2ZdhpddlBpzAx8tOG1EIebutrMeAMHw=; b=tUvDTM+mRFaqAr6duS3bEoZ7z9Znjm32IfRLv6hDcWT5WlGIAhXBWfAX22icSlB2W8 fsh/LWlnG2O+9BCDbJ/XIg9fylQ5I+kVJuOio3IWd0UBv5TdOxodbwjIrdWgZlk0EArW JdLGLc7GCfJlovneKoU3NLW/1YV/OUFZZDCJs2ncteQ8Aft8qVxdg+F5e3EKSqauj4ar CDF9IJ6CAVh7L/c9vkv9iT/lnXazB2u8+g3c1pxwDUimaL2XfMT5iMY2oijgZ/cJNDaw LWA0TgRV50a8nZhTgHxaXL1JcIvYPALBel3iWabhj+Y65X2NQi5V/vzYrUO6OmzdgUpA zz+g== X-Gm-Message-State: ABuFfoggo+BuFSIEjsLzi5YlhmwxrhjZPBdlQfYUvHDVtx7G4p/RUTLW gkaVdp72NdzZi6Ud7Lc8hYKpxz0c79E= X-Google-Smtp-Source: ACcGV61unaeSRRnh26rLLvJvBrjwhDRo8FdTBRpYYjFXLwDwjEca1ZQdHekW9YK96afYw16yfZ9j1A== X-Received: by 2002:aa7:c883:: with SMTP id p3-v6mr10603959eds.295.1538684731312; Thu, 04 Oct 2018 13:25:31 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id y8-v6sm2040002edd.43.2018.10.04.13.25.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Oct 2018 13:25:30 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 20/21] drm/todo: Add some cleanup tasks Date: Thu, 4 Oct 2018 22:24:45 +0200 Message-Id: <20181004202446.22905-21-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.19.0.rc2 In-Reply-To: <20181004202446.22905-1-daniel.vetter@ffwll.ch> References: <20181004202446.22905-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Sean Paul , Daniel Vetter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Motivated by review comments from Ville&Sean. Cc: Ville Syrjälä Cc: Sean Paul Signed-off-by: Daniel Vetter Reviewed-by: Ville Syrjälä Acked-by: Harry Wentland --- Documentation/gpu/todo.rst | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index 77c2b3c25565..5c9d86c962af 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -339,6 +339,16 @@ Some of these date from the very introduction of KMS in 2008 ... leftovers from older (never merged into upstream) KMS designs where modes where set using their ID, including support to add/remove modes. +- Make ->funcs and ->helper_private vtables optional. There's a bunch of empty + function tables in drivers, but before we can remove them we need to make sure + that all the users in helpers and drivers do correctly check for a NULL + vtable. + +- Cleanup up the various ->destroy callbacks. A lot of them just wrapt the + drm_*_cleanup implementations and can be removed. Some tack a kfree() at the + end, for which we could add drm_*_cleanup_kfree(). And then there's the (for + historical reasons) misnamed drm_primary_helper_destroy() function. + Better Testing ==============