[21/21] drm/doc: kerneldoc for quirk_addfb_prefer_xbgr_30bpp
diff mbox series

Message ID 20181004202446.22905-22-daniel.vetter@ffwll.ch
State New
Headers show
Series
  • atomic helper cleanup, take 2
Related show

Commit Message

Daniel Vetter Oct. 4, 2018, 8:24 p.m. UTC
Shuts up warning noise.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 include/drm/drm_mode_config.h | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Alexandru-Cosmin Gheorghe Oct. 24, 2018, 10:01 a.m. UTC | #1
Hi,

Daniel,

On Thu, Oct 04, 2018 at 10:24:46PM +0200, Daniel Vetter wrote:
> Shuts up warning noise.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

Reviewed-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>

> ---
>  include/drm/drm_mode_config.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h
> index 928e4172a0bb..d643d268693e 100644
> --- a/include/drm/drm_mode_config.h
> +++ b/include/drm/drm_mode_config.h
> @@ -809,6 +809,13 @@ struct drm_mode_config {
>  
>  	/* dumb ioctl parameters */
>  	uint32_t preferred_depth, prefer_shadow;
> +
> +	/**
> +	 * @quirk_addfb_prefer_xbgr_30bpp:
> +	 *
> +	 * Special hack for legacy ADDFB to keep nouveau userspace happy. Should
> +	 * only ever be set by the nouveau kernel driver.
> +	 */
>  	bool quirk_addfb_prefer_xbgr_30bpp;
>  
>  	/**
> -- 
> 2.19.0.rc2
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Daniel Vetter Oct. 24, 2018, 12:19 p.m. UTC | #2
On Wed, Oct 24, 2018 at 10:01:09AM +0000, Alexandru-Cosmin Gheorghe wrote:
> Hi,
> 
> Daniel,
> 
> On Thu, Oct 04, 2018 at 10:24:46PM +0200, Daniel Vetter wrote:
> > Shuts up warning noise.
> > 
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> 
> Reviewed-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>

Applied, thanks for review.
-Daniel

> 
> > ---
> >  include/drm/drm_mode_config.h | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h
> > index 928e4172a0bb..d643d268693e 100644
> > --- a/include/drm/drm_mode_config.h
> > +++ b/include/drm/drm_mode_config.h
> > @@ -809,6 +809,13 @@ struct drm_mode_config {
> >  
> >  	/* dumb ioctl parameters */
> >  	uint32_t preferred_depth, prefer_shadow;
> > +
> > +	/**
> > +	 * @quirk_addfb_prefer_xbgr_30bpp:
> > +	 *
> > +	 * Special hack for legacy ADDFB to keep nouveau userspace happy. Should
> > +	 * only ever be set by the nouveau kernel driver.
> > +	 */
> >  	bool quirk_addfb_prefer_xbgr_30bpp;
> >  
> >  	/**
> > -- 
> > 2.19.0.rc2
> > 
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 
> -- 
> Cheers,
> Alex G

Patch
diff mbox series

diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h
index 928e4172a0bb..d643d268693e 100644
--- a/include/drm/drm_mode_config.h
+++ b/include/drm/drm_mode_config.h
@@ -809,6 +809,13 @@  struct drm_mode_config {
 
 	/* dumb ioctl parameters */
 	uint32_t preferred_depth, prefer_shadow;
+
+	/**
+	 * @quirk_addfb_prefer_xbgr_30bpp:
+	 *
+	 * Special hack for legacy ADDFB to keep nouveau userspace happy. Should
+	 * only ever be set by the nouveau kernel driver.
+	 */
 	bool quirk_addfb_prefer_xbgr_30bpp;
 
 	/**