diff mbox series

firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake.

Message ID 20181004215949.30882-1-rodrigo.vivi@intel.com (mailing list archive)
State New, archived
Headers show
Series firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. | expand

Commit Message

Rodrigo Vivi Oct. 4, 2018, 9:59 p.m. UTC 
From: Anusha Srivatsa <anusha.srivatsa@intel.com>

Add missing MODULE_FIRMWARE while loading DMC ICL.

v2: Add Fixes tag. (Rodrigo)
v3: Rebase by Rodrigo after 7fe78985cd08 ("drm/i915/csr: restructure CSR
firmware definition macros")

Fixes: 4445930f1c4a ("firmware/dmc/icl: load v1.07 on icelake.")
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> (v2)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/i915/intel_csr.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Rodrigo Vivi Oct. 4, 2018, 10:35 p.m. UTC | #1 
On Thu, Oct 04, 2018 at 10:14:17PM -0000, Patchwork wrote:
> == Series Details ==
> 
> Series: firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (rev2)
> URL   : https://patchwork.freedesktop.org/series/49678/
> State : warning
> 
> == Summary ==
> 
> $ dim checkpatch origin/drm-tip
> 751aeeb3a90f firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake.
> -:9: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 7fe78985cd08 ("drm/i915/csr: restructure CSR firmware definition macros")'

I think we need to change dim cite to use exact same line as cp requires :/

> #9: 
> v3: Rebase by Rodrigo after 7fe78985cd08 ("drm/i915/csr: restructure CSR
> 
> total: 1 errors, 0 warnings, 0 checks, 7 lines checked
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
index e4e310b0ef78..fc7bd21fa586 100644
--- a/drivers/gpu/drm/i915/intel_csr.c
+++ b/drivers/gpu/drm/i915/intel_csr.c
@@ -37,6 +37,7 @@ 
 #define ICL_CSR_PATH			"i915/icl_dmc_ver1_07.bin"
 #define ICL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 7)
 #define ICL_CSR_MAX_FW_SIZE		0x6000
+MODULE_FIRMWARE(ICL_CSR_PATH);
 
 #define CNL_CSR_PATH			"i915/cnl_dmc_ver1_07.bin"
 #define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 7)