From patchwork Fri Oct 5 08:11:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10627563 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6271115E8 for ; Fri, 5 Oct 2018 08:12:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5B8FF29272 for ; Fri, 5 Oct 2018 08:12:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4F3B42926F; Fri, 5 Oct 2018 08:12:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 079092926D for ; Fri, 5 Oct 2018 08:12:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 86F956E779; Fri, 5 Oct 2018 08:12:31 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id 89D586E776 for ; Fri, 5 Oct 2018 08:12:29 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id j62-v6so10875769edd.7 for ; Fri, 05 Oct 2018 01:12:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Oo3nHQlD4aTw2ZdhpddlBpzAx8tOG1EIebutrMeAMHw=; b=RUxIIRjA17rBstZtZP78aKSaLWEXu4hPmVXGTAmKG5+YJl0utS55qUV02sH8pe5r8R n/9GQ11NK1jUmRNP3w9Yt6754Yj/HAfCpEx5uhxisKp0QuN1xrABzY6b3v5D9KLq0pLr St0EeCIn/sAV6435n2mLUkEH5UdZrcIPUuvnU25a1x8u9IwU2xAUN/r/IJKYJhQIK0Jt vO71NYSOjNqIDAaarZZ9P2O9PYXxYHZmsG0GJ7GRPfHdoTK4H3U7W5O5VTNlod2sMVNe IDC7XF0GQiFa+CT++z5ObC2QB0pNBb2tm1ftak94oHV9N5KYoK9PdKvKPv9pHl0EZKim fUDw== X-Gm-Message-State: ABuFfoio2aMYCcbHhgqVgxHTEwRXFxC5mk7ycEznfw9VrypDeAYgflJW J8N9sunjWlOxwFV8JmqHVHInr2C/MC0= X-Google-Smtp-Source: ACcGV62hh6nFAUDCVkC9610SCHnC/u/IaSYsGy+pt4g/N7X54nGtlQ2wM/j6Tcs846xo0NCemM2QAQ== X-Received: by 2002:a17:906:564d:: with SMTP id v13-v6mr9292663ejr.107.1538727147851; Fri, 05 Oct 2018 01:12:27 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id b12-v6sm1260087eje.36.2018.10.05.01.12.26 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Oct 2018 01:12:26 -0700 (PDT) From: Daniel Vetter To: Intel Graphics Development Date: Fri, 5 Oct 2018 10:11:50 +0200 Message-Id: <20181005081152.29482-20-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.19.0.rc2 In-Reply-To: <20181005081152.29482-1-daniel.vetter@ffwll.ch> References: <20181005081152.29482-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Subject: [Intel-gfx] [FOR CI 20/22] drm/todo: Add some cleanup tasks X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP Motivated by review comments from Ville&Sean. Cc: Ville Syrjälä Cc: Sean Paul Signed-off-by: Daniel Vetter --- Documentation/gpu/todo.rst | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index 77c2b3c25565..5c9d86c962af 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -339,6 +339,16 @@ Some of these date from the very introduction of KMS in 2008 ... leftovers from older (never merged into upstream) KMS designs where modes where set using their ID, including support to add/remove modes. +- Make ->funcs and ->helper_private vtables optional. There's a bunch of empty + function tables in drivers, but before we can remove them we need to make sure + that all the users in helpers and drivers do correctly check for a NULL + vtable. + +- Cleanup up the various ->destroy callbacks. A lot of them just wrapt the + drm_*_cleanup implementations and can be removed. Some tack a kfree() at the + end, for which we could add drm_*_cleanup_kfree(). And then there's the (for + historical reasons) misnamed drm_primary_helper_destroy() function. + Better Testing ==============