diff mbox series

NFS: Fix up a typo in nfs_dns_ent_put

Message ID 20181005142720.25280-1-trond.myklebust@hammerspace.com (mailing list archive)
State New, archived
Headers show
Series NFS: Fix up a typo in nfs_dns_ent_put | expand

Commit Message

Trond Myklebust Oct. 5, 2018, 2:27 p.m. UTC
call_rcu() needs to take a first argument of type (struct rcu_head *).

Fixes: fd497f1e40d9 ("NFS: Lockless DNS lookups")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
---
- Apologies for the screwup

 fs/nfs/dns_resolve.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

J. Bruce Fields Oct. 8, 2018, 2:23 p.m. UTC | #1
On Fri, Oct 05, 2018 at 10:27:20AM -0400, Trond Myklebust wrote:
> call_rcu() needs to take a first argument of type (struct rcu_head *).
> 
> Fixes: fd497f1e40d9 ("NFS: Lockless DNS lookups")
> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>

Thanks!  Applying.--b.

> ---
> - Apologies for the screwup
> 
>  fs/nfs/dns_resolve.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfs/dns_resolve.c b/fs/nfs/dns_resolve.c
> index e93a5dc07c8c..a7d3df85736d 100644
> --- a/fs/nfs/dns_resolve.c
> +++ b/fs/nfs/dns_resolve.c
> @@ -116,7 +116,7 @@ static void nfs_dns_ent_put(struct kref *ref)
>  	struct nfs_dns_ent *item;
>  
>  	item = container_of(ref, struct nfs_dns_ent, h.ref);
> -	call_rcu(item, nfs_dns_ent_free_rcu);
> +	call_rcu(&item->rcu_head, nfs_dns_ent_free_rcu);
>  }
>  
>  static struct cache_head *nfs_dns_ent_alloc(void)
> -- 
> 2.17.1
diff mbox series

Patch

diff --git a/fs/nfs/dns_resolve.c b/fs/nfs/dns_resolve.c
index e93a5dc07c8c..a7d3df85736d 100644
--- a/fs/nfs/dns_resolve.c
+++ b/fs/nfs/dns_resolve.c
@@ -116,7 +116,7 @@  static void nfs_dns_ent_put(struct kref *ref)
 	struct nfs_dns_ent *item;
 
 	item = container_of(ref, struct nfs_dns_ent, h.ref);
-	call_rcu(item, nfs_dns_ent_free_rcu);
+	call_rcu(&item->rcu_head, nfs_dns_ent_free_rcu);
 }
 
 static struct cache_head *nfs_dns_ent_alloc(void)