[v2,1/2] mfd: cros: add "base attached" MKBP switch definition
diff mbox series

Message ID 20181005184114.207503-1-dtor@chromium.org
State New, archived
Headers show
Series
  • [v2,1/2] mfd: cros: add "base attached" MKBP switch definition
Related show

Commit Message

Dmitry Torokhov Oct. 5, 2018, 6:41 p.m. UTC
This adds a "base attached" switch definition to the MKBP protocol that
is used by Whiskers driver to properly determine device state (clamshell
vs tablet mode).

Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
---

v2 changes: None

Lee, I was wondering if it would be OK for cros_ec_commands.h to be
merged through HID tree.


 include/linux/mfd/cros_ec_commands.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Lee Jones Oct. 9, 2018, 6:28 a.m. UTC | #1
On Fri, 05 Oct 2018, Dmitry Torokhov wrote:

> This adds a "base attached" switch definition to the MKBP protocol that
> is used by Whiskers driver to properly determine device state (clamshell
> vs tablet mode).
> 
> Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
> ---
> 
> v2 changes: None
> 
> Lee, I was wondering if it would be OK for cros_ec_commands.h to be
> merged through HID tree.

Yes, so long as it goes through in this merge-window.

Acked-by: Lee Jones <lee.jones@linaro.org>
Jiri Kosina Oct. 9, 2018, 8:41 a.m. UTC | #2
On Mon, 8 Oct 2018, Lee Jones wrote:

> > This adds a "base attached" switch definition to the MKBP protocol that
> > is used by Whiskers driver to properly determine device state (clamshell
> > vs tablet mode).
> > 
> > Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
> > ---
> > 
> > v2 changes: None
> > 
> > Lee, I was wondering if it would be OK for cros_ec_commands.h to be
> > merged through HID tree.
> 
> Yes, so long as it goes through in this merge-window.
> 
> Acked-by: Lee Jones <lee.jones@linaro.org>

Thanks; both patches now queued in hid.git#for-4.20/google

Patch
diff mbox series

diff --git a/include/linux/mfd/cros_ec_commands.h b/include/linux/mfd/cros_ec_commands.h
index 20ee71f10865..5fd0e429f472 100644
--- a/include/linux/mfd/cros_ec_commands.h
+++ b/include/linux/mfd/cros_ec_commands.h
@@ -2132,6 +2132,7 @@  struct ec_response_get_next_event_v1 {
 /* Switches */
 #define EC_MKBP_LID_OPEN	0
 #define EC_MKBP_TABLET_MODE	1
+#define EC_MKBP_BASE_ATTACHED	2
 
 /*****************************************************************************/
 /* Temperature sensor commands */