[nvdimm,4/6] nvdimm: Remove empty if statement
diff mbox series

Message ID 20181010233901.12228.21705.stgit@localhost.localdomain
State New, archived
Headers show
  • Label initialization time optimizations
Related show

Commit Message

Alexander Duyck Oct. 10, 2018, 11:39 p.m. UTC
This patch removes an empty statement from an if expression and promotes
the else statement to the if expression with the expression logic reversed.

I feel this is more readable as the empty statement can lead to issues if
any additional logic was ever added.

Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
 drivers/nvdimm/label.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff mbox series

diff --git a/drivers/nvdimm/label.c b/drivers/nvdimm/label.c
index bb813b8e8ace..43bad0d5bdb6 100644
--- a/drivers/nvdimm/label.c
+++ b/drivers/nvdimm/label.c
@@ -261,9 +261,8 @@  int nd_label_validate(struct nvdimm_drvdata *ndd)
 void nd_label_copy(struct nvdimm_drvdata *ndd, struct nd_namespace_index *dst,
 		struct nd_namespace_index *src)
-	if (dst && src)
-		/* pass */;
-	else
+	/* just exit if either destination or source is NULL */
+	if (!dst || !src)
 	memcpy(dst, src, sizeof_namespace_index(ndd));