| Message ID | 20181011222707.3631-2-mwilck@suse.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | christophe varoqui |
| Headers | show |
| Series | libmultipath: checkers overhaul | expand |
On Fri, Oct 12, 2018 at 12:26:47AM +0200, Martin Wilck wrote: > valgrind complained about this. > Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com> > Signed-off-by: Martin Wilck <mwilck@suse.com> > --- > libmultipath/discovery.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libmultipath/discovery.c b/libmultipath/discovery.c > index 873035e5..3550c3a7 100644 > --- a/libmultipath/discovery.c > +++ b/libmultipath/discovery.c > @@ -661,7 +661,7 @@ sysfs_set_session_tmo(struct multipath *mpp, struct path *pp) > } else { > snprintf(value, 11, "%u", mpp->fast_io_fail); > if (sysfs_attr_set_value(session_dev, "recovery_tmo", > - value, 11) <= 0) { > + value, strlen(value)) <= 0) { > condlog(3, "%s: Failed to set recovery_tmo, " > " error %d", pp->dev, errno); > } > @@ -693,7 +693,7 @@ sysfs_set_nexus_loss_tmo(struct multipath *mpp, struct path *pp) > if (mpp->dev_loss) { > snprintf(value, 11, "%u", mpp->dev_loss); > if (sysfs_attr_set_value(sas_dev, "I_T_nexus_loss_timeout", > - value, 11) <= 0) > + value, strlen(value)) <= 0) > condlog(3, "%s: failed to update " > "I_T Nexus loss timeout, error %d", > pp->dev, errno); > -- > 2.19.0 -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
diff --git a/libmultipath/discovery.c b/libmultipath/discovery.c index 873035e5..3550c3a7 100644 --- a/libmultipath/discovery.c +++ b/libmultipath/discovery.c @@ -661,7 +661,7 @@ sysfs_set_session_tmo(struct multipath *mpp, struct path *pp) } else { snprintf(value, 11, "%u", mpp->fast_io_fail); if (sysfs_attr_set_value(session_dev, "recovery_tmo", - value, 11) <= 0) { + value, strlen(value)) <= 0) { condlog(3, "%s: Failed to set recovery_tmo, " " error %d", pp->dev, errno); } @@ -693,7 +693,7 @@ sysfs_set_nexus_loss_tmo(struct multipath *mpp, struct path *pp) if (mpp->dev_loss) { snprintf(value, 11, "%u", mpp->dev_loss); if (sysfs_attr_set_value(sas_dev, "I_T_nexus_loss_timeout", - value, 11) <= 0) + value, strlen(value)) <= 0) condlog(3, "%s: failed to update " "I_T Nexus loss timeout, error %d", pp->dev, errno);
valgrind complained about this. Signed-off-by: Martin Wilck <mwilck@suse.com> --- libmultipath/discovery.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)