From patchwork Fri Oct 12 09:49:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Govind Singh X-Patchwork-Id: 10638241 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3E61B14E2 for ; Fri, 12 Oct 2018 09:50:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2DB0C2B61C for ; Fri, 12 Oct 2018 09:50:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 21BD02B69F; Fri, 12 Oct 2018 09:50:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 990B12B61C for ; Fri, 12 Oct 2018 09:50:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=us67cXRCumPwZ/QUL5MzIzXtkQmVL0iOI8dvt0Ivb+g=; b=qL1e6nVc8X4QI+ D6y+AVONIxQmJpsgoUdLA6hvpge9EY/BcqUnvcuq0T3Vc7Z1caJM0LPU/H4CkiSl28sOHwlNlZ2tj WTqeKtQdTENFmzQigPx+BJ0uX7RVrEnnobe3b2BkX8X8OwvK1a8gisr9SdiHqY82vVgehvVE9p1y0 Q5x6M+JueJJeSKuel6pYFCziBCpJep+QDIMrbgBSUylakPLqJ47NsfD3cNQM9EmDWy5SzPprHN/6v h2eb4uXTwoRDjodgAy2Vh0BSYxOOAaznd0h17ZX/31bh2ogiw3F8ClzyQYTrZJwFldOKp+zw5rstt IsoyU/tkxLW6rSfa3blQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gAu5I-0007Xp-VF; Fri, 12 Oct 2018 09:50:17 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gAu4v-0006nf-TF for ath10k@lists.infradead.org; Fri, 12 Oct 2018 09:49:55 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id DF27D60791; Fri, 12 Oct 2018 09:49:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1539337789; bh=zFFCV8dF/s0kQeAIi9JmB7de/s77Qvgt1PYPogvaYNI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nwvkVKI2JKM4Odp35v2D9EoEDl919WVnVuOyT5jsuoD0R5KXhpBD3Yz9n57ZgHsVV yyTdH44oXEbi//2d8WscZArDIKCcbB/o6pc4lR30/5Q63pWRs2m6MVcuI1thuYOVDt K39LjDHNnOr3B+kbCpjkmqPr9ekeZ/ou3rctoW8U= Received: from govinds-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: govinds@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id F0E49605A4; Fri, 12 Oct 2018 09:49:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1539337789; bh=zFFCV8dF/s0kQeAIi9JmB7de/s77Qvgt1PYPogvaYNI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nwvkVKI2JKM4Odp35v2D9EoEDl919WVnVuOyT5jsuoD0R5KXhpBD3Yz9n57ZgHsVV yyTdH44oXEbi//2d8WscZArDIKCcbB/o6pc4lR30/5Q63pWRs2m6MVcuI1thuYOVDt K39LjDHNnOr3B+kbCpjkmqPr9ekeZ/ou3rctoW8U= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org F0E49605A4 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=govinds@codeaurora.org From: Govind Singh To: ath10k@lists.infradead.org Subject: [PATCH v2 3/3] ath10k: Request credit report if flow control enabled on ep Date: Fri, 12 Oct 2018 15:19:38 +0530 Message-Id: <20181012094938.14734-4-govinds@codeaurora.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181012094938.14734-1-govinds@codeaurora.org> References: <20181012094938.14734-1-govinds@codeaurora.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181012_024953_991780_0173B6AA X-CRM114-Status: GOOD ( 12.15 ) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Govind Singh , linux-wireless@vger.kernel.org Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP FW credit flow control is enabled for only WMI ctrl service(CE3) but credit update is requested unconditionally on all HTC services as part of HTC tx in CE3/CE0/CE4. This is causing WOW failure as FW is not expecting credit report request on other end-points(CE0/CE4). Request credit report only on those endpoints where credit flow control is enabled. Testing: Tested on WCN3990 HW. Tested FW: WLAN.HL.2.0-01192-QCAHLSWMTPLZ-1. Signed-off-by: Govind Singh --- drivers/net/wireless/ath/ath10k/htc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/htc.c b/drivers/net/wireless/ath/ath10k/htc.c index 8902720b4e49..31f1a316be7c 100644 --- a/drivers/net/wireless/ath/ath10k/htc.c +++ b/drivers/net/wireless/ath/ath10k/htc.c @@ -87,7 +87,8 @@ static void ath10k_htc_prepare_tx_skb(struct ath10k_htc_ep *ep, hdr->eid = ep->eid; hdr->len = __cpu_to_le16(skb->len - sizeof(*hdr)); hdr->flags = 0; - hdr->flags |= ATH10K_HTC_FLAG_NEED_CREDIT_UPDATE; + if (ep->tx_credit_flow_enabled) + hdr->flags |= ATH10K_HTC_FLAG_NEED_CREDIT_UPDATE; spin_lock_bh(&ep->htc->tx_lock); hdr->seq_no = ep->seq_no++;