| Message ID | 20181013151707.32210-8-hch@lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/8] cpufreq: tegra186: don't pass GFP_DMA32 to dma_alloc_coherent | expand |
Le sam. 13 oct. 2018 à 17:18, Christoph Hellwig <hch@lst.de> a écrit : > > The DMA API does its own zone decisions based on the coherent_dma_mask. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Benjamin Gaignard <benjamin.gaignard@linaro.org> > --- > drivers/media/platform/sti/bdisp/bdisp-hw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/sti/bdisp/bdisp-hw.c b/drivers/media/platform/sti/bdisp/bdisp-hw.c > index 26d9fa7aeb5f..4372abbb5950 100644 > --- a/drivers/media/platform/sti/bdisp/bdisp-hw.c > +++ b/drivers/media/platform/sti/bdisp/bdisp-hw.c > @@ -510,7 +510,7 @@ int bdisp_hw_alloc_filters(struct device *dev) > > /* Allocate all the filters within a single memory page */ > size = (BDISP_HF_NB * NB_H_FILTER) + (BDISP_VF_NB * NB_V_FILTER); > - base = dma_alloc_attrs(dev, size, &paddr, GFP_KERNEL | GFP_DMA, > + base = dma_alloc_attrs(dev, size, &paddr, GFP_KERNEL, > DMA_ATTR_WRITE_COMBINE); > if (!base) > return -ENOMEM; > -- > 2.19.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Mon, Oct 15, 2018 at 11:12:55AM +0200, Benjamin Gaignard wrote: > Le sam. 13 oct. 2018 à 17:18, Christoph Hellwig <hch@lst.de> a écrit : > > > > The DMA API does its own zone decisions based on the coherent_dma_mask. > > > > Signed-off-by: Christoph Hellwig <hch@lst.de> > > Reviewed-by: Benjamin Gaignard <benjamin.gaignard@linaro.org> Can you pick it up through the media tree?
Le mer. 17 oct. 2018 à 09:20, Christoph Hellwig <hch@lst.de> a écrit : > > On Mon, Oct 15, 2018 at 11:12:55AM +0200, Benjamin Gaignard wrote: > > Le sam. 13 oct. 2018 à 17:18, Christoph Hellwig <hch@lst.de> a écrit : > > > > > > The DMA API does its own zone decisions based on the coherent_dma_mask. > > > > > > Signed-off-by: Christoph Hellwig <hch@lst.de> > > > > Reviewed-by: Benjamin Gaignard <benjamin.gaignard@linaro.org> > > Can you pick it up through the media tree? No but Mauros or Hans (in CC) can add it.
Em Thu, 18 Oct 2018 14:00:40 +0200 Benjamin Gaignard <benjamin.gaignard@linaro.org> escreveu: > Le mer. 17 oct. 2018 à 09:20, Christoph Hellwig <hch@lst.de> a écrit : > > > > On Mon, Oct 15, 2018 at 11:12:55AM +0200, Benjamin Gaignard wrote: > > > Le sam. 13 oct. 2018 à 17:18, Christoph Hellwig <hch@lst.de> a écrit : > > > > > > > > The DMA API does its own zone decisions based on the coherent_dma_mask. > > > > > > > > Signed-off-by: Christoph Hellwig <hch@lst.de> > > > > > > Reviewed-by: Benjamin Gaignard <benjamin.gaignard@linaro.org> > > > > Can you pick it up through the media tree? > > No but Mauros or Hans (in CC) can add it. I'm adding it. Sorry for the delay. All those trips for MS/KS made harder to handle it earlier. Thanks, Mauro
diff --git a/drivers/media/platform/sti/bdisp/bdisp-hw.c b/drivers/media/platform/sti/bdisp/bdisp-hw.c index 26d9fa7aeb5f..4372abbb5950 100644 --- a/drivers/media/platform/sti/bdisp/bdisp-hw.c +++ b/drivers/media/platform/sti/bdisp/bdisp-hw.c @@ -510,7 +510,7 @@ int bdisp_hw_alloc_filters(struct device *dev) /* Allocate all the filters within a single memory page */ size = (BDISP_HF_NB * NB_H_FILTER) + (BDISP_VF_NB * NB_V_FILTER); - base = dma_alloc_attrs(dev, size, &paddr, GFP_KERNEL | GFP_DMA, + base = dma_alloc_attrs(dev, size, &paddr, GFP_KERNEL, DMA_ATTR_WRITE_COMBINE); if (!base) return -ENOMEM;
The DMA API does its own zone decisions based on the coherent_dma_mask. Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/media/platform/sti/bdisp/bdisp-hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)