| Message ID | 20181016073940.26797-1-christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3419348a97bcc256238101129d69b600ceb5cc70 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wlcore: Fix the return value in case of error in 'wlcore_vendor_cmd_smart_config_start()' | expand |
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > We return 0 unconditionally at the end of > 'wlcore_vendor_cmd_smart_config_start()'. > However, 'ret' is set to some error codes in several error handling paths > and we already return some error codes at the beginning of the function. > > Return 'ret' instead to propagate the error code. > > Fixes: 80ff8063e87c ("wlcore: handle smart config vendor commands") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Patch applied to wireless-drivers-next.git, thanks. 3419348a97bc wlcore: Fix the return value in case of error in 'wlcore_vendor_cmd_smart_config_start()'
diff --git a/drivers/net/wireless/ti/wlcore/vendor_cmd.c b/drivers/net/wireless/ti/wlcore/vendor_cmd.c index dbe78d8491ef..7f34ec077ee5 100644 --- a/drivers/net/wireless/ti/wlcore/vendor_cmd.c +++ b/drivers/net/wireless/ti/wlcore/vendor_cmd.c @@ -70,7 +70,7 @@ wlcore_vendor_cmd_smart_config_start(struct wiphy *wiphy, out: mutex_unlock(&wl->mutex); - return 0; + return ret; } static int
We return 0 unconditionally at the end of 'wlcore_vendor_cmd_smart_config_start()'. However, 'ret' is set to some error codes in several error handling paths and we already return some error codes at the beginning of the function. Return 'ret' instead to propagate the error code. Fixes: 80ff8063e87c ("wlcore: handle smart config vendor commands") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/net/wireless/ti/wlcore/vendor_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)