[-next] drivers/video/fbdev: remove set but not used variable 'size'
diff mbox series

Message ID 1539676794-40133-1-git-send-email-yuehaibing@huawei.com
State New
Headers show
Series
  • [-next] drivers/video/fbdev: remove set but not used variable 'size'
Related show

Commit Message

YueHaibing Oct. 16, 2018, 7:59 a.m. UTC
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/video/fbdev/chipsfb.c: In function 'chipsfb_pci_init':
drivers/video/fbdev/chipsfb.c:352:22: warning:
 variable 'size' set but not used [-Wunused-but-set-variable]

It not used any more after commit
8c8709334cec ("[PATCH] ppc32: Remove CONFIG_PMAC_PBOOK")

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/video/fbdev/chipsfb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Bartlomiej Zolnierkiewicz Feb. 8, 2019, 5 p.m. UTC | #1
On 10/17/2018 01:52 AM, Michael Ellerman wrote:
> YueHaibing <yuehaibing@huawei.com> writes:
> 
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/video/fbdev/chipsfb.c: In function 'chipsfb_pci_init':
>> drivers/video/fbdev/chipsfb.c:352:22: warning:
>>  variable 'size' set but not used [-Wunused-but-set-variable]
>>
>> It not used any more after commit
>> 8c8709334cec ("[PATCH] ppc32: Remove CONFIG_PMAC_PBOOK")
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>>  drivers/video/fbdev/chipsfb.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> Looks good, thanks.
> 
> Should I merge this? Or otherwise:
> 
> Acked-by: Michael Ellerman <mpe@ellerman.id.au>

I've queued the patch to fbdev tree for v5.1 w/ slightly modified patch
summary ("fbdev: chipsfb: ...") add patch description (use Fixes: tag),
thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Michael Ellerman Feb. 11, 2019, 2:59 a.m. UTC | #2
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> writes:
> On 10/17/2018 01:52 AM, Michael Ellerman wrote:
>> YueHaibing <yuehaibing@huawei.com> writes:
>> 
>>> Fixes gcc '-Wunused-but-set-variable' warning:
>>>
>>> drivers/video/fbdev/chipsfb.c: In function 'chipsfb_pci_init':
>>> drivers/video/fbdev/chipsfb.c:352:22: warning:
>>>  variable 'size' set but not used [-Wunused-but-set-variable]
>>>
>>> It not used any more after commit
>>> 8c8709334cec ("[PATCH] ppc32: Remove CONFIG_PMAC_PBOOK")
>>>
>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>>> ---
>>>  drivers/video/fbdev/chipsfb.c | 3 +--
>>>  1 file changed, 1 insertion(+), 2 deletions(-)
>> 
>> Looks good, thanks.
>> 
>> Should I merge this? Or otherwise:
>> 
>> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
>
> I've queued the patch to fbdev tree for v5.1 w/ slightly modified patch
> summary ("fbdev: chipsfb: ...") add patch description (use Fixes: tag),
> thanks.

Thanks.

cheers

Patch
diff mbox series

diff --git a/drivers/video/fbdev/chipsfb.c b/drivers/video/fbdev/chipsfb.c
index 40182ed..ca549e1 100644
--- a/drivers/video/fbdev/chipsfb.c
+++ b/drivers/video/fbdev/chipsfb.c
@@ -349,7 +349,7 @@  static void init_chips(struct fb_info *p, unsigned long addr)
 static int chipsfb_pci_init(struct pci_dev *dp, const struct pci_device_id *ent)
 {
 	struct fb_info *p;
-	unsigned long addr, size;
+	unsigned long addr;
 	unsigned short cmd;
 	int rc = -ENODEV;
 
@@ -361,7 +361,6 @@  static int chipsfb_pci_init(struct pci_dev *dp, const struct pci_device_id *ent)
 	if ((dp->resource[0].flags & IORESOURCE_MEM) == 0)
 		goto err_disable;
 	addr = pci_resource_start(dp, 0);
-	size = pci_resource_len(dp, 0);
 	if (addr == 0)
 		goto err_disable;