[2/2,v2] nfs: remove redundant call to nfs_context_set_write_error()
diff mbox series

Message ID 0963d6fa00685c2810cd1d5996eb4853a2949057.1539889215.git.bcodding@redhat.com
State New
Headers show
  • [1/2,v2] nfs: Fix a missed page unlock after pg_doio()
Related show

Commit Message

Benjamin Coddington Oct. 18, 2018, 7:01 p.m. UTC
We don't need to call this in the direct, read, or pnfs resend paths and
the only other caller is the write path in nfs_page_async_flush() which
already checks and sets the pg_error on the context.

Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
 fs/nfs/pagelist.c | 4 ----
 1 file changed, 4 deletions(-)

diff mbox series

diff --git a/fs/nfs/pagelist.c b/fs/nfs/pagelist.c
index 7e6425791388..a592abb62873 100644
--- a/fs/nfs/pagelist.c
+++ b/fs/nfs/pagelist.c
@@ -1174,10 +1174,6 @@  int nfs_pageio_add_request(struct nfs_pageio_descriptor *desc,
 	return 1;
-	/* remember fatal errors */
-	if (nfs_error_is_fatal(desc->pg_error))
-		nfs_context_set_write_error(req->wb_context,
-						desc->pg_error);
 	return 0;