diff mbox series

drm/edid: Quirk Sensics, 3 Glasses HMD as non-desktop.

Message ID 20181020194229.24861-1-ryan.pavlik@collabora.com (mailing list archive)
State New, archived
Headers show
Series drm/edid: Quirk Sensics, 3 Glasses HMD as non-desktop. | expand

Commit Message

Ryan Pavlik Oct. 20, 2018, 7:42 p.m. UTC
Two of the EDID vendor/product pairs are used across a variety of
Sensics products, as well as the OSVR HDK and HDK 2.

The third is for the "3 Glasses" brand "D3" HMD.

Signed-off-by: Ryan Pavlik <ryan.pavlik@collabora.com>
---
 drivers/gpu/drm/drm_edid.c | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Philipp Zabel Dec. 3, 2018, 3:41 p.m. UTC | #1
On Sat, 2018-10-20 at 20:42 +0100, Ryan Pavlik wrote:
> Two of the EDID vendor/product pairs are used across a variety of
> Sensics products, as well as the OSVR HDK and HDK 2.
> 
> The third is for the "3 Glasses" brand "D3" HMD.
> 
> Signed-off-by: Ryan Pavlik <ryan.pavlik@collabora.com>
> ---
>  drivers/gpu/drm/drm_edid.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index 3c9fc9964..68b7bc007 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -187,6 +187,15 @@ static const struct edid_quirk {
>  
>  	/* Sony PlayStation VR Headset */
>  	{ "SNY", 0x0704, EDID_QUIRK_NON_DESKTOP },
> +
> +	/* Sensics VR Headsets */
> +	{ "SEN", 0x1019, EDID_QUIRK_NON_DESKTOP },
> +
> +	/* Sensics, OSVR HDK and HDK2 VR Headsets */
> +	{ "SVR", 0x1019, EDID_QUIRK_NON_DESKTOP },

This looks good to me. These are indeed HMDs, and I can confirm
"SVR"/0x1019 is correct for the HDK2.

> +	/* 3Glasses D3 VR Headset */
> +	{ "TSB", 0x8888, EDID_QUIRK_NON_DESKTOP },

This looks a lot like the vendor has not bothered to set a custom
vendor/product id in the Toshiba HDMI-to-DSI bridge chip. I would
argue that it is safer to mark such displays as non-desktop, though.

>  };
>  
>  /*

Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>

Can we take this into drm-misc?

regards
Philipp
diff mbox series

Patch

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 3c9fc9964..68b7bc007 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -187,6 +187,15 @@  static const struct edid_quirk {
 
 	/* Sony PlayStation VR Headset */
 	{ "SNY", 0x0704, EDID_QUIRK_NON_DESKTOP },
+
+	/* Sensics VR Headsets */
+	{ "SEN", 0x1019, EDID_QUIRK_NON_DESKTOP },
+
+	/* Sensics, OSVR HDK and HDK2 VR Headsets */
+	{ "SVR", 0x1019, EDID_QUIRK_NON_DESKTOP },
+
+	/* 3Glasses D3 VR Headset */
+	{ "TSB", 0x8888, EDID_QUIRK_NON_DESKTOP },
 };
 
 /*