| Message ID | 1540141725-13047-2-git-send-email-aaron.ma@canonical.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] usb: xhci: fix uninitialized completion when USB3 port got wrong status | expand |
On Mon, Oct 22, 2018 at 01:08:45AM +0800, Aaron Ma wrote: > This definition is used by msecs_to_jiffies in milliseconds. > According to the comments, max rexit timeout should be 20ms. > Align with the comments to properly calculate the delay. > > Verified on Sunrise Point-LP and Cannon Lake. > > Signed-off-by: Aaron Ma <aaron.ma@canonical.com> > --- > drivers/usb/host/xhci.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h > index 6230a578324c..30225c53be1c 100644 > --- a/drivers/usb/host/xhci.h > +++ b/drivers/usb/host/xhci.h > @@ -1678,7 +1678,7 @@ struct xhci_bus_state { > * It can take up to 20 ms to transition from RExit to U0 on the > * Intel Lynx Point LP xHCI host. > */ > -#define XHCI_MAX_REXIT_TIMEOUT (20 * 1000) > +#define XHCI_MAX_REXIT_TIMEOUT 20 Can we put the units in the #define itself so that this will be more obvious in the future? Like XHCI_MAX_REXIT_TIMEOUT_MS? thanks, greg k-h
On 10/22/18 2:21 AM, Greg KH wrote: > Can we put the units in the #define itself so that this will be more > obvious in the future? Like XHCI_MAX_REXIT_TIMEOUT_MS? If no other concerns about these 2 patches, I will send V2 of 2nd patch to follow your advice. Thanks, Aaron
diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h index 6230a578324c..30225c53be1c 100644 --- a/drivers/usb/host/xhci.h +++ b/drivers/usb/host/xhci.h @@ -1678,7 +1678,7 @@ struct xhci_bus_state { * It can take up to 20 ms to transition from RExit to U0 on the * Intel Lynx Point LP xHCI host. */ -#define XHCI_MAX_REXIT_TIMEOUT (20 * 1000) +#define XHCI_MAX_REXIT_TIMEOUT 20 static inline unsigned int hcd_index(struct usb_hcd *hcd) {
This definition is used by msecs_to_jiffies in milliseconds. According to the comments, max rexit timeout should be 20ms. Align with the comments to properly calculate the delay. Verified on Sunrise Point-LP and Cannon Lake. Signed-off-by: Aaron Ma <aaron.ma@canonical.com> --- drivers/usb/host/xhci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)