| Message ID | 20181022015528.141238-1-dstolee@microsoft.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RFC] revision.c: use new algorithm in A..B case | expand |
diff --git a/revision.c b/revision.c index 472f3994e3..8e5656f7b4 100644 --- a/revision.c +++ b/revision.c @@ -278,10 +278,8 @@ static struct commit *handle_commit(struct rev_info *revs, if (parse_commit(commit) < 0) die("unable to parse commit %s", name); - if (flags & UNINTERESTING) { + if (flags & UNINTERESTING) mark_parents_uninteresting(commit); - revs->limited = 1; - } if (revs->sources) { char **slot = revision_sources_at(revs->sources, commit);
Signed-off-by: Derrick Stolee <dstolee@microsoft.com> --- I just wanted to mention that in order to use the new logic for 'git log --topo-order A..B', we just need the following patch. It is an extra time that sets 'revs->limited' to 1, triggering the old logic. You can use this for comparison purposes, but I'm not ready to do this until more performance testing is ready in this case. Since these comparison commands are already pretty fast when the diff is small, there is less urgency to improve performance here. Thanks, -Stolee revision.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)