diff mbox series

[1/5] drm/i915: ddi_clock_get sort platforms newer-to-older.

Message ID 20181022171526.15641-1-rodrigo.vivi@intel.com (mailing list archive)
State New, archived
Headers show
Series [1/5] drm/i915: ddi_clock_get sort platforms newer-to-older. | expand

Commit Message

Rodrigo Vivi Oct. 22, 2018, 5:15 p.m. UTC
No functional change.

Just sorting this "if" block from newer to older platform.

v2: Invert gen9_bc and gen9_lp (Ville)

Cc: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_ddi.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

Comments

Rodrigo Vivi Oct. 22, 2018, 9:51 p.m. UTC | #1
On Mon, Oct 22, 2018 at 09:26:42PM +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: series starting with [1/5] drm/i915: ddi_clock_get sort platforms newer-to-older.
> URL   : https://patchwork.freedesktop.org/series/51340/
> State : success
> 
> == Summary ==
> 
> = CI Bug Log - changes from CI_DRM_5017_full -> Patchwork_10529_full =
> 
> == Summary - SUCCESS ==
> 
>   No regressions found.

pushed to dinq. thanks for reviews and ideas.

> 
>   
> 
> == Known issues ==
> 
>   Here are the changes found in Patchwork_10529_full that come from known issues:
> 
>   === IGT changes ===
> 
>     ==== Issues hit ====
> 
>     igt@gem_sync@basic-each:
>       shard-snb:          PASS -> INCOMPLETE (fdo#105411)
> 
>     igt@gem_userptr_blits@readonly-unsync:
>       shard-skl:          NOTRUN -> INCOMPLETE (fdo#108074)
> 
>     igt@gem_workarounds@suspend-resume:
>       shard-kbl:          PASS -> INCOMPLETE (fdo#103665)
> 
>     igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
>       shard-skl:          NOTRUN -> DMESG-WARN (fdo#107956)
> 
>     igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
>       shard-glk:          PASS -> FAIL (fdo#108145)
> 
>     igt@kms_cursor_crc@cursor-256x256-sliding:
>       shard-glk:          PASS -> FAIL (fdo#103232) +1
> 
>     igt@kms_draw_crc@draw-method-rgb565-blt-xtiled:
>       shard-skl:          PASS -> FAIL (fdo#103184)
> 
>     igt@kms_flip_tiling@flip-yf-tiled:
>       shard-skl:          NOTRUN -> FAIL (fdo#108145) +1
> 
>     igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
>       shard-apl:          PASS -> FAIL (fdo#103167) +1
> 
>     igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary:
>       shard-glk:          PASS -> DMESG-WARN (fdo#105763, fdo#106538) +2
> 
>     igt@kms_plane@plane-position-covered-pipe-a-planes:
>       shard-glk:          PASS -> FAIL (fdo#103166)
> 
>     igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
>       shard-skl:          NOTRUN -> FAIL (fdo#107815, fdo#108145)
> 
>     igt@pm_rps@reset:
>       shard-skl:          PASS -> FAIL (fdo#102250)
> 
>     igt@syncobj_wait@wait-for-submit-complex:
>       shard-skl:          NOTRUN -> INCOMPLETE (fdo#108490)
> 
>     
>     ==== Possible fixes ====
> 
>     igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
>       shard-glk:          DMESG-WARN (fdo#107956) -> PASS
> 
>     igt@kms_cursor_crc@cursor-64x21-onscreen:
>       shard-glk:          FAIL (fdo#103232) -> PASS
> 
>     igt@kms_flip@flip-vs-expired-vblank-interruptible:
>       shard-apl:          FAIL (fdo#105363, fdo#102887) -> PASS
> 
>     igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
>       shard-apl:          FAIL (fdo#103167) -> PASS +1
> 
>     igt@kms_plane@plane-position-covered-pipe-a-planes:
>       shard-apl:          FAIL (fdo#103166) -> PASS +1
> 
>     igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
>       shard-apl:          FAIL (fdo#108145) -> PASS
> 
>     igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
>       shard-glk:          FAIL (fdo#103166) -> PASS
> 
>     igt@kms_setmode@basic:
>       shard-apl:          FAIL (fdo#99912) -> PASS
> 
>     igt@kms_vblank@pipe-b-ts-continuation-dpms-rpm:
>       shard-glk:          DMESG-WARN (fdo#105763, fdo#106538) -> PASS
> 
>     igt@pm_rps@reset:
>       shard-apl:          FAIL (fdo#102250) -> PASS
> 
>     
>     ==== Warnings ====
> 
>     igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
>       shard-skl:          FAIL (fdo#103166) -> INCOMPLETE (fdo#104108)
> 
>     
>   fdo#102250 https://bugs.freedesktop.org/show_bug.cgi?id=102250
>   fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
>   fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
>   fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
>   fdo#103184 https://bugs.freedesktop.org/show_bug.cgi?id=103184
>   fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
>   fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
>   fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
>   fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
>   fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
>   fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
>   fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
>   fdo#107815 https://bugs.freedesktop.org/show_bug.cgi?id=107815
>   fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
>   fdo#108074 https://bugs.freedesktop.org/show_bug.cgi?id=108074
>   fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
>   fdo#108490 https://bugs.freedesktop.org/show_bug.cgi?id=108490
>   fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
> 
> 
> == Participating hosts (6 -> 6) ==
> 
>   No changes in participating hosts
> 
> 
> == Build changes ==
> 
>     * Linux: CI_DRM_5017 -> Patchwork_10529
> 
>   CI_DRM_5017: 9510f8e44127260f92b5b6c3127aafa22b15f741 @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_4685: 78619fde4008424c472906041edb1d204e014f7c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   Patchwork_10529: 281f4e6cccb36e3cb854f5e3fe3b38ab9506fe1b @ git://anongit.freedesktop.org/gfx-ci/linux
>   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10529/shards.html
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index 6b9742baa5f2..e4f8e738c47b 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -1737,16 +1737,16 @@  static void intel_ddi_clock_get(struct intel_encoder *encoder,
 {
 	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
 
-	if (INTEL_GEN(dev_priv) <= 8)
-		hsw_ddi_clock_get(encoder, pipe_config);
-	else if (IS_GEN9_BC(dev_priv))
-		skl_ddi_clock_get(encoder, pipe_config);
-	else if (IS_GEN9_LP(dev_priv))
-		bxt_ddi_clock_get(encoder, pipe_config);
+	if (IS_ICELAKE(dev_priv))
+		icl_ddi_clock_get(encoder, pipe_config);
 	else if (IS_CANNONLAKE(dev_priv))
 		cnl_ddi_clock_get(encoder, pipe_config);
-	else if (IS_ICELAKE(dev_priv))
-		icl_ddi_clock_get(encoder, pipe_config);
+	else if (IS_GEN9_LP(dev_priv))
+		bxt_ddi_clock_get(encoder, pipe_config);
+	else if (IS_GEN9_BC(dev_priv))
+		skl_ddi_clock_get(encoder, pipe_config);
+	else if (INTEL_GEN(dev_priv) <= 8)
+		hsw_ddi_clock_get(encoder, pipe_config);
 }
 
 void intel_ddi_set_pipe_settings(const struct intel_crtc_state *crtc_state)