tools/power turbostat: Correct the abbrevation for Package C10
diff mbox series

Message ID 20181023180136.39435-1-azhar.shaikh@intel.com
State Rejected, archived
Delegated to: Len Brown
Headers show
Series
  • tools/power turbostat: Correct the abbrevation for Package C10
Related show

Commit Message

Azhar Shaikh Oct. 23, 2018, 6:01 p.m. UTC
Change Pk%pc10 to Pkg%pc10 to keep it uniform with remaining
pakcage C states abbrevations.

Signed-off-by: Azhar Shaikh <azhar.shaikh@intel.com>
---
 tools/power/x86/turbostat/turbostat.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Len Brown March 21, 2019, 3:18 a.m. UTC | #1
This has come up before.
Yeah, it looks like a typo.
But no, it was actually intentional -- tab delimited columns work
better when items fit within 7 characters....

(turbostat was originally written before pc10 existed:-)

So to make them consistent, we'd actually have to do something like
change "Pkg" to "Pk" in the other columns...

-Len

On Tue, Oct 23, 2018 at 2:01 PM Azhar Shaikh <azhar.shaikh@intel.com> wrote:
>
> Change Pk%pc10 to Pkg%pc10 to keep it uniform with remaining
> pakcage C states abbrevations.
>
> Signed-off-by: Azhar Shaikh <azhar.shaikh@intel.com>
> ---
>  tools/power/x86/turbostat/turbostat.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c
> index 328f62e6ea02..753c5a5232d6 100644
> --- a/tools/power/x86/turbostat/turbostat.c
> +++ b/tools/power/x86/turbostat/turbostat.c
> @@ -417,7 +417,7 @@ struct msr_counter bic[] = {
>         { 0x0, "Pkg%pc7" },
>         { 0x0, "Pkg%pc8" },
>         { 0x0, "Pkg%pc9" },
> -       { 0x0, "Pk%pc10" },
> +       { 0x0, "Pkg%pc10" },
>         { 0x0, "CPU%LPI" },
>         { 0x0, "SYS%LPI" },
>         { 0x0, "PkgWatt" },
> @@ -723,7 +723,7 @@ void print_header(char *delim)
>         if (DO_BIC(BIC_Pkgpc9))
>                 outp += sprintf(outp, "%sPkg%%pc9", (printed++ ? delim : ""));
>         if (DO_BIC(BIC_Pkgpc10))
> -               outp += sprintf(outp, "%sPk%%pc10", (printed++ ? delim : ""));
> +               outp += sprintf(outp, "%sPkg%%pc10", (printed++ ? delim : ""));
>         if (DO_BIC(BIC_CPU_LPI))
>                 outp += sprintf(outp, "%sCPU%%LPI", (printed++ ? delim : ""));
>         if (DO_BIC(BIC_SYS_LPI))
> --
> 2.19.0
>

Patch
diff mbox series

diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c
index 328f62e6ea02..753c5a5232d6 100644
--- a/tools/power/x86/turbostat/turbostat.c
+++ b/tools/power/x86/turbostat/turbostat.c
@@ -417,7 +417,7 @@  struct msr_counter bic[] = {
 	{ 0x0, "Pkg%pc7" },
 	{ 0x0, "Pkg%pc8" },
 	{ 0x0, "Pkg%pc9" },
-	{ 0x0, "Pk%pc10" },
+	{ 0x0, "Pkg%pc10" },
 	{ 0x0, "CPU%LPI" },
 	{ 0x0, "SYS%LPI" },
 	{ 0x0, "PkgWatt" },
@@ -723,7 +723,7 @@  void print_header(char *delim)
 	if (DO_BIC(BIC_Pkgpc9))
 		outp += sprintf(outp, "%sPkg%%pc9", (printed++ ? delim : ""));
 	if (DO_BIC(BIC_Pkgpc10))
-		outp += sprintf(outp, "%sPk%%pc10", (printed++ ? delim : ""));
+		outp += sprintf(outp, "%sPkg%%pc10", (printed++ ? delim : ""));
 	if (DO_BIC(BIC_CPU_LPI))
 		outp += sprintf(outp, "%sCPU%%LPI", (printed++ ? delim : ""));
 	if (DO_BIC(BIC_SYS_LPI))