| Message ID | 20181024040354.24879-3-leobras.c@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Adds -Wshadow on KBUILD_HOSTCFLAGS and fix warnings | expand |
On Wed, Oct 24, 2018 at 1:04 PM Leonardo Bras <leobras.c@gmail.com> wrote: > > Removes an unnecessary shadowed local variable (start). > It was used only once, with the same value it was started before > the if block. > > Signed-off-by: Leonardo Bras <leobras.c@gmail.com> Applied to linux-kbuild with some fixups in the subject. Please do not add a period to the end of the subject. > --- > scripts/asn1_compiler.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/asn1_compiler.c b/scripts/asn1_compiler.c > index c146020fc783..1b28787028d3 100644 > --- a/scripts/asn1_compiler.c > +++ b/scripts/asn1_compiler.c > @@ -413,7 +413,7 @@ static void tokenise(char *buffer, char *end) > > /* Handle string tokens */ > if (isalpha(*p)) { > - const char **dir, *start = p; > + const char **dir; > > /* Can be a directive, type name or element > * name. Find the end of the name. > -- > 2.19.1 >
Sorry, I will take care next time. Thank you, Leonardo Bras On Sun, Oct 28, 2018 at 1:37 PM Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > > On Wed, Oct 24, 2018 at 1:04 PM Leonardo Bras <leobras.c@gmail.com> wrote: > > > > Removes an unnecessary shadowed local variable (start). > > It was used only once, with the same value it was started before > > the if block. > > > > Signed-off-by: Leonardo Bras <leobras.c@gmail.com> > > > > Applied to linux-kbuild > with some fixups in the subject. > > Please do not add a period to the end of the subject. > > > > > > > > --- > > scripts/asn1_compiler.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/scripts/asn1_compiler.c b/scripts/asn1_compiler.c > > index c146020fc783..1b28787028d3 100644 > > --- a/scripts/asn1_compiler.c > > +++ b/scripts/asn1_compiler.c > > @@ -413,7 +413,7 @@ static void tokenise(char *buffer, char *end) > > > > /* Handle string tokens */ > > if (isalpha(*p)) { > > - const char **dir, *start = p; > > + const char **dir; > > > > /* Can be a directive, type name or element > > * name. Find the end of the name. > > -- > > 2.19.1 > > > > > -- > Best Regards > Masahiro Yamada
diff --git a/scripts/asn1_compiler.c b/scripts/asn1_compiler.c index c146020fc783..1b28787028d3 100644 --- a/scripts/asn1_compiler.c +++ b/scripts/asn1_compiler.c @@ -413,7 +413,7 @@ static void tokenise(char *buffer, char *end) /* Handle string tokens */ if (isalpha(*p)) { - const char **dir, *start = p; + const char **dir; /* Can be a directive, type name or element * name. Find the end of the name.
Removes an unnecessary shadowed local variable (start). It was used only once, with the same value it was started before the if block. Signed-off-by: Leonardo Bras <leobras.c@gmail.com> --- scripts/asn1_compiler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)