| Message ID | 20181024143307.25372-1-msys.mizuma@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | check: skip parsing if the file is not shell script. | expand |
On Wed, Oct 24, 2018 at 10:33:07AM -0400, Masayoshi Mizuma wrote: > From: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com> > > If we run tests using '*', for example './check xfs/*', we will > get following error messages. This patch introduces to avoid > the messages. > > ./check xfs/* > xfs/001.out - unknown test, ignored > xfs/002.out - unknown test, ignored > xfs/003.out - unknown test, ignored > xfs/004.out - unknown test, ignored > ... Hmm, that's just not the recommended way to run tests. Not all tests are valid (yes, there're broken tests) and sometimes we may forget to add x permission on a test (though I have a local script to catch that, but it did happen before). Please either use a more precise pattern to match the tests you want to run, or even better, run tests by specifying the groups, e.g. ./check -g xfs/log to run all tests in 'log' group in 'xfs' directory. Thanks, Eryu > > Signed-off-by: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com> > --- > check | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/check b/check > index f3c8021d..96cb222f 100755 > --- a/check > +++ b/check > @@ -339,6 +339,10 @@ if $have_test_arg; then > test_dir=`dirname $t` > test_dir=${test_dir#$SRC_DIR/*} > test_name=`basename $t` > + if ! file -bi $SRC_DIR/$test_dir/$test_name | \ > + egrep -q 'text/x-shellscript'; then > + continue > + fi > group_file=$SRC_DIR/$test_dir/group > > if egrep -q "^$test_name" $group_file; then > -- > 2.18.0 >
On Sun, Oct 28, 2018 at 09:44:52PM +0800, Eryu Guan wrote: > On Wed, Oct 24, 2018 at 10:33:07AM -0400, Masayoshi Mizuma wrote: > > From: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com> > > > > If we run tests using '*', for example './check xfs/*', we will > > get following error messages. This patch introduces to avoid > > the messages. > > > > ./check xfs/* > > xfs/001.out - unknown test, ignored > > xfs/002.out - unknown test, ignored > > xfs/003.out - unknown test, ignored > > xfs/004.out - unknown test, ignored > > ... > > Hmm, that's just not the recommended way to run tests. Not all tests are > valid (yes, there're broken tests) and sometimes we may forget to add x > permission on a test (though I have a local script to catch that, but it > did happen before). Got it, thanks! > Please either use a more precise pattern to match the tests you want to > run, or even better, run tests by specifying the groups, e.g. > > ./check -g xfs/log > > to run all tests in 'log' group in 'xfs' directory. What is the better way to run all the tests? Should I set the all groups? look like check -g xfs/auto,xfs/ioctl,...? Thanks, Masa
diff --git a/check b/check index f3c8021d..96cb222f 100755 --- a/check +++ b/check @@ -339,6 +339,10 @@ if $have_test_arg; then test_dir=`dirname $t` test_dir=${test_dir#$SRC_DIR/*} test_name=`basename $t` + if ! file -bi $SRC_DIR/$test_dir/$test_name | \ + egrep -q 'text/x-shellscript'; then + continue + fi group_file=$SRC_DIR/$test_dir/group if egrep -q "^$test_name" $group_file; then