[v7,2/6] soc/fsl/guts: Add definition for LX2160A
diff mbox series

Message ID 1540759926-3641-3-git-send-email-vabhav.sharma@nxp.com
State New
Headers show
Series
  • arm64: dts: NXP: add basic dts file for LX2160A SoC
Related show

Commit Message

Vabhav Sharma Oct. 29, 2018, 8:57 a.m. UTC
Adding compatible string "lx2160a-dcfg" to
initialize guts driver for lx2160 and SoC die
attribute definition for LX2160A

Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
Acked-by: Li Yang <leoyang.li@nxp.com>
---
 drivers/soc/fsl/guts.c | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Poonam Aggrwal Oct. 29, 2018, 11:09 a.m. UTC | #1
> -----Original Message-----
> From: linux-arm-kernel [mailto:linux-arm-kernel-bounces@lists.infradead.org]
> On Behalf Of Vabhav Sharma
> Sent: Monday, October 29, 2018 2:28 PM
> To: sudeep.holla@arm.com; oss@buserror.net; linux-kernel@vger.kernel.org;
> devicetree@vger.kernel.org; robh+dt@kernel.org; mark.rutland@arm.com;
> linuxppc-dev@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org;
> mturquette@baylibre.com; sboyd@kernel.org; rjw@rjwysocki.net;
> viresh.kumar@linaro.org; linux-clk@vger.kernel.org; linux-pm@vger.kernel.org;
> linux-kernel-owner@vger.kernel.org; catalin.marinas@arm.com;
> will.deacon@arm.com; gregkh@linuxfoundation.org; arnd@arndb.de;
> kstewart@linuxfoundation.org; yamada.masahiro@socionext.com; Leo Li
> <leoyang.li@nxp.com>; shawnguo@kernel.org
> Cc: ulf.hansson@linaro.org; Udit Kumar <udit.kumar@nxp.com>; Pankaj Bansal
> <pankaj.bansal@nxp.com>; linux@armlinux.org.uk; adrian.hunter@intel.com;
> Varun Sethi <V.Sethi@nxp.com>; Vabhav Sharma <vabhav.sharma@nxp.com>;
> Yinbo Zhu <yinbo.zhu@nxp.com>
> Subject: [PATCH v7 2/6] soc/fsl/guts: Add definition for LX2160A
> 
> Adding compatible string "lx2160a-dcfg" to initialize guts driver for lx2160 and
> SoC die attribute definition for LX2160A
> 
> Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
> Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
> Acked-by: Li Yang <leoyang.li@nxp.com>
> ---
>  drivers/soc/fsl/guts.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/soc/fsl/guts.c b/drivers/soc/fsl/guts.c index
> 302e0c8..bcab1ee 100644
> --- a/drivers/soc/fsl/guts.c
> +++ b/drivers/soc/fsl/guts.c
> @@ -100,6 +100,11 @@ static const struct fsl_soc_die_attr fsl_soc_die[] = {
>  	  .svr		= 0x87000000,
>  	  .mask		= 0xfff70000,
>  	},
> +	/* Die: LX2160A, SoC: LX2160A/LX2120A/LX2080A */
> +	{ .die          = "LX2160A",
> +	  .svr          = 0x87360000,
Do all  the threevariants " LX2160A/LX2120A/LX2080A"  have same SVR?
> +	  .mask         = 0xff3f0000,
> +	},
>  	{ },
>  };
> 
> @@ -222,6 +227,7 @@ static const struct of_device_id fsl_guts_of_match[] = {
>  	{ .compatible = "fsl,ls1088a-dcfg", },
>  	{ .compatible = "fsl,ls1012a-dcfg", },
>  	{ .compatible = "fsl,ls1046a-dcfg", },
> +	{ .compatible = "fsl,lx2160a-dcfg", },
>  	{}
>  };
>  MODULE_DEVICE_TABLE(of, fsl_guts_of_match);
> --
> 2.7.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.infr
> adead.org%2Fmailman%2Flistinfo%2Flinux-arm-
> kernel&amp;data=02%7C01%7Cpoonam.aggrwal%40nxp.com%7Cd9b7c36c786
> 54cd6dc4008d63d7fee63%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> %7C636764017001504288&amp;sdata=pqFMlw6yVrHrvn4YRhqj%2FmoOnSscrZu
> tcoYn3In8OJc%3D&amp;reserved=0
Yinbo Zhu Oct. 30, 2018, 3:39 a.m. UTC | #2
-----Original Message-----
From: Poonam Aggrwal 
Sent: 2018年10月29日 19:09
To: Vabhav Sharma <vabhav.sharma@nxp.com>; sudeep.holla@arm.com; oss@buserror.net; linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; robh+dt@kernel.org; mark.rutland@arm.com; linuxppc-dev@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org; mturquette@baylibre.com; sboyd@kernel.org; rjw@rjwysocki.net; viresh.kumar@linaro.org; linux-clk@vger.kernel.org; linux-pm@vger.kernel.org; linux-kernel-owner@vger.kernel.org; catalin.marinas@arm.com; will.deacon@arm.com; gregkh@linuxfoundation.org; arnd@arndb.de; kstewart@linuxfoundation.org; yamada.masahiro@socionext.com; Leo Li <leoyang.li@nxp.com>; shawnguo@kernel.org
Cc: ulf.hansson@linaro.org; Udit Kumar <udit.kumar@nxp.com>; Pankaj Bansal <pankaj.bansal@nxp.com>; linux@armlinux.org.uk; adrian.hunter@intel.com; Varun Sethi <V.Sethi@nxp.com>; Vabhav Sharma <vabhav.sharma@nxp.com>; Yinbo Zhu <yinbo.zhu@nxp.com>
Subject: RE: [PATCH v7 2/6] soc/fsl/guts: Add definition for LX2160A



> -----Original Message-----
> From: linux-arm-kernel 
> [mailto:linux-arm-kernel-bounces@lists.infradead.org]
> On Behalf Of Vabhav Sharma
> Sent: Monday, October 29, 2018 2:28 PM
> To: sudeep.holla@arm.com; oss@buserror.net; 
> linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; 
> robh+dt@kernel.org; mark.rutland@arm.com; 
> linuxppc-dev@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org;
> mturquette@baylibre.com; sboyd@kernel.org; rjw@rjwysocki.net; 
> viresh.kumar@linaro.org; linux-clk@vger.kernel.org; 
> linux-pm@vger.kernel.org; linux-kernel-owner@vger.kernel.org; 
> catalin.marinas@arm.com; will.deacon@arm.com; 
> gregkh@linuxfoundation.org; arnd@arndb.de; 
> kstewart@linuxfoundation.org; yamada.masahiro@socionext.com; Leo Li 
> <leoyang.li@nxp.com>; shawnguo@kernel.org
> Cc: ulf.hansson@linaro.org; Udit Kumar <udit.kumar@nxp.com>; Pankaj 
> Bansal <pankaj.bansal@nxp.com>; linux@armlinux.org.uk; 
> adrian.hunter@intel.com; Varun Sethi <V.Sethi@nxp.com>; Vabhav Sharma 
> <vabhav.sharma@nxp.com>; Yinbo Zhu <yinbo.zhu@nxp.com>
> Subject: [PATCH v7 2/6] soc/fsl/guts: Add definition for LX2160A
> 
> Adding compatible string "lx2160a-dcfg" to initialize guts driver for 
> lx2160 and SoC die attribute definition for LX2160A
> 
> Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
> Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
> Acked-by: Li Yang <leoyang.li@nxp.com>
> ---
>  drivers/soc/fsl/guts.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/soc/fsl/guts.c b/drivers/soc/fsl/guts.c index 
> 302e0c8..bcab1ee 100644
> --- a/drivers/soc/fsl/guts.c
> +++ b/drivers/soc/fsl/guts.c
> @@ -100,6 +100,11 @@ static const struct fsl_soc_die_attr fsl_soc_die[] = {
>  	  .svr		= 0x87000000,
>  	  .mask		= 0xfff70000,
>  	},
> +	/* Die: LX2160A, SoC: LX2160A/LX2120A/LX2080A */
> +	{ .die          = "LX2160A",
> +	  .svr          = 0x87360000,
>Do all  the threevariants " LX2160A/LX2120A/LX2080A"  have same SVR?
Dear Poonam Aggrwal,

No, but the threevariants " LX2160A/LX2120A/LX2080A" has same svr value in this struct,
Because they all are variants of lx2160, the svr value in this struct is equal the soc svr && mask

Best Regards,
Yinbo Zhu.

> +	  .mask         = 0xff3f0000,
> +	},
>  	{ },
>  };
> 
> @@ -222,6 +227,7 @@ static const struct of_device_id fsl_guts_of_match[] = {
>  	{ .compatible = "fsl,ls1088a-dcfg", },
>  	{ .compatible = "fsl,ls1012a-dcfg", },
>  	{ .compatible = "fsl,ls1046a-dcfg", },
> +	{ .compatible = "fsl,lx2160a-dcfg", },
>  	{}
>  };
>  MODULE_DEVICE_TABLE(of, fsl_guts_of_match);
> --
> 2.7.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flist
> s.infr
> adead.org%2Fmailman%2Flistinfo%2Flinux-arm-
> kernel&amp;data=02%7C01%7Cpoonam.aggrwal%40nxp.com%7Cd9b7c36c786
> 54cd6dc4008d63d7fee63%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> %7C636764017001504288&amp;sdata=pqFMlw6yVrHrvn4YRhqj%2FmoOnSscrZu
> tcoYn3In8OJc%3D&amp;reserved=0

Patch
diff mbox series

diff --git a/drivers/soc/fsl/guts.c b/drivers/soc/fsl/guts.c
index 302e0c8..bcab1ee 100644
--- a/drivers/soc/fsl/guts.c
+++ b/drivers/soc/fsl/guts.c
@@ -100,6 +100,11 @@  static const struct fsl_soc_die_attr fsl_soc_die[] = {
 	  .svr		= 0x87000000,
 	  .mask		= 0xfff70000,
 	},
+	/* Die: LX2160A, SoC: LX2160A/LX2120A/LX2080A */
+	{ .die          = "LX2160A",
+	  .svr          = 0x87360000,
+	  .mask         = 0xff3f0000,
+	},
 	{ },
 };
 
@@ -222,6 +227,7 @@  static const struct of_device_id fsl_guts_of_match[] = {
 	{ .compatible = "fsl,ls1088a-dcfg", },
 	{ .compatible = "fsl,ls1012a-dcfg", },
 	{ .compatible = "fsl,ls1046a-dcfg", },
+	{ .compatible = "fsl,lx2160a-dcfg", },
 	{}
 };
 MODULE_DEVICE_TABLE(of, fsl_guts_of_match);