Support RTC charging on PFUZE100
diff mbox series

Message ID 20181030143718.10027-1-aford173@gmail.com
State New
Headers show
Series
  • Support RTC charging on PFUZE100
Related show

Commit Message

Adam Ford Oct. 30, 2018, 2:37 p.m. UTC

Comments

Mark Brown Nov. 14, 2018, 10:25 p.m. UTC | #1
On Tue, Oct 30, 2018 at 09:37:18AM -0500, Adam Ford wrote:
> 
> diff --git a/arch/arm/boot/dts/imx6-logicpd-som.dtsi b/arch/arm/boot/dts/imx6-logicpd-som.dtsi
> index 1e5dcac70045..74ab5d65106b 100755
> --- a/arch/arm/boot/dts/imx6-logicpd-som.dtsi
> +++ b/arch/arm/boot/dts/imx6-logicpd-som.dtsi

> diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c
> index 659e516455be..bdef74077d1c 100644
> --- a/drivers/regulator/pfuze100-regulator.c
> +++ b/drivers/regulator/pfuze100-regulator.c

Please follow the patch submission process covered in
submitting-patchest.rst.  You've not included a Signed-off-by which is
essential for legal reasons as covered in there and this is a single
patch which mixes a DT change and a regulator driver change which should
be in separate patches.
Adam Ford Nov. 19, 2018, 8:29 p.m. UTC | #2
On Wed, Nov 14, 2018 at 4:25 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Tue, Oct 30, 2018 at 09:37:18AM -0500, Adam Ford wrote:
> >
> > diff --git a/arch/arm/boot/dts/imx6-logicpd-som.dtsi b/arch/arm/boot/dts/imx6-logicpd-som.dtsi
> > index 1e5dcac70045..74ab5d65106b 100755
> > --- a/arch/arm/boot/dts/imx6-logicpd-som.dtsi
> > +++ b/arch/arm/boot/dts/imx6-logicpd-som.dtsi
>
> > diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c
> > index 659e516455be..bdef74077d1c 100644
> > --- a/drivers/regulator/pfuze100-regulator.c
> > +++ b/drivers/regulator/pfuze100-regulator.c
>
> Please follow the patch submission process covered in
> submitting-patchest.rst.  You've not included a Signed-off-by which is
> essential for legal reasons as covered in there and this is a single
> patch which mixes a DT change and a regulator driver change which should
> be in separate patches.

Mark,

I think you're looking at the V1 patch.  This was replaced by a V2
patch:  https://patchwork.kernel.org/patch/10661227/

It should have a S-o-b line.  I know I sent it to the wrong mailing
list (per your other e-mail to me) , so if you want it re-mailed, I
can do that.

thank you,

adam
Mark Brown Nov. 23, 2018, 1:11 p.m. UTC | #3
On Mon, Nov 19, 2018 at 02:29:15PM -0600, Adam Ford wrote:

> I think you're looking at the V1 patch.  This was replaced by a V2
> patch:  https://patchwork.kernel.org/patch/10661227/

> It should have a S-o-b line.  I know I sent it to the wrong mailing
> list (per your other e-mail to me) , so if you want it re-mailed, I
> can do that.

Please resend the patch, I don't have anything else in my inbox.

Patch
diff mbox series

diff --git a/arch/arm/boot/dts/imx6-logicpd-som.dtsi b/arch/arm/boot/dts/imx6-logicpd-som.dtsi
index 1e5dcac70045..74ab5d65106b 100755
--- a/arch/arm/boot/dts/imx6-logicpd-som.dtsi
+++ b/arch/arm/boot/dts/imx6-logicpd-som.dtsi
@@ -178,6 +178,12 @@ 
 				regulator-max-microvolt = <2500000>;
 				regulator-always-on;
 			};
+
+			coin_reg: coin {
+				regulator-min-microvolt = <2500000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-always-on;
+			};
 		};
 	};
 
diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c
index 659e516455be..bdef74077d1c 100644
--- a/drivers/regulator/pfuze100-regulator.c
+++ b/drivers/regulator/pfuze100-regulator.c
@@ -324,6 +324,7 @@  static struct pfuze_regulator pfuze100_regulators[] = {
 	PFUZE100_VGEN_REG(PFUZE100, VGEN4, PFUZE100_VGEN4VOL, 1800000, 3300000, 100000),
 	PFUZE100_VGEN_REG(PFUZE100, VGEN5, PFUZE100_VGEN5VOL, 1800000, 3300000, 100000),
 	PFUZE100_VGEN_REG(PFUZE100, VGEN6, PFUZE100_VGEN6VOL, 1800000, 3300000, 100000),
+	PFUZE100_COIN_REG(PFUZE200, COIN, PFUZE100_COINVOL, 0x7, pfuze100_coin),
 };
 
 static struct pfuze_regulator pfuze200_regulators[] = {
@@ -377,6 +378,7 @@  static struct of_regulator_match pfuze100_matches[] = {
 	{ .name = "vgen4",	},
 	{ .name = "vgen5",	},
 	{ .name = "vgen6",	},
+	{ .name = "coin",	},
 };
 
 /* PFUZE200 */