From patchwork Fri Nov 2 09:15:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10665187 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DC3B315E9 for ; Fri, 2 Nov 2018 09:15:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CAD4A2BA77 for ; Fri, 2 Nov 2018 09:15:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BF6432BA9B; Fri, 2 Nov 2018 09:15:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6A35E2BA77 for ; Fri, 2 Nov 2018 09:15:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C3F9A6E557; Fri, 2 Nov 2018 09:15:49 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4F8816E552 for ; Fri, 2 Nov 2018 09:15:46 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id z12-v6so1284042edp.7 for ; Fri, 02 Nov 2018 02:15:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0hcLgSbnuVeYsG8/H4zoM7531Zi0SnXvmscx9g6zWio=; b=Dh5GsjRFOF0S/PGC2DP02lD+0KyudQ7ItYwEaNJq0Uy3TxysTIuopAA4kXschvqWBq VjSFpggZb+6JZsePxZ9Foc+PlOKD9d18vktl+EJWFDbA/dBKCImCMx5MdEbmymmHeZXK 9tDVgNcCzMgPOi9pdbcTtdVZCItJbDJFnn6jZC4MtTjKoTT7aXS1DUEgsdsIFatioAd+ OLg64jttl9YAvso/x4cZVC/nk7dBm55oCVPRZQD724svx0t3DqVCWQ3/Y6wmHjotWqv6 +4O2tdydL1efIycAUwAky222IsgkUBk2GLxii9s1LkK598Zac3p2kV2C9xtcil5FjeUn N5bw== X-Gm-Message-State: AGRZ1gKSKACTvDxwzuYVu4L1O1zI6yaG0EkM8xpKxyo9AgbEA7jAzbVG csPpT/3VIVm2pMMErSscN/oiiDIxxV4= X-Google-Smtp-Source: AJdET5f7/37ME/hrK3tn1IRvgxHFNAnbMgvCTKojxMFEDIxlUdiV3I13QjHOumNCbM+ejPU0z1/jvA== X-Received: by 2002:aa7:cf1a:: with SMTP id a26-v6mr7688764edy.91.1541150144456; Fri, 02 Nov 2018 02:15:44 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id p19-v6sm5658103ejw.69.2018.11.02.02.15.43 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 02 Nov 2018 02:15:43 -0700 (PDT) From: Daniel Vetter To: Intel Graphics Development Date: Fri, 2 Nov 2018 10:15:24 +0100 Message-Id: <20181102091531.7775-5-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181102091531.7775-1-daniel.vetter@ffwll.ch> References: <20181102091531.7775-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH 05/12] mm: Check if mmu notifier callbacks are allowed to fail X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP Just a bit of paranoia, since if we start pushing this deep into callchains it's hard to spot all places where an mmu notifier implementation might fail when it's not allowed to. Cc: Andrew Morton Cc: Michal Hocko Cc: "Christian König" Cc: David Rientjes Cc: Daniel Vetter Cc: "Jérôme Glisse" Cc: linux-mm@kvack.org Cc: Paolo Bonzini Signed-off-by: Daniel Vetter --- mm/mmu_notifier.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/mmu_notifier.c b/mm/mmu_notifier.c index 82bb1a939c0e..744840e5636e 100644 --- a/mm/mmu_notifier.c +++ b/mm/mmu_notifier.c @@ -190,6 +190,8 @@ int __mmu_notifier_invalidate_range_start(struct mm_struct *mm, pr_info("%pS callback failed with %d in %sblockable context.\n", mn->ops->invalidate_range_start, _ret, !blockable ? "non-" : ""); + WARN(blockable,"%pS callback failure not allowed\n", + mn->ops->invalidate_range_start); ret = _ret; } }