[v2] i2c: rk3x: fix some typo
diff mbox series

Message ID 20181102124535.24331-1-tiny.windzz@gmail.com
State New
Headers show
Series
  • [v2] i2c: rk3x: fix some typo
Related show

Commit Message

Frank Lee Nov. 2, 2018, 12:45 p.m. UTC
Fix multiple instances of a misspelled "Calculates".

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
---
Changes in v2:
-add commit message
---
 drivers/i2c/busses/i2c-rk3x.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Peter Rosin Nov. 2, 2018, 12:58 p.m. UTC | #1
On 2018-11-02 13:45, Yangtao Li wrote:
> Fix multiple instances of a misspelled "Calculates".

Yes, it sure is hard to spell "Calcluated," it's almost impossible to
get it completely right and not introduce another typo somewhere... :-)

Cheers,
Peter

> 
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> ---
> Changes in v2:
> -add commit message
> ---
>  drivers/i2c/busses/i2c-rk3x.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
> index b8a2728dd4b6..fe347e8e2a23 100644
> --- a/drivers/i2c/busses/i2c-rk3x.c
> +++ b/drivers/i2c/busses/i2c-rk3x.c
> @@ -555,7 +555,7 @@ static const struct i2c_spec_values *rk3x_i2c_get_spec(unsigned int speed)
>   *
>   * @clk_rate: I2C input clock rate
>   * @t: Known I2C timing information
> - * @t_calc: Caculated rk3x private timings that would be written into regs
> + * @t_calc: Calculated rk3x private timings that would be written into regs
>   *
>   * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case
>   * a best-effort divider value is returned in divs. If the target rate is
> @@ -716,7 +716,7 @@ static int rk3x_i2c_v0_calc_timings(unsigned long clk_rate,
>   *
>   * @clk_rate: I2C input clock rate
>   * @t: Known I2C timing information
> - * @t_calc: Caculated rk3x private timings that would be written into regs
> + * @t_calc: Calculated rk3x private timings that would be written into regs
>   *
>   * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case
>   * a best-effort divider value is returned in divs. If the target rate is
>
Frank Lee Nov. 5, 2018, 3:59 p.m. UTC | #2
I am sorry.
-- Yangtao
On Fri, Nov 2, 2018 at 8:58 PM Peter Rosin <peda@axentia.se> wrote:
>
> On 2018-11-02 13:45, Yangtao Li wrote:
> > Fix multiple instances of a misspelled "Calculates".
>
> Yes, it sure is hard to spell "Calcluated," it's almost impossible to
> get it completely right and not introduce another typo somewhere... :-)
>
> Cheers,
> Peter
>
> >
> > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> > Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> > ---
> > Changes in v2:
> > -add commit message
> > ---
> >  drivers/i2c/busses/i2c-rk3x.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
> > index b8a2728dd4b6..fe347e8e2a23 100644
> > --- a/drivers/i2c/busses/i2c-rk3x.c
> > +++ b/drivers/i2c/busses/i2c-rk3x.c
> > @@ -555,7 +555,7 @@ static const struct i2c_spec_values *rk3x_i2c_get_spec(unsigned int speed)
> >   *
> >   * @clk_rate: I2C input clock rate
> >   * @t: Known I2C timing information
> > - * @t_calc: Caculated rk3x private timings that would be written into regs
> > + * @t_calc: Calculated rk3x private timings that would be written into regs
> >   *
> >   * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case
> >   * a best-effort divider value is returned in divs. If the target rate is
> > @@ -716,7 +716,7 @@ static int rk3x_i2c_v0_calc_timings(unsigned long clk_rate,
> >   *
> >   * @clk_rate: I2C input clock rate
> >   * @t: Known I2C timing information
> > - * @t_calc: Caculated rk3x private timings that would be written into regs
> > + * @t_calc: Calculated rk3x private timings that would be written into regs
> >   *
> >   * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case
> >   * a best-effort divider value is returned in divs. If the target rate is
> >
>
Heiko Stuebner Nov. 6, 2018, 12:01 p.m. UTC | #3
Hi Yangtao, Peter,

Am Montag, 5. November 2018, 16:59:58 CET schrieb Frank Lee:
> I am sorry.
> -- Yangtao

If anything, it is me that should be sorry, as I did suggest the
patch description, including the new spelling error.

And it took me like the whole weekend to actually realize where the
Calculated / Calculates error was hiding ;-) .


Heiko

> On Fri, Nov 2, 2018 at 8:58 PM Peter Rosin <peda@axentia.se> wrote:
> >
> > On 2018-11-02 13:45, Yangtao Li wrote:
> > > Fix multiple instances of a misspelled "Calculates".
> >
> > Yes, it sure is hard to spell "Calcluated," it's almost impossible to
> > get it completely right and not introduce another typo somewhere... :-)
> >
> > Cheers,
> > Peter
> >
> > >
> > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> > > Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> > > ---
> > > Changes in v2:
> > > -add commit message
> > > ---
> > >  drivers/i2c/busses/i2c-rk3x.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
> > > index b8a2728dd4b6..fe347e8e2a23 100644
> > > --- a/drivers/i2c/busses/i2c-rk3x.c
> > > +++ b/drivers/i2c/busses/i2c-rk3x.c
> > > @@ -555,7 +555,7 @@ static const struct i2c_spec_values *rk3x_i2c_get_spec(unsigned int speed)
> > >   *
> > >   * @clk_rate: I2C input clock rate
> > >   * @t: Known I2C timing information
> > > - * @t_calc: Caculated rk3x private timings that would be written into regs
> > > + * @t_calc: Calculated rk3x private timings that would be written into regs
> > >   *
> > >   * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case
> > >   * a best-effort divider value is returned in divs. If the target rate is
> > > @@ -716,7 +716,7 @@ static int rk3x_i2c_v0_calc_timings(unsigned long clk_rate,
> > >   *
> > >   * @clk_rate: I2C input clock rate
> > >   * @t: Known I2C timing information
> > > - * @t_calc: Caculated rk3x private timings that would be written into regs
> > > + * @t_calc: Calculated rk3x private timings that would be written into regs
> > >   *
> > >   * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case
> > >   * a best-effort divider value is returned in divs. If the target rate is
> > >
> >
>
Frank Lee Nov. 6, 2018, 1:01 p.m. UTC | #4
Hi Heiko:

please,correct it in the cimmit message.

--Yangtao
On Tue, Nov 6, 2018 at 8:01 PM Heiko Stuebner <heiko@sntech.de> wrote:
>
> Hi Yangtao, Peter,
>
> Am Montag, 5. November 2018, 16:59:58 CET schrieb Frank Lee:
> > I am sorry.
> > -- Yangtao
>
> If anything, it is me that should be sorry, as I did suggest the
> patch description, including the new spelling error.
>
> And it took me like the whole weekend to actually realize where the
> Calculated / Calculates error was hiding ;-) .
>
>
> Heiko
>
> > On Fri, Nov 2, 2018 at 8:58 PM Peter Rosin <peda@axentia.se> wrote:
> > >
> > > On 2018-11-02 13:45, Yangtao Li wrote:
> > > > Fix multiple instances of a misspelled "Calculates".
> > >
> > > Yes, it sure is hard to spell "Calcluated," it's almost impossible to
> > > get it completely right and not introduce another typo somewhere... :-)
> > >
> > > Cheers,
> > > Peter
> > >
> > > >
> > > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> > > > Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> > > > ---
> > > > Changes in v2:
> > > > -add commit message
> > > > ---
> > > >  drivers/i2c/busses/i2c-rk3x.c | 4 ++--
> > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
> > > > index b8a2728dd4b6..fe347e8e2a23 100644
> > > > --- a/drivers/i2c/busses/i2c-rk3x.c
> > > > +++ b/drivers/i2c/busses/i2c-rk3x.c
> > > > @@ -555,7 +555,7 @@ static const struct i2c_spec_values *rk3x_i2c_get_spec(unsigned int speed)
> > > >   *
> > > >   * @clk_rate: I2C input clock rate
> > > >   * @t: Known I2C timing information
> > > > - * @t_calc: Caculated rk3x private timings that would be written into regs
> > > > + * @t_calc: Calculated rk3x private timings that would be written into regs
> > > >   *
> > > >   * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case
> > > >   * a best-effort divider value is returned in divs. If the target rate is
> > > > @@ -716,7 +716,7 @@ static int rk3x_i2c_v0_calc_timings(unsigned long clk_rate,
> > > >   *
> > > >   * @clk_rate: I2C input clock rate
> > > >   * @t: Known I2C timing information
> > > > - * @t_calc: Caculated rk3x private timings that would be written into regs
> > > > + * @t_calc: Calculated rk3x private timings that would be written into regs
> > > >   *
> > > >   * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case
> > > >   * a best-effort divider value is returned in divs. If the target rate is
> > > >
> > >
> >
>
>
>
>
Frank Lee Nov. 6, 2018, 1:02 p.m. UTC | #5
add myself.
On Tue, Nov 6, 2018 at 9:01 PM Frank Lee <tiny.windzz@gmail.com> wrote:
>
> Hi Heiko:
>
> please,correct it in the cimmit message.
>
> --Yangtao
> On Tue, Nov 6, 2018 at 8:01 PM Heiko Stuebner <heiko@sntech.de> wrote:
> >
> > Hi Yangtao, Peter,
> >
> > Am Montag, 5. November 2018, 16:59:58 CET schrieb Frank Lee:
> > > I am sorry.
> > > -- Yangtao
> >
> > If anything, it is me that should be sorry, as I did suggest the
> > patch description, including the new spelling error.
> >
> > And it took me like the whole weekend to actually realize where the
> > Calculated / Calculates error was hiding ;-) .
> >
> >
> > Heiko
> >
> > > On Fri, Nov 2, 2018 at 8:58 PM Peter Rosin <peda@axentia.se> wrote:
> > > >
> > > > On 2018-11-02 13:45, Yangtao Li wrote:
> > > > > Fix multiple instances of a misspelled "Calculates".
> > > >
> > > > Yes, it sure is hard to spell "Calcluated," it's almost impossible to
> > > > get it completely right and not introduce another typo somewhere... :-)
> > > >
> > > > Cheers,
> > > > Peter
> > > >
> > > > >
> > > > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> > > > > Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> > > > > ---
> > > > > Changes in v2:
> > > > > -add commit message
> > > > > ---
> > > > >  drivers/i2c/busses/i2c-rk3x.c | 4 ++--
> > > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > > >
> > > > > diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
> > > > > index b8a2728dd4b6..fe347e8e2a23 100644
> > > > > --- a/drivers/i2c/busses/i2c-rk3x.c
> > > > > +++ b/drivers/i2c/busses/i2c-rk3x.c
> > > > > @@ -555,7 +555,7 @@ static const struct i2c_spec_values *rk3x_i2c_get_spec(unsigned int speed)
> > > > >   *
> > > > >   * @clk_rate: I2C input clock rate
> > > > >   * @t: Known I2C timing information
> > > > > - * @t_calc: Caculated rk3x private timings that would be written into regs
> > > > > + * @t_calc: Calculated rk3x private timings that would be written into regs
> > > > >   *
> > > > >   * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case
> > > > >   * a best-effort divider value is returned in divs. If the target rate is
> > > > > @@ -716,7 +716,7 @@ static int rk3x_i2c_v0_calc_timings(unsigned long clk_rate,
> > > > >   *
> > > > >   * @clk_rate: I2C input clock rate
> > > > >   * @t: Known I2C timing information
> > > > > - * @t_calc: Caculated rk3x private timings that would be written into regs
> > > > > + * @t_calc: Calculated rk3x private timings that would be written into regs
> > > > >   *
> > > > >   * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case
> > > > >   * a best-effort divider value is returned in divs. If the target rate is
> > > > >
> > > >
> > >
> >
> >
> >
> >
Wolfram Sang Nov. 9, 2018, 4:09 p.m. UTC | #6
On Tue, Nov 06, 2018 at 01:01:33PM +0100, Heiko Stuebner wrote:
> Hi Yangtao, Peter,
> 
> Am Montag, 5. November 2018, 16:59:58 CET schrieb Frank Lee:
> > I am sorry.
> > -- Yangtao
> 
> If anything, it is me that should be sorry, as I did suggest the
> patch description, including the new spelling error.
> 
> And it took me like the whole weekend to actually realize where the
> Calculated / Calculates error was hiding ;-) .

You guys are fun :) Anyhow, $subject is way too generic, that is the
real culprit here. I don't mind empty descriptions, so you can basically
move the message into the header.

Patch
diff mbox series

diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
index b8a2728dd4b6..fe347e8e2a23 100644
--- a/drivers/i2c/busses/i2c-rk3x.c
+++ b/drivers/i2c/busses/i2c-rk3x.c
@@ -555,7 +555,7 @@  static const struct i2c_spec_values *rk3x_i2c_get_spec(unsigned int speed)
  *
  * @clk_rate: I2C input clock rate
  * @t: Known I2C timing information
- * @t_calc: Caculated rk3x private timings that would be written into regs
+ * @t_calc: Calculated rk3x private timings that would be written into regs
  *
  * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case
  * a best-effort divider value is returned in divs. If the target rate is
@@ -716,7 +716,7 @@  static int rk3x_i2c_v0_calc_timings(unsigned long clk_rate,
  *
  * @clk_rate: I2C input clock rate
  * @t: Known I2C timing information
- * @t_calc: Caculated rk3x private timings that would be written into regs
+ * @t_calc: Calculated rk3x private timings that would be written into regs
  *
  * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case
  * a best-effort divider value is returned in divs. If the target rate is