diff mbox series

init/Kconfig: make CC_OPTIMIZE_FOR_DEBUGGING visible only for GCC

Message ID 20181105151719.4552-1-changbin.du@gmail.com (mailing list archive)
State New, archived
Headers show
Series init/Kconfig: make CC_OPTIMIZE_FOR_DEBUGGING visible only for GCC | expand

Commit Message

Changbin Du Nov. 5, 2018, 3:17 p.m. UTC
Currently CC_OPTIMIZE_FOR_DEBUGGING is only able to build with GCC.
For clang, -Og optimization level could break kernel build. So make
CC_OPTIMIZE_FOR_DEBUGGING visible only for GCC.

Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Changbin Du <changbin.du@gmail.com>
---
 init/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Masahiro Yamada Nov. 9, 2018, 3:03 p.m. UTC | #1
On Tue, Nov 6, 2018 at 12:18 AM Changbin Du <changbin.du@gmail.com> wrote:
>
> Currently CC_OPTIMIZE_FOR_DEBUGGING is only able to build with GCC.
> For clang, -Og optimization level could break kernel build. So make
> CC_OPTIMIZE_FOR_DEBUGGING visible only for GCC.
>
> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> Signed-off-by: Changbin Du <changbin.du@gmail.com>
> ---

I squashed this into the previous patch in the kbuild tree.

Thanks!


>  init/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/init/Kconfig b/init/Kconfig
> index 0fb9c0b5f1a1..d5fb0ee1400a 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -1107,6 +1107,7 @@ config CC_OPTIMIZE_FOR_SIZE
>
>  config CC_OPTIMIZE_FOR_DEBUGGING
>         bool "Optimize for better debugging experience (-Og)"
> +       depends on CC_IS_GCC
>         depends on $(cc-option,-Og)
>         select NO_AUTO_INLINE
>         help
> --
> 2.17.1
>
diff mbox series

Patch

diff --git a/init/Kconfig b/init/Kconfig
index 0fb9c0b5f1a1..d5fb0ee1400a 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -1107,6 +1107,7 @@  config CC_OPTIMIZE_FOR_SIZE
 
 config CC_OPTIMIZE_FOR_DEBUGGING
 	bool "Optimize for better debugging experience (-Og)"
+	depends on CC_IS_GCC
 	depends on $(cc-option,-Og)
 	select NO_AUTO_INLINE
 	help