From patchwork Tue Nov 6 13:19:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Z.Q. Hou" X-Patchwork-Id: 10670337 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 37F9413A4 for ; Tue, 6 Nov 2018 13:20:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 26D662A3A0 for ; Tue, 6 Nov 2018 13:20:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1AA522A3B2; Tue, 6 Nov 2018 13:20:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id BC9A92A3A0 for ; Tue, 6 Nov 2018 13:20:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=koI/T6X/Eo8xUC56ybd6aUNIZWS70g7oh44KHR1mlp4=; b=UeA+dpZqMepRYd jl5pJuKgb+i8Wo0J2b7o5mOYCHc7G6sehQu2RkSxBh0XDABy0AjeSzt2Mwm1zN5GQPvm4FqzJnyG3 ZEiN5Vp2qLI19IGIIiHqueArrdPkOMDmiIBAyZsIacM1t6XFfJxN8K+6s7NFxOn9Uynwh8LxvOozp 7lOVrcb7n01Zv6eLmIJTvyHEYgNnTe6ljXB3Rq3sfHqVFv6t9FzcIAf7OVOubJTNAFzv7ZhVr4TOw cEQPoiTxNHfECtMuKaUbGbjp74uh/7JMGsn3wYQoQcBA3WbzEoj58laU0bqdusdIcrLLtj7bAXhsV 6kjLZkuTBioQPwebKVQA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gK1Ha-0002G7-Ja; Tue, 06 Nov 2018 13:20:38 +0000 Received: from mail-db5eur01on0601.outbound.protection.outlook.com ([2a01:111:f400:fe02::601] helo=EUR01-DB5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gK1Gj-0008M2-Bs for linux-arm-kernel@lists.infradead.org; Tue, 06 Nov 2018 13:19:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9AC3UUG1F1PvvLngn7cYEsiSg64fPhRxYE3u5taIiX0=; b=u3bzRr1hhrhTHqw1BNhXj51o1rQaVjRvSO1GOnaRepJXtYW1Tjq3jbs1zJ2Z3iJLbOjHpx109quiZ1eFq28o0nIElvaVa2fqty8LuAn9pR+PisqWVToLz6Wb4GX+bBHnKSQoTfMLlXTSq4F9JElO0fp0hLtjLhOV+AKi9rTc9qU= Received: from DB5PR04MB1221.eurprd04.prod.outlook.com (10.162.155.27) by DB5PR04MB0984.eurprd04.prod.outlook.com (10.161.196.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.21; Tue, 6 Nov 2018 13:19:25 +0000 Received: from DB5PR04MB1221.eurprd04.prod.outlook.com ([fe80::6c36:f4cb:26c2:e8cb]) by DB5PR04MB1221.eurprd04.prod.outlook.com ([fe80::6c36:f4cb:26c2:e8cb%2]) with mapi id 15.20.1273.035; Tue, 6 Nov 2018 13:19:25 +0000 From: "Z.q. Hou" To: "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "bhelgaas@google.com" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "l.subrahmanya@mobiveil.co.in" , "shawnguo@kernel.org" , Leo Li , "lorenzo.pieralisi@arm.com" Subject: [PATCH 03/23] PCI: mobiveil: correct the returned error number Thread-Topic: [PATCH 03/23] PCI: mobiveil: correct the returned error number Thread-Index: AQHUddNWBw9Y+2zWwUWykmDsJwZN2g== Date: Tue, 6 Nov 2018 13:19:25 +0000 Message-ID: <20181106131807.29951-4-Zhiqiang.Hou@nxp.com> References: <20181106131807.29951-1-Zhiqiang.Hou@nxp.com> In-Reply-To: <20181106131807.29951-1-Zhiqiang.Hou@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK0PR03CA0008.apcprd03.prod.outlook.com (2603:1096:203:2e::20) To DB5PR04MB1221.eurprd04.prod.outlook.com (2a01:111:e400:51c2::27) authentication-results: spf=none (sender IP is ) smtp.mailfrom=zhiqiang.hou@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.73] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB5PR04MB0984; 6:8QcC08GxecpxAHu+xkULTEFr2LgMh6/h/glf029Y9w5hJ5nzUTfYSdTPjBkNT7ebH5jk7K5qaufiuvSmC6+lhnJNxvQZzOkUzOX4wEaCYOvnp1aHmX/yXmdh5b5j8pjbsMCdMtXv1jJtLn+M30XZEz2DAzIZvo5p+1StykvPKS9pP8TejP3wE6dJnnLhRBrRR1lgtcZmJ2DClJD/oEIbMaQ3Wo7HYMLvFGwP44LpAOhTkUONoTLeAMdr10Ze1CdhGfKAq3mb2V+xfDzX/lX/bUOve55U1u6S/rHwFuG/ekDlWGfW17l2L0ZHXuyk0HqExp2ipycvBYLrEGKxOWRF23/sLec+TGAQ3xG8RXRy57k3vK4cwoKOl1d2gsPcSWnHodw6DjOqJ069kATMMOQ+jrWpLMiBXcg1Nmp7W3aJz9ZGxl81rKjKtCabsph5lcH+hvmkPXgYnyiXM4AKH6FxJQ==; 5:l46jzSUURO7wuA8VmPerwbVZ9otX7BDzPzT8Iii5WsSRKpDNy6/irKlpYgo1CU+jceipj2Gt4ZS6skAymI83Nre5v1so+z/y0s3qC8DOZskAM3Pi0Z7/dct77EX6Kln6f52fkXweJSTtefvZMWw1kSou/c+dRpOQmJiOGW8a6No=; 7:6xK8d2lK8tecnTfpW309Xiyu7GBtryU0K7fwGpNLQwLfAQlqfgz7ETaPqdNBKBJgk81ZDcPBS4wMuuwnJmNt+0WpAyPmv6+NoPHqrC0nJPxYBgyQZYGZcyZny+kXV+WXmcnsNRVYMmLAhiGZhdc1JQ== x-ms-office365-filtering-correlation-id: b37e4529-cc03-4fc3-f2a7-08d643ea78c4 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB5PR04MB0984; x-ms-traffictypediagnostic: DB5PR04MB0984: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(269456686620040)(185117386973197); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(3231382)(944501410)(52105095)(6055026)(148016)(149066)(150057)(6041310)(20161123558120)(20161123564045)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:DB5PR04MB0984; BCL:0; PCL:0; RULEID:; SRVR:DB5PR04MB0984; x-forefront-prvs: 0848C1A6AA x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(39860400002)(366004)(136003)(396003)(199004)(189003)(68736007)(486006)(386003)(8936002)(3846002)(99286004)(71190400001)(81156014)(71200400001)(81166006)(53936002)(8676002)(105586002)(110136005)(54906003)(5660300001)(2616005)(446003)(11346002)(66066001)(97736004)(305945005)(7416002)(476003)(2900100001)(7736002)(106356001)(14444005)(2201001)(4326008)(2501003)(25786009)(1076002)(186003)(6486002)(26005)(2906002)(256004)(6512007)(36756003)(6116002)(6436002)(316002)(102836004)(52116002)(6506007)(86362001)(14454004)(76176011)(478600001)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR04MB0984; H:DB5PR04MB1221.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: dEJput1Ah59F2ebPX/TXauTSIxY1T3eUulFDh1zXL4Hcry5y7qWR2Ts7VAVSIYcww1O5qcGi3so4ddENNU/de0zHUcEzga/NhAa1N042gtfoGaTRiAjpE6ecIQJ/iih8Zfr0h+N1wJdWg8KNiIr/Gu7u1uqFv4dsy4wNBBMGulJ1pRKmgGF3xX062RYWzx3R5K+CmpwyFM3gRQF/gKiGVX9h7V03E7UEI2JTrgi6ytxGPb8tQ5CvUVjgWVTxLM8UL196jxAkA5uuI9TZ6g+7UCxBv74fQOkE42g0iNaNRiHQ0jEVBwlMEWEtScUqM9dbeirQeq/BVDxVYvJ1mwbFYOQgQacG4HyS/g+/FqA7GP4= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b37e4529-cc03-4fc3-f2a7-08d643ea78c4 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Nov 2018 13:19:25.3020 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR04MB0984 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181106_051945_404792_99D7147C X-CRM114-Status: GOOD ( 15.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "M.h. Lian" , "Z.q. Hou" , Xiaowei Bao , Mingkai Hu Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Hou Zhiqiang This patch corrected the returned error number by convention, and removed a unnecessary error check. Signed-off-by: Hou Zhiqiang --- drivers/pci/controller/pcie-mobiveil.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/pci/controller/pcie-mobiveil.c b/drivers/pci/controller/pcie-mobiveil.c index b87471f08a40..563210e731d3 100644 --- a/drivers/pci/controller/pcie-mobiveil.c +++ b/drivers/pci/controller/pcie-mobiveil.c @@ -819,7 +819,7 @@ static int mobiveil_pcie_init_irq_domain(struct mobiveil_pcie *pcie) if (!pcie->intx_domain) { dev_err(dev, "Failed to get a INTx IRQ domain\n"); - return -ENODEV; + return -ENOMEM; } raw_spin_lock_init(&pcie->intx_mask_lock); @@ -845,11 +845,9 @@ static int mobiveil_pcie_probe(struct platform_device *pdev) /* allocate the PCIe port */ bridge = devm_pci_alloc_host_bridge(dev, sizeof(*pcie)); if (!bridge) - return -ENODEV; + return -ENOMEM; pcie = pci_host_bridge_priv(bridge); - if (!pcie) - return -ENOMEM; pcie->pdev = pdev; @@ -866,7 +864,7 @@ static int mobiveil_pcie_probe(struct platform_device *pdev) &pcie->resources, &iobase); if (ret) { dev_err(dev, "Getting bridge resources failed\n"); - return -ENOMEM; + return ret; } /*