diff mbox series

[v4l-utils] libv4l2subdev: Add MEDIA_BUS_FMT_FIXED to mbus_formats[]

Message ID 1541524376-27795-1-git-send-email-yong.zhi@intel.com (mailing list archive)
State New, archived
Headers show
Series [v4l-utils] libv4l2subdev: Add MEDIA_BUS_FMT_FIXED to mbus_formats[] | expand

Commit Message

Zhi, Yong Nov. 6, 2018, 5:12 p.m. UTC
Also add V4L2_COLORSPACE_RAW to the colorspaces[].

Signed-off-by: Yong Zhi <yong.zhi@intel.com>
---
 utils/media-ctl/libv4l2subdev.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Sakari Ailus Nov. 7, 2018, 9:57 a.m. UTC | #1
Hi Yong,

On Tue, Nov 06, 2018 at 09:12:56AM -0800, Yong Zhi wrote:
> Also add V4L2_COLORSPACE_RAW to the colorspaces[].
> 
> Signed-off-by: Yong Zhi <yong.zhi@intel.com>
> ---
>  utils/media-ctl/libv4l2subdev.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/utils/media-ctl/libv4l2subdev.c b/utils/media-ctl/libv4l2subdev.c
> index a989efb..46668eb 100644
> --- a/utils/media-ctl/libv4l2subdev.c
> +++ b/utils/media-ctl/libv4l2subdev.c
> @@ -855,6 +855,7 @@ static const struct {
>  	enum v4l2_mbus_pixelcode code;
>  } mbus_formats[] = {
>  #include "media-bus-format-names.h"
> +	{ "FIXED", MEDIA_BUS_FMT_FIXED},
>  	{ "Y8", MEDIA_BUS_FMT_Y8_1X8},
>  	{ "Y10", MEDIA_BUS_FMT_Y10_1X10 },
>  	{ "Y12", MEDIA_BUS_FMT_Y12_1X12 },
> @@ -965,7 +966,9 @@ static struct {
>  	{ "srgb", V4L2_COLORSPACE_SRGB },
>  	{ "oprgb", V4L2_COLORSPACE_OPRGB },
>  	{ "bt2020", V4L2_COLORSPACE_BT2020 },
> +	{ "raw", V4L2_COLORSPACE_RAW },
>  	{ "dcip3", V4L2_COLORSPACE_DCI_P3 },
> +

Extra newlne.

I can remove it as well while applying the patch.

>  };
>  
>  const char *v4l2_subdev_colorspace_to_string(enum v4l2_colorspace colorspace)
Sakari Ailus Nov. 7, 2018, 10:17 a.m. UTC | #2
On Tue, Nov 06, 2018 at 09:12:56AM -0800, Yong Zhi wrote:
> Also add V4L2_COLORSPACE_RAW to the colorspaces[].
> 
> Signed-off-by: Yong Zhi <yong.zhi@intel.com>
> ---
>  utils/media-ctl/libv4l2subdev.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/utils/media-ctl/libv4l2subdev.c b/utils/media-ctl/libv4l2subdev.c
> index a989efb..46668eb 100644
> --- a/utils/media-ctl/libv4l2subdev.c
> +++ b/utils/media-ctl/libv4l2subdev.c
> @@ -855,6 +855,7 @@ static const struct {
>  	enum v4l2_mbus_pixelcode code;
>  } mbus_formats[] = {
>  #include "media-bus-format-names.h"
> +	{ "FIXED", MEDIA_BUS_FMT_FIXED},
>  	{ "Y8", MEDIA_BUS_FMT_Y8_1X8},
>  	{ "Y10", MEDIA_BUS_FMT_Y10_1X10 },
>  	{ "Y12", MEDIA_BUS_FMT_Y12_1X12 },
> @@ -965,7 +966,9 @@ static struct {
>  	{ "srgb", V4L2_COLORSPACE_SRGB },
>  	{ "oprgb", V4L2_COLORSPACE_OPRGB },
>  	{ "bt2020", V4L2_COLORSPACE_BT2020 },
> +	{ "raw", V4L2_COLORSPACE_RAW },
>  	{ "dcip3", V4L2_COLORSPACE_DCI_P3 },
> +
>  };
>  
>  const char *v4l2_subdev_colorspace_to_string(enum v4l2_colorspace colorspace)

The diff became:

diff --git a/utils/media-ctl/libv4l2subdev.c b/utils/media-ctl/libv4l2subdev.c
index 46668eb5..0d0afbe7 100644
--- a/utils/media-ctl/libv4l2subdev.c
+++ b/utils/media-ctl/libv4l2subdev.c
@@ -855,8 +855,8 @@ static const struct {
 	enum v4l2_mbus_pixelcode code;
 } mbus_formats[] = {
 #include "media-bus-format-names.h"
-	{ "FIXED", MEDIA_BUS_FMT_FIXED},
-	{ "Y8", MEDIA_BUS_FMT_Y8_1X8},
+	{ "FIXED", MEDIA_BUS_FMT_FIXED },
+	{ "Y8", MEDIA_BUS_FMT_Y8_1X8 },
 	{ "Y10", MEDIA_BUS_FMT_Y10_1X10 },
 	{ "Y12", MEDIA_BUS_FMT_Y12_1X12 },
 	{ "YUYV", MEDIA_BUS_FMT_YUYV8_1X16 },
@@ -968,7 +968,6 @@ static struct {
 	{ "bt2020", V4L2_COLORSPACE_BT2020 },
 	{ "raw", V4L2_COLORSPACE_RAW },
 	{ "dcip3", V4L2_COLORSPACE_DCI_P3 },
-
 };
 
 const char *v4l2_subdev_colorspace_to_string(enum v4l2_colorspace colorspace)
diff mbox series

Patch

diff --git a/utils/media-ctl/libv4l2subdev.c b/utils/media-ctl/libv4l2subdev.c
index a989efb..46668eb 100644
--- a/utils/media-ctl/libv4l2subdev.c
+++ b/utils/media-ctl/libv4l2subdev.c
@@ -855,6 +855,7 @@  static const struct {
 	enum v4l2_mbus_pixelcode code;
 } mbus_formats[] = {
 #include "media-bus-format-names.h"
+	{ "FIXED", MEDIA_BUS_FMT_FIXED},
 	{ "Y8", MEDIA_BUS_FMT_Y8_1X8},
 	{ "Y10", MEDIA_BUS_FMT_Y10_1X10 },
 	{ "Y12", MEDIA_BUS_FMT_Y12_1X12 },
@@ -965,7 +966,9 @@  static struct {
 	{ "srgb", V4L2_COLORSPACE_SRGB },
 	{ "oprgb", V4L2_COLORSPACE_OPRGB },
 	{ "bt2020", V4L2_COLORSPACE_BT2020 },
+	{ "raw", V4L2_COLORSPACE_RAW },
 	{ "dcip3", V4L2_COLORSPACE_DCI_P3 },
+
 };
 
 const char *v4l2_subdev_colorspace_to_string(enum v4l2_colorspace colorspace)