| Message ID | 1541565263-8296-3-git-send-email-j-keerthy@ti.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | opp: ti-opp-supply: Fixes | expand |
On 11/06/2018 10:34 PM, Keerthy wrote: > _get_optimal_vdd_voltage call provides new_supply_vbb->u_volt > as the reference voltage while it should be really new_supply_vdd->u_volt. > > Fixes: 9a835fa6e47 ("PM / OPP: Add ti-opp-supply driver") > Signed-off-by: Keerthy <j-keerthy@ti.com> > --- Acked-by: Dave Gerlach <d-gerlach@ti.com> Currently all corresponding vbb and vdd values provided by the device tree match which is why this does not fail, but this was a typo by me and vdd is the correct value to actually use. Regards, Dave > drivers/opp/ti-opp-supply.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/opp/ti-opp-supply.c b/drivers/opp/ti-opp-supply.c > index 29e08a4..3f4fb4d 100644 > --- a/drivers/opp/ti-opp-supply.c > +++ b/drivers/opp/ti-opp-supply.c > @@ -288,7 +288,7 @@ static int ti_opp_supply_set_opp(struct dev_pm_set_opp_data *data) > int ret; > > vdd_uv = _get_optimal_vdd_voltage(dev, &opp_data, > - new_supply_vbb->u_volt); > + new_supply_vdd->u_volt); > > if (new_supply_vdd->u_volt_min < vdd_uv) > new_supply_vdd->u_volt_min = vdd_uv; >
diff --git a/drivers/opp/ti-opp-supply.c b/drivers/opp/ti-opp-supply.c index 29e08a4..3f4fb4d 100644 --- a/drivers/opp/ti-opp-supply.c +++ b/drivers/opp/ti-opp-supply.c @@ -288,7 +288,7 @@ static int ti_opp_supply_set_opp(struct dev_pm_set_opp_data *data) int ret; vdd_uv = _get_optimal_vdd_voltage(dev, &opp_data, - new_supply_vbb->u_volt); + new_supply_vdd->u_volt); if (new_supply_vdd->u_volt_min < vdd_uv) new_supply_vdd->u_volt_min = vdd_uv;
_get_optimal_vdd_voltage call provides new_supply_vbb->u_volt as the reference voltage while it should be really new_supply_vdd->u_volt. Fixes: 9a835fa6e47 ("PM / OPP: Add ti-opp-supply driver") Signed-off-by: Keerthy <j-keerthy@ti.com> --- drivers/opp/ti-opp-supply.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)